Re: RFR[9]: 8147585: Annotations with lambda expressions has parameters result in wrong behavior.

Thanks Vladimir and Joel!! Please see http://cr.openjdk.java.net/~srastogi/8147585/webrev.04/ Added restriction for synthetic methods as well. On 6/2/2016 5:04 PM, Vladimir Ivanov wrote: On 6/2/16 12:02 AM, Joel Borggrén-Franck wrote: Hi, I think this was caught by the verifier before 8 sinc

Re: RFR 8152893 : StackWalker#getCallerClass is not filtering hidden/ reflection frames when walker is configured to show hidden /reflection frames

> On Jun 2, 2016, at 6:54 PM, Mandy Chung wrote: > >> >> On Jun 2, 2016, at 4:23 PM, Brent Christian >> wrote: >> >> Hi, >> >> The docs for StackWalker.getCallerClass() state, "Reflection frames, >> MethodHandle and hidden frames are filtered regardless of the >> SHOW_REFLECT_FRAMES and S

Re: RFR 8152893 : StackWalker#getCallerClass is not filtering hidden/ reflection frames when walker is configured to show hidden /reflection frames

> On Jun 2, 2016, at 4:23 PM, Brent Christian > wrote: > > Hi, > > The docs for StackWalker.getCallerClass() state, "Reflection frames, > MethodHandle and hidden frames are filtered regardless of the > SHOW_REFLECT_FRAMES and SHOW_HIDDEN_FRAMES options." > > However getCallerClass() is sens

[9] RFR: 8146156: Inconsistent default locale in string formatter methods

Hi, Please review the proposed fix to this issue: https://bugs.openjdk.java.net/browse/JDK-8146156 The fix is located at: http://cr.openjdk.java.net/~naoto/8146156/webrev.00/ The fix is to use the default locale for formatting where applicable. Naoto

RFR 8152893 : StackWalker#getCallerClass is not filtering hidden/ reflection frames when walker is configured to show hidden /reflection frames

Hi, The docs for StackWalker.getCallerClass() state, "Reflection frames, MethodHandle and hidden frames are filtered regardless of the SHOW_REFLECT_FRAMES and SHOW_HIDDEN_FRAMES options." However getCallerClass() is sensitive to the SHOW_*_FRAMES options, and calling getCallerClass() on a St

Re: Review request: JDK-8157892: StackFrame::getFileName returns null when a source file exists for native methods

> On Jun 2, 2016, at 3:11 PM, Daniel Fuchs wrote: > > Hi Mandy, > > Looks good to me. Though I wonder whether a better fix would be > to not tweak the bci for native methods in the native call that > sets the value to 0 (I assume this is what happens somewhere > since bci is initialized to -1 i

Re: Review request: JDK-8157892: StackFrame::getFileName returns null when a source file exists for native methods

Hi Mandy, Looks good to me. Though I wonder whether a better fix would be to not tweak the bci for native methods in the native call that sets the value to 0 (I assume this is what happens somewhere since bci is initialized to -1 in Java). best regards, -- daniel On 01/06/16 20:46, Mandy Chung

JDK 9 RFR of JDK-8136738: InputStream documentation for IOException in skip() is unclear or incorrect

Please review at your convenience this API doc-only change: Issue: https://bugs.openjdk.java.net/browse/JDK-8136738 Patch: http://cr.openjdk.java.net/~bpb/8136738/webrev.00/ Summary: Try to make the specification of InputStream.skip() slightly more precise. Thanks, Brian

Re: RFR JDK-8158482: regex UNICODE_CHARACTER_CLASS flag cannot be disabled with an embedded flag expression

Hi Sherman, Looks like a +1 to me. Brian On Jun 2, 2016, at 1:01 PM, Xueming Shen wrote: > Hi, > > Please review the change for JDK-8158482. It appears a "break" is > missing from the implementation. > > issue: https://bugs.openjdk.java.net/browse/JDK-8158482 > webrev: http://cr.openjdk.java

RFR JDK-8158482: regex UNICODE_CHARACTER_CLASS flag cannot be disabled with an embedded flag expression

Hi, Please review the change for JDK-8158482. It appears a "break" is missing from the implementation. issue: https://bugs.openjdk.java.net/browse/JDK-8158482 webrev: http://cr.openjdk.java.net/~sherman/8158482 Thanks, Sherman

Re: RFR (JAXP) 8158246: Several api/org_xml/sax/helpers/XMLReader tests failed due to no SAXException occurs

> On Jun 2, 2016, at 2:35 PM, Lance Andersen wrote: > > Hi Joe, > > think you are good to go > > Best > Lance >> On May 31, 2016, at 5:14 PM, huizhe wang > > wrote: >> >> Hi, >> >> This issue was caused by the change 8152912 where the logic was changed so >>

Re: RFR: 9: 8158560: Mark java/rmi/transport/dgcDeadLock/DGCDeadLock.java as intermittently faiing

I think "frequently" is an understatement. :-) This looks fine; please go ahead with it. Thanks. s'marks On 6/2/16 11:48 AM, Rajan Halade wrote: May I request you to review this patch to mark DGCDeadLock.java test with key intermittent. This test fails frequently. Bug: https://bugs.openjdk.j

RFR: 9: 8158560: Mark java/rmi/transport/dgcDeadLock/DGCDeadLock.java as intermittently faiing

May I request you to review this patch to mark DGCDeadLock.java test with key intermittent. This test fails frequently. Bug: https://bugs.openjdk.java.net/browse/JDK-8158560 diff -r fac51dc689e5 test/java/rmi/transport/dgcDeadLock/DGCDeadLock.java --- a/test/java/rmi/transport/dgcDeadLock/DGCDe

Re: JDK 9 RFR of BigDecimal.sqrt javadoc typo fix

++1 On Jun 2, 2016, at 9:18 AM, Lance Andersen wrote: > +1 >> On Jun 2, 2016, at 12:17 PM, joe darcy wrote: >> >> Hello, >> >> Please review the patch below to remove an extra "}" from the >> BigDecimal.sqrt javadoc.

Re: JDK 9 RFR of BigDecimal.sqrt javadoc typo fix

+1 > On Jun 2, 2016, at 12:17 PM, joe darcy wrote: > > Hello, > > Please review the patch below to remove an extra "}" from the BigDecimal.sqrt > javadoc. > > Thanks, > > -Joe > > > --- a/src/java.base/share/classes/java/math/BigDecimal.java Wed Jun 01 > 15:28:05 2016 -0700 > +++ b/src/jav

JDK 9 RFR of BigDecimal.sqrt javadoc typo fix

Hello, Please review the patch below to remove an extra "}" from the BigDecimal.sqrt javadoc. Thanks, -Joe --- a/src/java.base/share/classes/java/math/BigDecimal.java Wed Jun 01 15:28:05 2016 -0700 +++ b/src/java.base/share/classes/java/math/BigDecimal.javaThu Jun 02 09:15:56 2016 -07

Re: JDK 9 RFR of problem listing of IncludeLocalesPluginTest.java

On 6/2/2016 3:31 PM, Alan Bateman wrote: It's possible that the CLDR update added more languages and pushed this test over the edge. Excluding it temporarily should be fine while it is tracked down. The test doesn't detect any failures caused by the additional locales, which may or may not be

Re: RFR: 8114827: JDK 9 multi-release enabled jar tool

On 02/06/2016 02:02, Steve Drach wrote: Hi, Please review the following changeset that makes it easier to create multi-release jar files with jar tool. webrev: http://cr.openjdk.java.net/~sdrach/8114827/webrev.01/ issue: https://bugs.openjdk.java.net/browse/JDK-8114827 The changeset is the i

Re: RFR[9]:MethodHandles.dropArgumentsToMatch(...) non-documented IAE

Hi Shilpi, lower-case thumbs up. Please obtain CCC approval for this change. Best, Michael > Am 02.06.2016 um 11:38 schrieb shilpi.rast...@oracle.com: > > Hi All, > > Please review fix for > https://bugs.openjdk.java.net/browse/JDK-8158171 > http://cr.openjdk.java.net/~srastogi/8158171/webrev

Re: RFR[9]: 8156868 MethodHandles.zero(Class) doc issues

Hi Shilpi, lower-case thumbs up, and I'll be happy to sponsor this push. Best, Michael > Am 24.05.2016 um 14:23 schrieb Paul Sandoz : > > >> On 24 May 2016, at 08:40, shilpi.rast...@oracle.com wrote: >> >> Thanks Paul!! >> >> Please see http://cr.openjdk.java.net/~srastogi/8156868/webrev.02

Re: RFR[9]: 8147585: Annotations with lambda expressions has parameters result in wrong behavior.

On 6/2/16 12:02 AM, Joel Borggrén-Franck wrote: Hi, I think this was caught by the verifier before 8 since you couldn't have concrete or private methods in an interface. Now you can (though not in Java for private ones). My spider sense tells me there might be something lurking here (though i

RFR[9]:MethodHandles.dropArgumentsToMatch(...) non-documented IAE

Hi All, Please review fix for https://bugs.openjdk.java.net/browse/JDK-8158171 http://cr.openjdk.java.net/~srastogi/8158171/webrev.00/ Thanks, Shilpi