Re: Review request: JDK-8159630: Add new test for jdk.internal.misc.VM::getRuntimeArguments

On 17/06/2016 21:30, Mandy Chung wrote: http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8159630/webrev.00 This adds a new test for jdk.internal.misc.VM::getRuntimeArguments for sanity check. Mandy This looks okay except I assume it needs @modules for jdk.zipfs at least (maybe java.compact3

Re: Review request: JDK-8159630: Add new test for jdk.internal.misc.VM::getRuntimeArguments

Looks good Mandy > On Jun 17, 2016, at 4:30 PM, Mandy Chung wrote: > > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8159630/webrev.00 > > This adds a new test for jdk.internal.misc.VM::getRuntimeArguments for sanity > check. > > Mandy

Review request: JDK-8159630: Add new test for jdk.internal.misc.VM::getRuntimeArguments

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8159630/webrev.00 This adds a new test for jdk.internal.misc.VM::getRuntimeArguments for sanity check. Mandy

RFR 8054213: Class name repeated in output of Type.toString()

Hello, could you please review this fix for toString() method of ParameterizedTypeImpl. The problem is that when we obtain simple name of nested type shared prefix is only removed for ParameterizedType owner. We need to remove it for other cases too. Please note that I also changed delimiter

Re: Review Request: JDK-8159524 jdeps -jdkinternals throws NPE when no replacement is known

> On Jun 17, 2016, at 7:26 AM, Daniel Fuchs wrote: > > Hi Mandy, > > JdepsTask.java: > > 616 .filter(e -> e.getValue() != null) > > is this still needed? I thought the use of optional at line > 602 already filtered out the null values. > Good catch. It’s no longer n

Re: RFR 8159821 "PrimitiveStream.iterateFinite" methods contain incorrect code sample

Looks good Paul. -Chris. > On 17 Jun 2016, at 17:48, Paul Sandoz wrote: > > Hi, > > Please review minor corrections to the JavaDoc of the finite (predicate > accepting) iterate methods of Int/Long/DoubleStream. > > Thanks, > Paul. > > diff -r 6e55599ce242 > src/java.base/share/classes/java

Re: RFR 8159821 "PrimitiveStream.iterateFinite" methods contain incorrect code sample

+1. Good catch. > On Jun 17, 2016, at 12:48 PM, Paul Sandoz wrote: > > Hi, > > Please review minor corrections to the JavaDoc of the finite (predicate > accepting) iterate methods of Int/Long/DoubleStream. > > Thanks, > Paul. > > diff -r 6e55599ce242 > src/java.base/share/classes/java/util

RFR 8159821 "PrimitiveStream.iterateFinite" methods contain incorrect code sample

Hi, Please review minor corrections to the JavaDoc of the finite (predicate accepting) iterate methods of Int/Long/DoubleStream. Thanks, Paul. diff -r 6e55599ce242 src/java.base/share/classes/java/util/stream/DoubleStream.java --- a/src/java.base/share/classes/java/util/stream/DoubleStream.jav

Re: RFR: 8153955: java.util.logging.FileHandler can not create file synchronously over 101 access

Looks fine Ramanand. Please ensure the CCC is approved before pushing. 2 comments on the testcase : fileHendlers --> fileHandlers. Can you consider using the jdk.testlibrary.FileUtils.deleteFileIfExistsWithRetry for removal of directory that you create. It should be more stable in the long ru

Re: RFR 9: 8155808: Process.getInputStream().skip() method is faulty

On 17/06/16 14:57, Pavel Rappo wrote: Roger, On 17 Jun 2016, at 14:14, Roger Riggs wrote: Subclassing is the normal (one) way to override/augment behavior of an existing class. And I was looking for a minimal change since there have been many issues in this area. Also, I avoided the extra o

Re: RFR 9: 8155808: Process.getInputStream().skip() method is faulty

Hi Pavel, @Override added. Thanks, Roger On 6/17/2016 9:57 AM, Pavel Rappo wrote: Roger, On 17 Jun 2016, at 14:14, Roger Riggs wrote: Subclassing is the normal (one) way to override/augment behavior of an existing class. And I was looking for a minimal change since there have been many is

Re: RFR 9: 8155808: Process.getInputStream().skip() method is faulty

Hi Daniel, Webrev updated in place. http://cr.openjdk.java.net/~rriggs/webrev-skip-8155808/index.html On 6/17/2016 9:41 AM, Daniel Fuchs wrote: Hi Roger, Should PipeInputStream be final? It is extended by DeferredCloseInputStream, used on Solaris, and is private to the implementation so bei

Re: Review Request: JDK-8159524 jdeps -jdkinternals throws NPE when no replacement is known

Hi Mandy, JdepsTask.java: 616 .filter(e -> e.getValue() != null) is this still needed? I thought the use of optional at line 602 already filtered out the null values. 617 .sorted(Map.Entry.comparingByKey()) I believe you could get rid of that

Re: JDK-8153362: [jigsaw] Add javac -Xlint warning to list exposed types which are not accessible

Hi, I've updated the patches, reflecting the feedback so far. The langtools change is now split into two parts, one is only adding the new lint key (but no checks are actually performed): http://cr.openjdk.java.net/~jlahoda/8153362/langtools.01-phase1/ And the second part is adding the checks

Re: RFR 9: 8155808: Process.getInputStream().skip() method is faulty

Roger, > On 17 Jun 2016, at 14:14, Roger Riggs wrote: > > Subclassing is the normal (one) way to override/augment behavior of an > existing class. > And I was looking for a minimal change since there have been many issues in > this area. > Also, I avoided the extra object and performance overh

Re: RFR 9: 8155808: Process.getInputStream().skip() method is faulty

Hi Roger, Should PipeInputStream be final? If so I guess you could remove the first part of the sentence in the @exception clause (should that be @throws?): 655 * @exception IOException if the stream does not support seek, 656 * or if some other

Re: RFR 9: 8155808: Process.getInputStream().skip() method is faulty

Hi Pavel, On 6/17/2016 5:03 AM, Pavel Rappo wrote: Hi Roger, Do we need PipeInputStream to be a java.io.FileInputStream? Can we get away with it being an InputStream? If so, then we could use a simple delegation which would allow us to avoid code duplication (the implementation of `skip` is alm

Re: RFR: 8159590: Remove deprecated methods from jdk.internal.misc.VM

On 2016-06-17 03:35, David Holmes wrote: Hi Claes, On 17/06/2016 8:20 AM, Claes Redestad wrote: Isn't this variable unused now: 63 boolean vmAllowSuspension; Interestingly enough there are hooks in hotspot to compute offsets of various fields in j.l.ThreadGroup, so even though the vm

RE: RFR: 8153955: java.util.logging.FileHandler can not create file synchronously over 101 access

Hi All, Gentle reminder... Regards, Ramanand. -Original Message- From: Ramanand Patil Sent: Tuesday, June 14, 2016 9:51 PM To: Daniel Fuchs; Bernd Eckenfels; core-libs-dev@openjdk.java.net Subject: RE: RFR: 8153955: java.util.logging.FileHandler can not create file synchronously over 1

Re: RFR of JDK-8159785: Add test that tests ClassLoader.getResource/getResources in Multi-Release Jar

On 17/06/2016 08:38, Hamlin Li wrote: Would you please review the following patch? bug: https://bugs.openjdk.java.net/browse/JDK-8159785 webrev: http://cr.openjdk.java.net/~mli/8159785/webrev.00/ JDK-8151542 fixed bugs and added test to verify

Re: RFR 9: 8155808: Process.getInputStream().skip() method is faulty

Hi Roger, Do we need PipeInputStream to be a java.io.FileInputStream? Can we get away with it being an InputStream? If so, then we could use a simple delegation which would allow us to avoid code duplication (the implementation of `skip` is almost identical to one in InputStream): private sta

RFR of JDK-8159785: Add test that tests ClassLoader.getResource/getResources in Multi-Release Jar

Would you please review the following patch? bug: https://bugs.openjdk.java.net/browse/JDK-8159785 webrev: http://cr.openjdk.java.net/~mli/8159785/webrev.00/ JDK-8151542 fixed bugs and added test to verify Class.getResource works as expected, bu