RFR: 8155770 Correct URLClassLoader API documentation to explicitly say jar-scheme URL's are accepted

2016-06-24 Thread Steve Drach
Hi, Please review this simple change to the URLClassLoader specification. issue: https://bugs.openjdk.java.net/browse/JDK-8155770 webrev: http://cr.openjdk.java.net/~sdrach/8155770/webrev/ T

Re: Analysis on JDK-8022321 java/lang/ref/OOMEInReferenceHandler.java fails intermittently

2016-06-24 Thread Kim Barrett
I've just sent out an RFR for 8156500: deadlock provoked by new stress test com/sun/jdi/OomDebugTest.java The proposed fix incorporates the change suggested by Per and discussed in this thread of moving the pending reference list management entirely into the VM.

RFR: 8156500: deadlock provoked by new stress test com/sun/jdi/OomDebugTest.java

2016-06-24 Thread Kim Barrett
Please review this change which moves the Reference pending list and locking from the java.lang.ref.Reference class into the VM. This includes elimination of the ReferencePendingListLocker mechanism in the VM. This fixes various fragility issues arising from having the management of this list spli

Re: RFR 8159751: ObjectStreamClass: hide 'final' flag for anonymous classes

2016-06-24 Thread Dan Smith
> On Jun 23, 2016, at 3:21 PM, Roger Riggs wrote: >>> I would suggest javac to produce the same ACC_FINAL bits as it did before >>> for each -target version. >>> (I know it looks like a hack, but a compatible one). >>> Correct it for 9 and leave the SUID computation alone. >>> >> Okay, so I inte

Re: RFR 9: 8160278 Remove java/time/test/java/time/TestClock_System from the problem list

2016-06-24 Thread Daniel Fuchs
+1 -- daniel On 6/24/16 8:13 PM, Roger Riggs wrote: Please review removing TestClock_System from the problem list for Solaris. The underlying issue[3] has been fixed and propagated to jdk9 and this test can be re-enabled. 8157175 GetNanoTimeAdjustment.java fails with excessive adjustment error

Re: RFR 9: 8160278 Remove java/time/test/java/time/TestClock_System from the problem list

2016-06-24 Thread joe darcy
Looks fine; thanks, -Joe On 6/24/2016 11:13 AM, Roger Riggs wrote: Please review removing TestClock_System from the problem list for Solaris. The underlying issue[3] has been fixed and propagated to jdk9 and this test can be re-enabled. 8157175 GetNanoTimeAdjustment.java fails with excessi

RFR 9: 8160278 Remove java/time/test/java/time/TestClock_System from the problem list

2016-06-24 Thread Roger Riggs
Please review removing TestClock_System from the problem list for Solaris. The underlying issue[3] has been fixed and propagated to jdk9 and this test can be re-enabled. 8157175 GetNanoTimeAdjustment.java fails with excessive adjustment error 8158128 regression: java/time/test/java/time/TestClo

JVM (1.8.0_91) crashes in Windows native code

2016-06-24 Thread Vinay Purohit
Hello, I'm not sure if this is the right forum for posting an issue we are experiencing with JRE 1.8.0_92 (other versions may be susceptible as well, not sure). The JVM crashes in the Windows native code and does not generate the usual stack trace you see with run-time exceptions, but does gene

Re: RFR 9 7131356 : (props) "No Java runtime present, requesting install" when creating VM from JNI [macosx]

2016-06-24 Thread Alex Strange
> On Jun 20, 2016, at 3:44 PM, Brent Christian > wrote: > > > Alex - thanks for your response. More below... > > On 6/13/16 4:51 PM, Alex Strange wrote: >>> 2. In "setupMacOSXLocale" we simply drop the call to >>> "JRSSetDefaultLocalization" as it appears to be a NOP. According to >>> Apple,

Re: [jdk9] RFR: 8159822: Non-synchronized access to shared members of com.sun.jndi.ldap.pool.Pool

2016-06-24 Thread Ivan Gerasimov
Hi Aleksey! I've double-checked the Pool class and found no other code that has to be additionally synchronized. Please note that the method expungeStaleConnections() is thread-safe and can be called from outside the synchronized blocks. The method Pool.getConnections(Object) accesses the `map`

[jdk9] RFR: 8160264 : Reuse Latin1/UTF16 compare routines

2016-06-24 Thread Ivan Gerasimov
Hello everyone! StringLatin1 and StringUTF16 helper classes have a few very symmetric methods for comparing. If we reuse them, it will save us a few bytes of generated bytecode. Would you please help review this? BUGURL: https://bugs.openjdk.java.net/browse/JDK-8160264 WEBREV: http://cr.openj

Re: JVM (1.8.0_91) crashes in Windows native code

2016-06-24 Thread Alex Kashchenko
Hi Vinay, On 06/23/2016 06:56 PM, Vinay Purohit wrote: Hello, I'm not sure if this is the right forum for posting an issue we are experiencing with JRE 1.8.0_92. The JVM crashes in the Windows native code and generates a log (see attachment, hs_err_pid15724.log), but not the usual stack-tr

Re: RFR 8054213: Class name repeated in output of Type.toString()

2016-06-24 Thread Svetlana Nikandrova
Hello, let me try again with updated version of webrev: Webrev: http://cr.openjdk.java.net/~snikandrova/8054213/webrev.01/ Issue: https://bugs.openjdk.java.net/browse/JDK-8054213 Many thanks goes to Sergey Ustimenko for his valuabl

Re: RFR: 8150173: JAXBContext.newInstance causes PrivilegedActionException when createContext's declared in absract class extended by discovered JAXB implementation

2016-06-24 Thread Daniel Fuchs
Thanks Georgiy! On 24/06/16 11:25, Georgiy Rakov wrote: After some thoughts I agree, redefining createContext would just check that reflection deals with methods overriding properly. BTW if a factory is an instance of JAXBContextFactory it would seem more natural to invoke createContext by firs

Re: RFR: 8150173: JAXBContext.newInstance causes PrivilegedActionException when createContext's declared in absract class extended by discovered JAXB implementation

2016-06-24 Thread Georgiy Rakov
Hi Daniel, please see my replies embedded below. On 23.06.2016 19:07, Daniel Fuchs wrote: Hi, Here is the new webrev: http://cr.openjdk.java.net/~dfuchs/webrev_8150173/webrev.03/ On 23/06/16 14:55, Daniel Fuchs wrote: if I understand correctly JAXBContextWithSubclassedFactory is supposed to