Re: RFR 8054213: Class name repeated in output of Type.toString()

Hi Svetlana, Looks okay. I approve pushing the fix with the following change to the test: have the expected output align with the given output. The webrev shows 63 "FirstInnerClassGeneric$SecondInnerClassGeneric") 64 public FirstInnerClassGeneric.SecondInnerClassGeneric

Re: RFR: 8140723: Remove source code conditionalized on JAVASE_EMBEDDED

Thanks for the review Paul! David On 14/07/2016 11:12 PM, Paul Sandoz wrote: On 14 Jul 2016, at 06:25, David Holmes wrote: The bug report for this is confidential but quite simply all of the little tweaks and knobs we added to the open build and source files to

Re: RFR: 8140723: Remove source code conditionalized on JAVASE_EMBEDDED

Thanks for the review Alan! David On 15/07/2016 6:52 AM, Alan Bateman wrote: On 14/07/2016 05:25, David Holmes wrote: The bug report for this is confidential but quite simply all of the little tweaks and knobs we added to the open build and source files to support the Java SE Embedded

Fwd: RFR 8161426: Test java/util/zip/InflaterInputStream/TestAvailable.java fails on open-only linux

HI Sherman, Approved. I should have caught that myself yesterday: I’ve made that same mistake in the past. Brian On Jul 14, 2016, at 2:45 PM, Xueming Shen wrote: > Would you please help review the change for JDK-8161426. The test case > I pushed back yesterday fails

RFR 8161426: Test java/util/zip/InflaterInputStream/TestAvailable.java fails on open-only linux

Brian, Would you please help review the change for JDK-8161426. The test case I pushed back yesterday fails in corner case when the Random.nextInt(n) returns 0, in which we have a 0-length data/src byte[]. issue: https://bugs.openjdk.java.net/browse/JDK-8161426 webrev:

Re: RFR: 9: 8161011: Mark test/java/rmi/activation/ActivationGroup/downloadActivationGroup/DownloadActivationGroup.java as itnermittent

+1, fine to mark as intermittent. Roger On 7/13/2016 5:35 PM, Rajan Halade wrote: Ping I extended this to include two more tests to be marked as intermittent. Webrev: http://cr.openjdk.java.net/~rhalade/8161011/webrev.00/ Thanks, Rajan On 7/7/16 3:59 PM, Rajan Halade wrote: This test

Re: Create java.util.stream.Stream from Iterator / Enumeration

Hi Paul, On 2016-07-13 10:28, Paul Sandoz wrote: I see some comments already by Stuart and Alan, and concur with Alan about working closely with jigsaw-dev. Focusing on the public methods is good and then it will come down to naming them appropriately. Given that sub-classes can override the

Re: JDK 9 RFR of JDK-8161347: Mark java/lang/ProcessBuilder/Zombies.java as intermittently failing

+1 to mark as intermittent. Thanks, Roger On 7/14/2016 1:55 AM, Amy Lu wrote: java/lang/ProcessBuilder/Zombies.java This test is known to fail intermittently (JDK-8160151), this patch is to mark the test accordingly with keyword 'intermittent'. (Note that this test has been demoted to

Re: RFR(S): 8160564: TEST: Add a test to check the implementation of VersionProps.versionNumbers()

On Thu, Jul 14, 2016 at 4:04 PM, Mandy Chung wrote: > >> On Jul 12, 2016, at 9:54 PM, Volker Simonis wrote: >> >> Please find the new webrev at: >> >> http://cr.openjdk.java.net/~simonis/webrevs/2016/8160564.v2/ >> > > Looks good. > > Nit: maybe

[9] RFR: 8159214: jlink --include-locales problems

Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8159214 The fix is located at: http://cr.openjdk.java.net/~naoto/8159214/webrev.04/ Naoto

Re: Review Request: JDK-8157464: StackWalker.getCallerClass() should not filter out non-invoker frames

Hi Daniel, Now I see what you mean. Your suggestion would include hidden frames for non @CS frames that should be filtered from StackWalker::getCallerClass. This would require the support I described earlier that it needs to return MemberName[] and also MemberName::isHidden support

Re: RFR (JAXP): 8148350: Element.setAttributeNS() empty namespace does not throw exception

Hi Lance, Joe, Thanks for your reviews and comments. I will work on CCC and javadoc/Lic header modifications. Will return back to you when it is done. Best Regards, Aleksej On 12/07/16 23:53, huizhe wang wrote: On 7/12/2016 1:35 PM, Lance Andersen wrote: Looks OK also. Joe given this is

Re: Review Request: JDK-8157464: StackWalker.getCallerClass() should not filter out non-invoker frames

On 13/07/16 23:35, Mandy Chung wrote: I considered that and it’s possible and that would simplify the VM logic would be a good thing (do the filtering in the library as much as possible). This would need to fill an array of MemberName rather than Class object. MemberName would need to