Re: RFR 8156073 : 2-slot LiveStackFrame locals (long and double) are incorrect

Hi Brent, > On Aug 17, 2016, at 1:05 PM, Brent Christian > wrote: > > Hi, > > Please review this StackWalker fix in hotspot for 8156073, "2-slot > LiveStackFrame locals (long and double) are incorrect" > > Bug: https://bugs.openjdk.java.net/browse/JDK-8156073 > Webrev: http://cr.openjdk.jav

RFR: 8148859 Fix module dependences for java/time tests

Hi. Please review a quick fix for the java/time test module dependencies. http://cr.openjdk.java.net/~shurailine/8148859/webrev.00/ It is using new syntax added in JTReg, which allows to only build certain classes from a test library for TestNG tests: https://bugs.openjdk.java.net/browse/CODETOO

Re: JDK 9 RFR of JDK-8164524: Correct inconsistencies in floating-point abs spec

Pushed with suggested wording change; thanks, -Joe On 8/22/2016 3:24 PM, Brian Burkhalter wrote: I think that sounds good. Brian On Aug 22, 2016, at 2:44 PM, Hans Boehm > wrote: The new version seems less clear to me. Could it be misread as only applying if the va

8164585: JarFile::isMultiRelease does not return true in all cases where it should return true

Hi, Please review this simple change to JarFile issue: https://bugs.openjdk.java.net/browse/JDK-8164585 webrev: http://cr.openjdk.java.net/~sdrach/8164585/webrev.00/ Thanks, Steve

Re: JDK 9 RFR of JDK-8164524: Correct inconsistencies in floating-point abs spec

I think that sounds good. Brian On Aug 22, 2016, at 2:44 PM, Hans Boehm wrote: > The new version seems less clear to me. Could it be misread as only applying > if the value is positive? s/of/indicating a/ ? > > > On Mon, Aug 22, 2016 at 1:47 PM, Joseph D. Darcy wrote: > Hello, > > I plan t

Re: JDK 9 RFR of JDK-8164524: Correct inconsistencies in floating-point abs spec

The new version seems less clear to me. Could it be misread as only applying if the value is positive? s/of/indicating a/ ? On Mon, Aug 22, 2016 at 1:47 PM, Joseph D. Darcy wrote: > Hello, > > I plan to push with a slightly different wording. Rather than > > ... but with a guaranteed positi

Re: JDK 9 RFR of JDK-8164524: Correct inconsistencies in floating-point abs spec

Hello, I plan to push with a slightly different wording. Rather than ... but with a guaranteed positive sign bit: using ...but with a guaranteed zero sign bit of a positive value: I think the latter is clearer. Thanks, -Joe On 8/22/2016 11:41 AM, Brian Burkhalter wrote: Hi Joe, T

Re: JDK 9 RFR of JDK-8164524: Correct inconsistencies in floating-point abs spec

Hi Joe, This doc-only patch appears reasonable to me. Approved. Brian On Aug 20, 2016, at 11:55 AM, joe darcy wrote: > Please review the doc-only patch below to address > >JDK-8164524: Correct inconsistencies in floating-point abs spec > > In brief, Martin noted in JDK-8164199 that a clo

Re: [jdk9] RFR: 8164366: ZoneOffset.ofHoursMinutesSeconds() does not reject invalid input

Looks fine Ivan. Reviewed. Regards, Sean. On 19/08/16 15:59, Ivan Gerasimov wrote: On 19.08.2016 17:32, Stephen Colebourne wrote: I'm less comfortable with the compareTo change because it may make it slower and that may have knock on effects. I think a comment saying that both are bounded woul

Re: RFR: JDK-8164547: Make java.lang.reflect.ClassLoaderValue public for internal use

Hi Aleksey, Alan, Thanks for reviewing. Pushed. Regards, Peter On 08/22/2016 12:27 PM, Alan Bateman wrote: On 22/08/2016 11:15, Peter Levart wrote: Hi, Several potential internal usages of currently package-private java.lang.reflect.ClassLoaderValue have been identified. Here is a propos

Re: RFR: JDK-8164547: Make java.lang.reflect.ClassLoaderValue public for internal use

On 22/08/2016 11:15, Peter Levart wrote: Hi, Several potential internal usages of currently package-private java.lang.reflect.ClassLoaderValue have been identified. Here is a proposal to move it to jdk.internal.loader package and make it public... Task: https://bugs.openjdk.java.net/browse

Re: RFR: JDK-8164547: Make java.lang.reflect.ClassLoaderValue public for internal use

On 08/22/2016 01:15 PM, Peter Levart wrote: > Webrev: > http://cr.openjdk.java.net/~plevart/jdk9-dev/ClassLoaderValue.public/webrev.01/ Looks good to me. AFAIU, making the classes public under the non-exported jdk.internal.loader package is fine. Thanks, -Aleksey

RFR: JDK-8164547: Make java.lang.reflect.ClassLoaderValue public for internal use

Hi, Several potential internal usages of currently package-private java.lang.reflect.ClassLoaderValue have been identified. Here is a proposal to move it to jdk.internal.loader package and make it public... Task: https://bugs.openjdk.java.net/browse/JDK-8164547 Webrev: http://cr.openjdk.java

Re: RFR: 8164525: Re-examine zero form link time pre-generation

Reviewed. Best regards, Vladimir Ivanov On 8/21/16 12:59 PM, Claes Redestad wrote: Hi, the previous attempt to pre-generate zero LambdaForms[1] failed due to the current implementation surprisingly emitting placeholder constants to link to the associated identity function (which we can't prope