Re: RFR: JDK-8161360, , Deprecated vfork() should not be used on Solaris

Does an attempt to use vfork on Solaris result in something reasonable like UnsupportedOperationException? On Wed, Aug 31, 2016 at 4:55 AM, Alan Burlison wrote: > vfork(2) is deprecated on Solaris and using it generates compiler > warnings. When compiled with warnings-as-errors, this results in

Re: RFR 8164814: Deprecate Atomic*.weakCompareAndSet and defer to Atomic*.weakCompareAndSetPlain

I'll try not to complain about this again. It was pointed out to me that users of off-heap VarHandles will usually want the Plain variety. java.util.concurrent will hopefully not be the only users!

Re: RFR: 8150145: javax/xml/jaxp/unittest/common/TransformationWarningsTest.java and ValidationWarningsTest.java failed intermittently without any error message

Hi Aleksej, Yes, the change looks good with the System Property and StreamSource. As we discussed, apparently the processor won't issue warnings in other cases (with SAXSource). Thanks for being patient with me, going back and forth with test runs. Cheers, Joe On 8/31/16, 2:58 PM, Aleks Efi

Re: RFR: 8081388: JNI exception pending in jdk/src/windows/bin/java_md.c

Looks good, thanks Henry for fixing this. Kumar Hi, Please review a trivial fix for 8081388, in a nutshell, - Return NULL from NewPlatformStringArray if an exception occurred - All other places call this function already handled return value NULL - Launcher handles exception in JavaMain, rep

Re: RFR: 8150145: javax/xml/jaxp/unittest/common/TransformationWarningsTest.java and ValidationWarningsTest.java failed intermittently without any error message

On 31/08/16 23:55, Joe Wang wrote: On 8/31/16, 12:08 PM, Aleks Efimov wrote: Joe, (answers in-lined) On 31/08/16 21:39, Joe Wang wrote: On 8/31/16, 10:51 AM, Aleks Efimov wrote: Hi Joe, Thank you for reviewing the changes. I found one more inconsistency with these tests: The TestSAX

Re: RFR: 8162431: CatalogUriResolver with circular/self referencing catalog file is not throwing CatalogException as expected.

Thanks Lance! Joe On 8/31/16, 1:14 PM, Lance Andersen wrote: Looks OK Joe Best Lance On Aug 29, 2016, at 3:18 PM, Joe Wang > wrote: Hi, Please review a patch that fixes an issue where circular references were not caught if catalogs are pre-loaded. Note that t

Re: RFR: 8150145: javax/xml/jaxp/unittest/common/TransformationWarningsTest.java and ValidationWarningsTest.java failed intermittently without any error message

On 8/31/16, 12:08 PM, Aleks Efimov wrote: Joe, (answers in-lined) On 31/08/16 21:39, Joe Wang wrote: On 8/31/16, 10:51 AM, Aleks Efimov wrote: Hi Joe, Thank you for reviewing the changes. I found one more inconsistency with these tests: The TestSAXDriver class is not compiled by defa

Re: RFR (JAXP) 8161454: Fails to Load external Java method from inside of a XSL stylesheet if SecurityManager is present

Thanks Aleksej! -Joe On 8/31/16, 11:26 AM, Aleks Efimov wrote: Hi Joe, The changes looks nice (I'm not a reviewer) Best Regards, Aleksej On 31/08/16 19:47, Joe Wang wrote: Hi, Please review a fix to the XSLTFunctionsTest. After enabling SecurityManager, the test now needs to set the ex

Re: RFR: 8162431: CatalogUriResolver with circular/self referencing catalog file is not throwing CatalogException as expected.

Looks OK Joe Best Lance > On Aug 29, 2016, at 3:18 PM, Joe Wang wrote: > > Hi, > > Please review a patch that fixes an issue where circular references were not > caught if catalogs are pre-loaded. Note that to trigger the issue (circular > references), the Catalog must be instructed to load a

RFR: 8081388: JNI exception pending in jdk/src/windows/bin/java_md.c

Hi, Please review a trivial fix for 8081388, in a nutshell, - Return NULL from NewPlatformStringArray if an exception occurred - All other places call this function already handled return value NULL - Launcher handles exception in JavaMain, report error and exit. Cheers, Henry diff --git a/src/

Re: RFR: 8150145: javax/xml/jaxp/unittest/common/TransformationWarningsTest.java and ValidationWarningsTest.java failed intermittently without any error message

Joe, (answers in-lined) On 31/08/16 21:39, Joe Wang wrote: On 8/31/16, 10:51 AM, Aleks Efimov wrote: Hi Joe, Thank you for reviewing the changes. I found one more inconsistency with these tests: The TestSAXDriver class is not compiled by default now and because of that the default SAX

Re: RFR: 8150145: javax/xml/jaxp/unittest/common/TransformationWarningsTest.java and ValidationWarningsTest.java failed intermittently without any error message

On 8/31/16, 10:51 AM, Aleks Efimov wrote: Hi Joe, Thank you for reviewing the changes. I found one more inconsistency with these tests: The TestSAXDriver class is not compiled by default now and because of that the default SAX driver were used and the original issue was not reproduced pro

Re: RFR: 8153654: Update jdeps to be multi-release jar aware

> On Aug 30, 2016, at 7:58 PM, Steve Drach wrote: > >> >> This looks quite good. JDK-8163798 and JDK-8164665 will define public APIs >> to get the versioned entries and real name which I think are useful for >> tools. It’s fine to proceed with this change and update jdeps to use the >> pub

Re: RFR (JAXP) 8161454: Fails to Load external Java method from inside of a XSL stylesheet if SecurityManager is present

Hi Joe, The changes looks nice (I'm not a reviewer) Best Regards, Aleksej On 31/08/16 19:47, Joe Wang wrote: Hi, Please review a fix to the XSLTFunctionsTest. After enabling SecurityManager, the test now needs to set the extension ClassLoader for the extension class. JBS: https://bugs.

Re: RFR 8164814: Deprecate Atomic*.weakCompareAndSet and defer to Atomic*.weakCompareAndSetPlain

> On 30 Aug 2016, at 16:21, Doug Lea wrote: > > On 08/30/2016 06:52 PM, Paul Sandoz wrote: > >> I still think it’s kind of sneaky to substitute, especially because of >> propagation to wrapping classes such as AtomicDoubleArray. >> >> Doug, not sure you care enough to have an opinion :-) but i

Re: RFR: 8150145: javax/xml/jaxp/unittest/common/TransformationWarningsTest.java and ValidationWarningsTest.java failed intermittently without any error message

Hi Joe, Thank you for reviewing the changes. I found one more inconsistency with these tests: The TestSAXDriver class is not compiled by default now and because of that the default SAX driver were used and the original issue was not reproduced properly. New webrev can be found here: http:/

RFR (JAXP) 8161454: Fails to Load external Java method from inside of a XSL stylesheet if SecurityManager is present

Hi, Please review a fix to the XSLTFunctionsTest. After enabling SecurityManager, the test now needs to set the extension ClassLoader for the extension class. JBS: https://bugs.openjdk.java.net/browse/JDK-8161454 webrev: http://cr.openjdk.java.net/~joehw/jdk9/8161454/webrev/ Thanks, Joe

Re: RFR: 8150145: javax/xml/jaxp/unittest/common/TransformationWarningsTest.java and ValidationWarningsTest.java failed intermittently without any error message

Hi Aleksej, It's good to put the tests back online. Thanks for the diligent work! I believe the change that made the tests run in othervm could have fixed the intermittent issue. But adding debugging code can always be helpful in case of failures. Thanks, Joe On 8/30/16, 12:01 PM, Aleks Efi

Re: RFR: 8153654: Update jdeps to be multi-release jar aware

> On 30 Aug 2016, at 19:58, Steve Drach wrote: > > new webrev addressing issues below: > http://cr.openjdk.java.net/~sdrach/8153654/webrev.09/ > >

Re: RFR 9: JEP 290: Filter Incoming Serialization Data

Hi Peter, Since the filter is passed information about each object created, a stateful filter can tabulate the cumulative size itself if that is a concern. Also, a stateless filter can be constructed to check a combination of the total number of objects, depth, array sizes, and stream size. S

Re: 8150145: javax/xml/jaxp/unittest/common/TransformationWarningsTest.java and ValidationWarningsTest.java failed intermittently without any error message

Hi Christoph, Thanks for the review and suggestion. I've converted 'shutdown' and 'shutdownNow' calls to use method references. Best Regards, Aleksej On 31/08/16 11:34, Langer, Christoph wrote: Hi Aleks, looks nice to me. You could maybe use the method reference syntax in 2 places: ---

Re: RFR: 8161016: Strange behavior of URLConnection with proxy

On 12/08/16 20:56, Ramanand Patil wrote: Hi Aleksey, Thank you for your review. In the exception handler block: when last proxy fails, it was using a DIRECT connection, but in the fixed version it was just a re-try once with the last proxy before failing the connection. Considering your point

RFR: JDK-8161360,,Deprecated vfork() should not be used on Solaris

vfork(2) is deprecated on Solaris and using it generates compiler warnings. When compiled with warnings-as-errors, this results in compilation failures. Bug:https://bugs.openjdk.java.net/browse/JDK-8161360 Webrev: http://cr.openjdk.java.net/~alanbur/JDK-8161360 Thanks, -- Alan Burlison --

Re: RFR: 8164858: Enable build-time use of java.lang.invoke resolve tracing

Reviewed. Best regards, Vladimir Ivanov On 8/29/16 9:10 PM, Claes Redestad wrote: Hi, this patch adds generation of a trace of resolved java.lang.invoke classes when generating the classlist, and uses this trace as input when linking the runtime images. Bug: https://bugs.openjdk.java.net/brow

Re: RFR: 8164858: Enable build-time use of java.lang.invoke resolve tracing

Thanks! Can I get a review of the plugin changes? Mostly ensuring we generate methods in a deterministic order (and weed out duplicates early). /Claes On 2016-08-30 10:20, Erik Joelsson wrote: Build changes look good. /Erik On 2016-08-29 20:10, Claes Redestad wrote: Hi, this patch adds ge

RFR: 8160951, 8160958: "Test javax/xml/bind/marshal/8134111/UnmarshalTest.java should be added into :needs_jre group", "Test java/net/SetFactoryPermission/SetFactoryPermission.java should be added int

Hi all, Please review this trivial fix which addresses the mentioned 2 bugs. Bugs: 1. https://bugs.openjdk.java.net/browse/JDK-8160951 2. https://bugs.openjdk.java.net/browse/JDK-8160958 Webrev: http://cr.openjdk.java.net/~rpatil/8160951%2b8160958/webrev.00/ Only test/TEST.groups is modified to

RE: 8150145: javax/xml/jaxp/unittest/common/TransformationWarningsTest.java and ValidationWarningsTest.java failed intermittently without any error message

Hi Aleks, looks nice to me. You could maybe use the method reference syntax in 2 places: --- a/test/javax/xml/jaxp/unittest/common/WarningsTestBase.java Wed Aug 31 09:17:55 2016 +0200 +++ b/test/javax/xml/jaxp/unittest/common/WarningsTestBase.java Wed Aug 31 10:32:05 2016 +0200 @@ -68,11 +68,1