Re: RFR: JDK-8134373: explore potential uses of convenience factories within the JDK

Hi Jonathan, src/java.base/share/classes/java/util/ResourceBundle.java 2490 public static class Control { 2491 /** 2492 * The default format List, which contains the strings 2493 * "java.class" and "java.properties", in 2494 * this order. This List is {@link

Re: RFR 8165793 : Provide an API to query if a ClassLoader is parallel capable

Hi Brent, On 10/11/2016 12:44 AM, Brent Christian wrote: On 10/10/16 2:30 PM, Mandy Chung wrote: The patch looks fine. It would be good to add @see #registerAsParallelCapable in this new method. Also the first “parallel capable” occurrance in the class spec and the registerAsParallelCapable

RFR: Release note for 8164705: Remove pathname canonicalization from FilePermission

https://bugs.openjdk.java.net/browse/JDK-8165836 I added more words, please take another look. Thanks Max On 9/13/2016 2:13, Brian Burkhalter wrote: Only picky comments: not sure but maybe change: 1) vice versa -> and vice versa 2) When it’s set to true -> When true 3) just like before -> as

Re: RFR 8165793 : Provide an API to query if a ClassLoader is parallel capable

On 10/10/16 3:51 PM, Mandy Chung wrote: Do you mind fixing @return in the registerAsParallelCapable method with {@code true} amd {@code false} since you are in this method. No need for a new webrev. Sure, no problem. Thanks, -Brent

Re: RFR 8165793 : Provide an API to query if a ClassLoader is parallel capable

> On Oct 10, 2016, at 3:44 PM, Brent Christian > wrote: > > Thanks for having a look, and for the suggestions. I also added an @see > #isParallelCapable in registerAsParallelCapable(). > > Webrev updated in place: > http://cr.openjdk.java.net/~bchristi/8165793/webrev.00/ > +1 Do you mind

Re: RFR 8165793 : Provide an API to query if a ClassLoader is parallel capable

On 10/10/16 2:30 PM, Mandy Chung wrote: The patch looks fine. It would be good to add @see #registerAsParallelCapable in this new method. Also the first “parallel capable” occurrance in the class spec and the registerAsParallelCapable method spec to @linkplain #isParallelCapable. Thanks for

Re: RFR: 8166460: jdk/internal/util/jar/TestVersionedStream gets Assertion error

> On 10 Oct 2016, at 14:50, Steve Drach wrote: > > As a consequence of some conversations about this test, I’ve removed the part > that specifically depended on the order of the entries and now just verify > that the order of the versioned entries is the same relative order as all the > entri

Re: RFR: 8166460: jdk/internal/util/jar/TestVersionedStream gets Assertion error

As a consequence of some conversations about this test, I’ve removed the part that specifically depended on the order of the entries and now just verify that the order of the versioned entries is the same relative order as all the entries in the jar file. The updated changeset is http://cr.op

Re: RFR 8165793 : Provide an API to query if a ClassLoader is parallel capable

> On Oct 10, 2016, at 1:36 PM, Brent Christian > wrote: > > Hi, > > Please review my fix for 8165793. This follows the discussion here: > http://mail.openjdk.java.net/pipermail/jigsaw-dev/2016-September/009328.html > > The proposal is to add a new public method on ClassLoader: > > /** > * R

RFR 8165793 : Provide an API to query if a ClassLoader is parallel capable

Hi, Please review my fix for 8165793. This follows the discussion here: http://mail.openjdk.java.net/pipermail/jigsaw-dev/2016-September/009328.html The proposal is to add a new public method on ClassLoader: /** * Returns {@code true} if this class loader is * {@linkplain #registerAsParallel

Re: RFR: JDK-8134373: explore potential uses of convenience factories within the JDK

OK, I'll sponsor this. I need to run this through our internal testing system before pushing it. I'll follow up here with results. s'marks On 10/10/16 1:34 AM, Jonathan Bluett-Duncan wrote: Hi all, Would you kindly review the latest webrev now? http://cr.openjdk.java.net/~reinhapa/reviews/8

Re: RFR: 8062389,8029459,8061950: Class.getMethod() is inconsistent with Class.getMethods() results + more

Does core reflection have an active maintainer? Or is Peter that maintainer? On Mon, Oct 10, 2016 at 1:04 AM, Peter Levart wrote: > Just a note that this is still ready to be reviewed. > > I was also told that JCK tests pass with the patch applied. > > Regards, Peter > > > On 10/04/2016 03:40 P

Re: RFR(s): 8167437: Fix module dependencies for tests that use internal API (java/lang)

You are right. I'll rollback the change for the file. 10.10.16 18:05, Alan Bateman wrote: sun.reflect.generics.parser is in java.base, I don't see anything using jdk.unsupported/sun.reflect. You can check this quickly by running the test without your change. -Alan -- With best regards, Ser

Re: RFR(s): 8167437: Fix module dependencies for tests that use internal API (java/lang)

On 10/10/2016 15:55, Sergei Kovalev wrote: Hi Alan, sun.reflect.* ./jdk9_latest/bin/jmod describe ./jdk9_latest/jmods/jdk.unsupported.jmod jdk.unsupported@9-ea requires mandated java.base exports com.sun.nio.file exports sun.misc * exports sun.reflect* operating-system-name Linux o

Re: RFR(s): 8167437: Fix module dependencies for tests that use internal API (java/lang)

Hi Alan, sun.reflect.* ./jdk9_latest/bin/jmod describe ./jdk9_latest/jmods/jdk.unsupported.jmod jdk.unsupported@9-ea requires mandated java.base exports com.sun.nio.file exports sun.misc * exports sun.reflect* operating-system-name Linux operating-system-architecture amd64 operatin

Re: RFR(s): 8167437: Fix module dependencies for tests that use internal API (java/lang)

On 10/10/2016 14:55, Sergei Kovalev wrote: Hello team, Could you please review fix for: BugID: https://bugs.openjdk.java.net/browse/JDK-8167437 WebRev: http://cr.openjdk.java.net/~skovalev/8167437/webrev.00/ Issue: two tests from java/lang uses internal API but have no declaration in jtreg h

RFR(s): 8167437: Fix module dependencies for tests that use internal API (java/lang)

Hello team, Could you please review fix for: BugID: https://bugs.openjdk.java.net/browse/JDK-8167437 WebRev: http://cr.openjdk.java.net/~skovalev/8167437/webrev.00/ Issue: two tests from java/lang uses internal API but have no declaration in jtreg header. Solution: add missed declaration. --

Re: [9] RFR of JDK-8085192: java/rmi/activation/Activatable tests fail intermittently due to "Port already in use"

Roger, I addressed all, or most, of your comments in the following webrev. 1) Refactored out the use of sun.nio.ch in the test library, so that a reduced number of tests need their @modules tag updated. ( @modules support with test library usage it a pain ) 2) Use Boolean.getBoolean

using jshell in executable UNIX scripts

Hi, I don't know if this is the right list to discuss this, so please direct me to a more suitable place if there is one. "jshell" command is a very nice interactive Java shell, but it could also be used for scripting. An executable script in any major UNIX OS is a textual file with executab

Re: RFR: JDK-8134373: explore potential uses of convenience factories within the JDK

Hi all, Would you kindly review the latest webrev now? http://cr.openjdk.java.net/~reinhapa/reviews/8134373/webrev.02 Thanks in advance. Kind regards, Jonathan On 7 October 2016 at 21:59, Patrick Reinhart wrote: > Here is the latest webrev: > > http://cr.openjdk.java.net/~reinhapa/reviews/81

Re: RFR: 8062389,8029459,8061950: Class.getMethod() is inconsistent with Class.getMethods() results + more

Just a note that this is still ready to be reviewed. I was also told that JCK tests pass with the patch applied. Regards, Peter On 10/04/2016 03:40 PM, Peter Levart wrote: Hi, I have a fix for conformance (P2) bug (8062389 ) that also fixes a