JDK-Review Request: JDK-8169606 jdeps --list-reduced-deps should not show java.base as all modules require it

Daniel, This is an improved version of what you reviewed earlier. jdeps --list-reduced-deps will show java.base only when it’s the only module it depends on. http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8169606/webrev.00 thanks Mandy

Re: RFR 8169435 : ClassLoader.isParallelCapable is final and conflicting method may get VerifyError

While this could be made as a static method, there are cases that an instance method would be preferred and same compatibility would arise. For example, ClassLoader::getName is non-final instance method as it stands and I’d be reluctant to make it a static method taking a ClassLoader instance.

Re: Review request: JDK-8168386: Fix jdeps verbose options

> On Nov 11, 2016, at 4:21 AM, Daniel Fuchs wrote: > > Hi Mandy, > > This looks good to me. Thanks. > However, if I'm not mistaken, jdeps will now no longer > list java.base as a dependency, unless the dependency > is on a jdk internal API. > That is only when

Re: RFR 8158880: java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale

Hi Bhanu, Nadeesh, As to which locale to use, I suggest using US English (Locale.US), since that is the one in java.base module. Using Locale.UK could cause unexpected fallback to Locale.US if jdk.localedata module is not available. Naoto On 11/11/16 12:39 AM, nadeesh tv wrote: Hi Bhanu,

Re: RFR 8169435 : ClassLoader.isParallelCapable is final and conflicting method may get VerifyError

Hi David, you can not override a static method :) but there is still a corner case, you can have a conflict when you have a method reference over an instance method and you introduce a static method that have the same functional signature. Given that i prefer to have a compile time error than a

Re: RFR 8169435 : ClassLoader.isParallelCapable is final and conflicting method may get VerifyError

+1 Karen > On Nov 10, 2016, at 5:56 PM, David Holmes wrote: > > > > On 11/11/2016 8:46 AM, Mandy Chung wrote: >> >>> On Nov 10, 2016, at 2:28 PM, Peter Levart wrote: >>> >>> On 11/10/2016 05:59 PM, Alan Bateman wrote: On

Re: [9] RFR (XS): 8169000: Define reference reachability more precisely in java.lang.ref package

Hi Zoltan, On 11/11/2016 10:25 AM, Zoltán Majó wrote: Hi, please review the fix for 8169000: https://bugs.openjdk.java.net/browse/JDK-8169000 http://cr.openjdk.java.net/~zmajo/8169000/webrev.00/ The bug was filed because different behavior of interpreted and compiled code in HotSpot was

Re: RFR 8169435 : ClassLoader.isParallelCapable is final and conflicting method may get VerifyError

On 11/11/2016 05:07 AM, Alan Bateman wrote: On 11/11/2016 10:46, Vladimir Ivanov wrote: Alan, I've looked through the current thread and also review thread [1] for original change (8165793), but haven't found any discussion why making it static (instead of instance final) is undesirable.

Re: Review request: JDK-8168386: Fix jdeps verbose options

Hi Mandy, This looks good to me. However, if I'm not mistaken, jdeps will now no longer list java.base as a dependency, unless the dependency is on a jdk internal API. This might be worthy of some mention in release notes - if any tools are relying on jdeps output. best regards, -- daniel On

Re: RFR 8169435 : ClassLoader.isParallelCapable is final and conflicting method may get VerifyError

On 11/11/2016 10:46, Vladimir Ivanov wrote: Alan, I've looked through the current thread and also review thread [1] for original change (8165793), but haven't found any discussion why making it static (instead of instance final) is undesirable. Can you shed some light on it? Is it mainly

Re: RFR 8169435 : ClassLoader.isParallelCapable is final and conflicting method may get VerifyError

Alan, I've looked through the current thread and also review thread [1] for original change (8165793), but haven't found any discussion why making it static (instead of instance final) is undesirable. Can you shed some light on it? Is it mainly usability concern (loader.isParallelCapable()

Re: RFR 8169435 : ClassLoader.isParallelCapable is final and conflicting method may get VerifyError

On 10/11/2016 22:46, Mandy Chung wrote: : Since there is already a @CallerSensitive protected static method called "registerAsParallelCapable" for subclasses to call from their blocks, the query could be called: isRegisteredAsParallelCapable() ? I doubt this name is already taken by any

[9] RFR (XS): 8169000: Define reference reachability more precisely in java.lang.ref package

Hi, please review the fix for 8169000: https://bugs.openjdk.java.net/browse/JDK-8169000 http://cr.openjdk.java.net/~zmajo/8169000/webrev.00/ The bug was filed because different behavior of interpreted and compiled code in HotSpot was observed (different behavior with respect to phantom

Re: RFR 8158880: java/time/tck/java/time/format/TCKDateTimeFormatterBuilder.java fail with zh_CN locale

Hi Bhanu, I think adding Locale to the formatter will be better For eg: DateTimeFormatter f = builder.parseLenient().appendValue(HOUR_OF_DAY).appendValue(MINUTE_OF_HOUR, 2).appendLiteral('9').toFormatter(Locale.UK); Since other test cases use Locale.UK may be here also you can use UK