[JAXP] RFR: 8173260: CatalogManager.catalogResolver should not fail when non-existing URI is passed to it

Hi, Please find below a fix for 8173260: CatalogManager.catalogResolver should not fail when non-existing URI is passed to it https://bugs.openjdk.java.net/browse/JDK-8173260 The specification for CatalogManager.catalogResolver and CatalogManager.catalog says that invalid catalog entri

Re: [JAXP] RFR: 8173260: CatalogManager.catalogResolver should not fail when non-existing URI is passed to it

On 26/01/2017 11:29, Daniel Fuchs wrote: : This fix proposes to simply remove the special case that the implementation makes for file or jar URLs. test/javax/xml/jaxp/unittest/catalog/CatalogFileInputTest.java is updated to reflect this change. http://cr.openjdk.java.net/~dfuchs/webrev_817326

Re: RFR: 8173372 Add tests for multi-release module jar API validator

Thank you > On 25 Jan 2017, at 22:19, Paul Sandoz wrote: > > >> On 25 Jan 2017, at 10:54, Andrey Nazarov wrote: >> >> Hi, >> >> I’ve added tests to check what MR Jar API validator handles changes in >> module-info.class >> >> Review: http://cr.openjdk.java.net/~anazarov/8173372/webrev.01/we

Re: [JAXP] RFR: 8173260: CatalogManager.catalogResolver should not fail when non-existing URI is passed to it

+1 > On Jan 26, 2017, at 6:29 AM, Daniel Fuchs wrote: > > Hi, > > Please find below a fix for > > 8173260: CatalogManager.catalogResolver should not fail > when non-existing URI is passed to it > https://bugs.openjdk.java.net/browse/JDK-8173260 > > The specification for CatalogManager.

RFR: Problemlist tools/jar/multiRelease/ApiValidatorTest.java

diff -r f5f50c8d8714 test/ProblemList.txt --- a/test/ProblemList.txt Thu Jan 26 14:32:41 2017 +0300 +++ b/test/ProblemList.txt Thu Jan 26 17:17:02 2017 +0300 @@ -264,6 +264,8 @@ tools/jlink/CustomPluginTest.java 8172864 generic-all +tools/jar/multiReleas

Re: RFR: Problemlist tools/jar/multiRelease/ApiValidatorTest.java

Hi Andrey, You need an issue for any change, even to the problem list. And can you provide an explanation? Recently you updated ApiValidatorTest.java 8173372 Add tests for multi-release module jar API validator Did something happen between you writing/running this test locally and pushing?

Re: RFR: Problemlist tools/jar/multiRelease/ApiValidatorTest.java

Hi, Paul It tested agains a bit outdated java version. It was ok. After push I've realised there is regression in product. https://bugs.openjdk.java.net/browse/JDK-8173396 Issue to problemlist https://bugs.openjdk.java.net/browse/JDK-8173395 —Andrey > On 26 Jan 2017, at 19:27, Paul Sandoz wrot

Re: RFR: Problemlist tools/jar/multiRelease/ApiValidatorTest.java

This commit leads to regression http://hg.openjdk.java.net/jdk9/dev/jdk/rev/dfba4c3eb1ac#l4.31 > On 26 Jan 2017, at 19:41, Andrey Nazarov wrote: > > Hi, Paul > > It tested agains a bit outdated java version. It was ok. > After push I've realised there is regression in product. > https://bugs.o

Re: RFR: Problemlist tools/jar/multiRelease/ApiValidatorTest.java

> On 26 Jan 2017, at 08:57, Andrey Nazarov wrote: > > This commit leads to regression > http://hg.openjdk.java.net/jdk9/dev/jdk/rev/dfba4c3eb1ac#l4.31 > Thanks for searching and finding this, Paul. >> On 26 Jan 2017, at 19:41,

Re: RFR: 8075617, 8075616 Create tests to check wsgen, schemagen work with multi-version jar

Hi Move tests to new place. Please review. http://cr.openjdk.java.net/~anazarov/8075617/webrev.01/webrev/ —Andrey > On 25 Jan 2017, at 19:04, Andrey Nazarov wrote: > > >> On 25 Jan 2017, at 19:00, Alan Bateman wrote: >> >> On 2

Re: RFR: 8172309: classpath wildcards code does not support --class-path

Hi Henry, Looks ok to me. Thanks for making this change. Kumar Hi, Please review the webrev[1], the fix is to ensure —class-path and —class-path= is processed correctly to expand wildcard. Changes are made in jdk repo. However, test case to verify the bug fix is in langtool repo. Cheers,

Re: RFR: 8172309: classpath wildcards code does not support --class-path

Henry, You've changed old test cases into new test cases, thereby eliminating the old cases, which is not so good. You should be adding new test cases, but changing old ones. -- Jon On 01/26/2017 02:31 PM, Kumar Srinivasan wrote: Hi Henry, Looks ok to me. Thanks for making this change.

RFR 8156073 : 2-slot LiveStackFrame locals (long and double) are incorrect (updated)

Hi, Please review my updated approach for fixing 8156073 ("2-slot LiveStackFrame locals (long and double) are incorrect") in the experimental portion of the StackWalker API, added in JDK 9. Bug: https://bugs.openjdk.java.net/browse/JDK-8156073 Webrev: http://cr.openjdk.java.net/~bchristi/81560

Re: RFR: 8172309: classpath wildcards code does not support --class-path

> On Jan 26, 2017, at 4:09 PM, Jonathan Gibbons > wrote: > > Henry, > > You've changed old test cases into new test cases, thereby eliminating the > old cases, which is not so good. > > You should be adding new test cases, but changing old ones. > I am not sure, I believe all wild-card case

RFR JDK-8173396:Error message issue with jar tool API validator

Hi, Please review the change for JDK-8173396. issue: https://bugs.openjdk.java.net/browse/JDK-8173396 webrev: http://cr.openjdk.java.net/~sherman/8173396/webrev The error message keys "error.versioned." were renamed to error.validator. in all resource properties files but several use s