Re: RFR 8173604: Proposal to move java.annotations.common -> java.xml.ws.annoations

On 03/02/2017 19:28, Lance Andersen wrote: Hi all, Attached is the webrev for renaming the module javax.annotation.commons to java.xml.ws.annotations: http://cr.openjdk.java.net/~lancea/8173604/ The rename looks good but I think an update to

Re: RFR: 8167063: spurious message "A JNI error has occurred" if start-class cannot be initialized

This seems to have caused a number of failures in hotspot testing as thrown ClassFormatErrors seem to have been replaced by LinkageError. https://bugs.openjdk.java.net/browse/JDK-8173915 David Thank you Kumar and Alan. Just pushed the fix. All the related tests from "core" and "pit" testset

Re: RFR: 8173898: StackWalker.walk throws InternalError if called from a constructor invoked through reflection.

This looks fine to me, Daniel. Fun test case. :) Thanks, -Brent On 02/03/2017 11:51 AM, Daniel Fuchs wrote: Hi, Please find below a simple fix for: 8173898: StackWalker.walk throws InternalError if called from a constructor invoked through reflection.

Re: Review Request: JDK-8173412 @Test in java/lang/annotation and java/lang/reflect/Proxy tests not run

+1 On 2017-02-04 01:14, Mandy Chung wrote: Fix @Test tests to be public. Mandy diff --git a/test/java/lang/annotation/AnnotationWithLambda.java b/test/java/lang/annotation/AnnotationWithLambda.java --- a/test/java/lang/annotation/AnnotationWithLambda.java +++

Review Request: JDK-8173412 @Test in java/lang/annotation and java/lang/reflect/Proxy tests not run

Fix @Test tests to be public. Mandy diff --git a/test/java/lang/annotation/AnnotationWithLambda.java b/test/java/lang/annotation/AnnotationWithLambda.java --- a/test/java/lang/annotation/AnnotationWithLambda.java +++ b/test/java/lang/annotation/AnnotationWithLambda.java @@ -43,7 +43,7 @@

Re: RFR: 8173898: StackWalker.walk throws InternalError if called from a constructor invoked through reflection.

> On 3 Feb 2017, at 15:27, Daniel Fuchs wrote: > > Hi Paul, > > On 03/02/17 21:54, Paul Sandoz wrote: >> >>> On 3 Feb 2017, at 11:51, Daniel Fuchs wrote: >>> >>> Hi, >>> >>> Please find below a simple fix for: >>> >>> 8173898:

Re: RFR 8173604: Proposal to move java.annotations.common -> java.xml.ws.annoations

> On Feb 3, 2017, at 6:29 PM, Mandy Chung wrote: > > >> On Feb 3, 2017, at 11:28 AM, Lance Andersen >> wrote: >> >> Hi all, >> >> Attached is the webrev for renaming the module javax.annotation.commons >> to java.xml.ws.annotations:

Re: RFR: 8173898: StackWalker.walk throws InternalError if called from a constructor invoked through reflection.

Hi Paul, On 03/02/17 21:54, Paul Sandoz wrote: On 3 Feb 2017, at 11:51, Daniel Fuchs wrote: Hi, Please find below a simple fix for: 8173898: StackWalker.walk throws InternalError if called from a constructor invoked through reflection.

Re: RFR 8173604: Proposal to move java.annotations.common -> java.xml.ws.annoations

> On Feb 3, 2017, at 11:28 AM, Lance Andersen wrote: > > Hi all, > > Attached is the webrev for renaming the module javax.annotation.commons > to java.xml.ws.annotations: http://cr.openjdk.java.net/~lancea/8173604/ >

Re: RFR 8173604: Proposal to move java.annotations.common -> java.xml.ws.annoations

+1 Paul. > On 3 Feb 2017, at 11:28, Lance Andersen wrote: > > Hi all, > > Attached is the webrev for renaming the module javax.annotation.commons > to java.xml.ws.annotations: http://cr.openjdk.java.net/~lancea/8173604/ >

Re: RFR: 8173898: StackWalker.walk throws InternalError if called from a constructor invoked through reflection.

> On 3 Feb 2017, at 11:51, Daniel Fuchs wrote: > > Hi, > > Please find below a simple fix for: > > 8173898: StackWalker.walk throws InternalError if called > from a constructor invoked through reflection. > https://bugs.openjdk.java.net/browse/JDK-8173898 > >

Re: RFR: 8173898: StackWalker.walk throws InternalError if called from a constructor invoked through reflection.

Hi, Please find below a new webrev. Part of the fix was mising in the previous one. I also took the opportunity to replace the test's assertEquals with those from org.testng.Assert. http://cr.openjdk.java.net/~dfuchs/webrev_8173898/webrev.01 best regards, -- daniel On 03/02/17 19:51, Daniel

Re: JDK 10 RFR of JDK-8173908: Problem list tools/jar/multiRelease/RuntimeTest.java until JDK-8173905 is fixed

+1 Paul. > On 3 Feb 2017, at 12:42, joe darcy wrote: > > Hello, > > Until JDK-8173905 is fixed, the test > > tools/jar/multiRelease/RuntimeTest.java > > should be problem listed so we can get clean test runs on JDK 10. > > Patch below. > > Thanks, > > -Joe > > diff

Re: JDK 10 RFR of JDK-8173908: Problem list tools/jar/multiRelease/RuntimeTest.java until JDK-8173905 is fixed

+1 > On Feb 3, 2017, at 3:42 PM, joe darcy wrote: > > Hello, > > Until JDK-8173905 is fixed, the test > > tools/jar/multiRelease/RuntimeTest.java > > should be problem listed so we can get clean test runs on JDK 10. > > Patch below. > > Thanks, > > -Joe > > diff -r

JDK 10 RFR of JDK-8173908: Problem list tools/jar/multiRelease/RuntimeTest.java until JDK-8173905 is fixed

Hello, Until JDK-8173905 is fixed, the test tools/jar/multiRelease/RuntimeTest.java should be problem listed so we can get clean test runs on JDK 10. Patch below. Thanks, -Joe diff -r 829a62c56e9c test/ProblemList.txt --- a/test/ProblemList.txtFri Feb 03 12:36:42 2017 -0800 +++

Re: JDK 10 RFR of JDK-8173903: Update various tests to pass under JDK 10

+1 Paul. > On 3 Feb 2017, at 11:21, joe darcy wrote: > > Hello, > > After the version update to "10" in JDK 10 ( JDK-8029942 ), various libraries > tests failed including: > >java/lang/module/MultiReleaseJarTest.java >

RFR: 8173898: StackWalker.walk throws InternalError if called from a constructor invoked through reflection.

Hi, Please find below a simple fix for: 8173898: StackWalker.walk throws InternalError if called from a constructor invoked through reflection. https://bugs.openjdk.java.net/browse/JDK-8173898 http://cr.openjdk.java.net/~dfuchs/webrev_8173898/webrev.00/ best regards, -- daniel

RFR 8173604: Proposal to move java.annotations.common -> java.xml.ws.annoations

Hi all, Attached is the webrev for renaming the module javax.annotation.commons to java.xml.ws.annotations: http://cr.openjdk.java.net/~lancea/8173604/ JPRT has been run showing no issues. Best Lance

Re: JDK 10 RFR of JDK-8173903: Update various tests to pass under JDK 10

Look good Joe > On Feb 3, 2017, at 2:21 PM, joe darcy wrote: > > Hello, > > After the version update to "10" in JDK 10 ( JDK-8029942 ), various libraries > tests failed including: > >java/lang/module/MultiReleaseJarTest.java >

JDK 10 RFR of JDK-8173903: Update various tests to pass under JDK 10

Hello, After the version update to "10" in JDK 10 ( JDK-8029942 ), various libraries tests failed including: java/lang/module/MultiReleaseJarTest.java java/security/Provider/ProviderVersionCheck.java sun/security/tools/jarsigner/multiRelease/MVJarSigningTest.java These tests need to

Re: Guaranteed order of annotations?

Hi Joe, Thanks for your confirmation. Bean Validation may benefit from it, but I understand that just a single request hardly justifies the change. --Gunnar 2017-01-23 23:05 GMT+01:00 joe darcy : > Hi Gunnar, > > Annotations went into the platform way back in Java SE

Re: RFR: 8171522: Jar prints error message with old (non gnu-style options).

+1 On 02/02/2017 11:02 AM, Henry Jen wrote: Sorry, please ignore previous email, this one is correct. diff -r 0e2935453091 src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties --- a/src/jdk.jartool/share/classes/sun/tools/jar/resources/jar.properties Wed Feb 01 11:05:33

Re: Ping: [JAXP] RFR: 8173602: TESTBUG: javax/xml/jaxp/unittest/transform/TransformerTest.java needs refactoring

Hi Christoph, No objections. best regards, -- daniel On 03/02/17 13:01, Langer, Christoph wrote: Hi Daniel, thanks for taking care of this. As for the pretty printing: That's not something which is explicitly tested here. I think it was me who introduced this for new tests I had added. I

RE: Ping: [JAXP] RFR: 8173602: TESTBUG: javax/xml/jaxp/unittest/transform/TransformerTest.java needs refactoring

Hi Daniel, thanks for taking care of this. As for the pretty printing: That's not something which is explicitly tested here. I think it was me who introduced this for new tests I had added. I found it quite useful when analyzing test results. So now with the public APIs I guess this code is

Re: Ping: [JAXP] RFR: 8173602: TESTBUG: javax/xml/jaxp/unittest/transform/TransformerTest.java needs refactoring

Hi Christoph, I had a look at your patch, it seems OK. I didn't know that testng supported @Test annotations on methods of inner classes, but that looks useful. The patch is a bit difficult to review because the diff seems a bit lost sometime - but as far as I could see what was there before

Re: [RFR] 8160768: Add capability to custom resolve host/domain names within the default JDNI LDAP provider

Hi Rob, On 02/02/17 22:14, Rob McKenna wrote: Thanks Daniel, New webrev at http://cr.openjdk.java.net/~robm/8160768/webrev.04/ In addition to your comments below I've added the package access check we discussed. Note: when a provider returns multiple results we create an LdapCtx based on the

Ping: [JAXP] RFR: 8173602: TESTBUG: javax/xml/jaxp/unittest/transform/TransformerTest.java needs refactoring

Hi, Ping - anyone out there who could have a look at my JAXP test update? Thanks Christoph From: Langer, Christoph Sent: Montag, 30. Januar 2017 15:28 To: core-libs-dev@openjdk.java.net Subject: [JAXP] RFR: 8173602: TESTBUG: javax/xml/jaxp/unittest/transform/TransformerTest.java needs

Re: JDK 9 RFR of JDK-8173864: Problem list src/jdk/nashorn/api/tree/test/ParseAPITest.java for some platforms

+1 Hannes > Am 03.02.2017 um 09:57 schrieb Sundararajan Athijegannathan > : > > +1 > > -Sundar > > On 03/02/17, 10:24 AM, Amy Lu wrote: >> src/jdk/nashorn/api/tree/test/ParseAPITest.java >> >> This nashorn test keeps failing at linux-i586,

Re: JDK 9 RFR of JDK-8173864: Problem list src/jdk/nashorn/api/tree/test/ParseAPITest.java for some platforms

+1 -Sundar On 03/02/17, 10:24 AM, Amy Lu wrote: src/jdk/nashorn/api/tree/test/ParseAPITest.java This nashorn test keeps failing at linux-i586, windows-i586 and solaris-sparcv9 (JDK-8173863) Please review this patch to put the test to problem list until issues addressed. bug:

Re: [RFR] 8160768: Add capability to custom resolve host/domain names within the default JDNI LDAP provider

Hi Rob, Most of the code changes looks fine except new code will throw NPE if "ServiceLocator.mapDnToDomainName(ldapUrl.getDN())" is not able to map. you have to check for null in LdapCtxFactory.java class as follows. if(ServiceLocator.mapDnToDomainName(ldapUrl.getDN())!=null){