Re: RFR JDK-8176235: Minor updates to package.html

Hi Lance, Looks good. best, Joe On 3/6/2017 12:34 PM, Lance Andersen wrote: Hi all, This RFR is for minor updates to package.html for JDBC. For JDK 10, I will probably overhaul these files and possibly convert to package-info.java. But for now just keeping the updates minimal. Best Lanc

Re: RFR JDK-8176029: Linebreak matcher is not equivalent to the pattern as stated in javadoc

ping ... On 3/2/17, 6:56 PM, Xueming Shen wrote: Hi, Please help review the change for JDK-8176029 issue: https://bugs.openjdk.java.net/browse/JDK-8176029 webrev: http://cr.openjdk.java.net/~sherman/8176029/webrev It appears the API doc for \R is correct, instead the implementation is buggy

Re: RFR: 8159523. Fix tests depending on absence of -limitmods in VM arguments.

> On Mar 6, 2017, at 5:27 PM, Alexandre (Shura) Iline > wrote: > > Hi, > > Could you please review the suggested fox for: > https://bugs.openjdk.java.net/browse/JDK-8159523 > > There has been a bit of discussion on jigsaw-dev, but it perhaps make sense > to include core-libs-dev. > > There

RFR: 8159523. Fix tests depending on absence of -limitmods in VM arguments.

Hi, Could you please review the suggested fox for: https://bugs.openjdk.java.net/browse/JDK-8159523 There has been a bit of discussion on jigsaw-dev, but it perhaps make sense to include core-libs-dev. There have been some fixes since the review was published, so we are now at revision #4: ht

Re: [9] RFR: 8174736: [JCP] [Mac]Cannot launch JCP on Mac os with language set to "Chinese, Simplified" while region is not China

Hi Brent, thanks for the review! On 3/6/17 3:21 PM, Brent Christian wrote: Hi, Naoto That fix looks fine. The "Portuguese (Brazil)" fix now happens before the Language ID fix, but that shouldn't matter, as the "pt_BR" ID won't trigger that code anyway (doesn't contain '-'). Yes. One very m

Re: [9] RFR: 8174736: [JCP] [Mac]Cannot launch JCP on Mac os with language set to "Chinese, Simplified" while region is not China

Hi, Naoto That fix looks fine. The "Portuguese (Brazil)" fix now happens before the Language ID fix, but that shouldn't matter, as the "pt_BR" ID won't trigger that code anyway (doesn't contain '-'). One very mall nit I noticed: one more space on line 97 will realign it with line 96, which

RFR JDK-8176235: Minor updates to package.html

Hi all, This RFR is for minor updates to package.html for JDBC. For JDK 10, I will probably overhaul these files and possibly convert to package-info.java. But for now just keeping the updates minimal. Best Lance —— ljanders-mac:classes ljanders$ hg diff java/sql/package.html javax/

ProcessHandle::onExit behavior

I was trying to get an example to work with the new ProcessHandle API. My goal was to wait on another process (Spotify) to terminate before printing something to the console: ProcessHandle handle = ProcessHandle.allProcesses() .filter(h -> h.info().commandLine().map(cmd -> cmd

Re: RFR: jsr166 jdk? integration wave ?

On 03/03/17 19:43, Martin Buchholz wrote: Changes except for ThreadPoolExecutor.java submitted. ThreadPoolExecutor doc change is deferred to jdk10. We have a new change, to SubmissionPublisher, which should probably make jdk9 because SubmissionPublisher is new to jdk9. https://bugs.openjdk.ja

Re: JDK 9 RFR of JDK-8176187: jdk/internal/misc/JavaLangAccess/NewUnsafeString.java is not run

On 3/6/17 3:49 PM, Alan Bateman wrote: Looks okay, I hope there aren't too many more of these. -Alan * @compile -XDignore.symbol.file UTCAliasTest.java + * @run main UTCAliasTest */ I noticed that -XDignore.symbol.file are still used in "9" test, thought they might be bulk changed with JD