Re: 9 RFR of JDK-8176337: Mark several tests as intermittently failing

Looks fine Hamlin; thanks, -Joe On 3/7/2017 7:36 PM, Hamlin Li wrote: Would you please review below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8176337 webrev: http://cr.openjdk.java.net/~mli/8176337/webrev.00/ These tests are failing intermittently, they should be marked accordi

RFR 8176195/9, Fix misc module dependencies in jdk_core tests

Hi there, please review the changes to explicitly declare dependencies in tests. This will make better test selection with --limit-module option. Bug: https://bugs.openjdk.java.net/browse/JDK-8176195 Webrev: http://cr.openjdk.java.net/~xiaofeya/8176195/webrev.00/ I didn't use TE

9 RFR of JDK-8176337: Mark several tests as intermittently failing

Would you please review below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8176337 webrev: http://cr.openjdk.java.net/~mli/8176337/webrev.00/ These tests are failing intermittently, they should be marked accordingly with @key intermittent java/nio/channels/FileChannel/Transfer.j

Re: JDK 9 RFR of JDK-8167525: update jdk tests to remove @compile --add-modules workaround

> On Mar 7, 2017, at 7:13 PM, Amy Lu wrote: > > Please review the patch to remove the @compile --add-modules workaround. > > In the past, tests added --add-modules to @compile (JDK-8169231) or to @run > (JDK-8156579) to workaround jtreg issue CODETOOLS-7901761. CODETOOLS-7901761 > has been fi

JDK 9 RFR of JDK-8167525: update jdk tests to remove @compile --add-modules workaround

Please review the patch to remove the @compile --add-modules workaround. In the past, tests added --add-modules to @compile (JDK-8169231) or to @run (JDK-8156579) to workaround jtreg issue CODETOOLS-7901761. CODETOOLS-7901761 has been fixed in 4.2/b05, workaround in tests should be reverted.

Re: Review Request JDK-8176333: jdeps error message should include a proper MR jar file name

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Mar 7, 2017, at 8:45 PM, Mandy Chung wrote: > > http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8176333/webrev

Review Request JDK-8176333: jdeps error message should include a proper MR jar file name

http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8176333/webrev.00/ This is a simple fix to jdeps to print the MR JAR file name in the error message. The existing implementation icorrectly casts String[] as an Object that leads to print String[].toString() instead of the filename. Mandy

Is @deprecated javadoc comment still useful?

Hi, Mr Deprecator I'm adding @Deprecated annotations with arguments to a module and a class, and at the same time I add @deprecated javadoc comments. The resulting javadoc pages are attached. As you can see, the bold sentence (I assume it's generated from the annotation) and the line below c

Re: Review Request JDK-8175797: (ref) Reference::enqueue method should clear referent before enqueuing

> On Mar 7, 2017, at 10:35 AM, Mandy Chung wrote: > > This proposes to update Reference::enqueue method to clear this reference > object before enqueuing it to the registered queue consistent with what > the garbage collector does that clears the reference object before putting > it in the pendi

Re: RFR (JAXP) 8175830: Provide javadoc description for jdk.xml.dom module

Pushed. Thanks again Lance! -Joe On 3/7/2017 10:59 AM, Lance Andersen wrote: I think you are good to go Joe On Mar 7, 2017, at 1:56 PM, huizhe wang > wrote: Thanks Lance. Updated. http://cr.openjdk.java.net/~joehw/jdk9/8175830/webrev/src/jdk.xml.dom/share/cla

Re: RFR (JAXP) 8175830: Provide javadoc description for jdk.xml.dom module

I think you are good to go Joe > On Mar 7, 2017, at 1:56 PM, huizhe wang wrote: > > Thanks Lance. Updated. > > http://cr.openjdk.java.net/~joehw/jdk9/8175830/webrev/src/jdk.xml.dom/share/classes/module-info.java.udiff.html > >

Re: RFR (JAXP) 8175830: Provide javadoc description for jdk.xml.dom module

Thanks Lance. Updated. http://cr.openjdk.java.net/~joehw/jdk9/8175830/webrev/src/jdk.xml.dom/share/classes/module-info.java.udiff.html -Joe On 3/7/2017 10:45 AM, Lance Andersen wrote: Hi Joe, I would like to suggest to consider the wording similar to what we have for other modules +/** +

Re: RFR (JAXP) 8175830: Provide javadoc description for jdk.xml.dom module

Hi Joe, I would like to suggest to consider the wording similar to what we have for other modules +/** + * This module contains the sub-packages in the W3C Document Object Model (DOM) API + * that are not part of the Jave SE API. + * + * @since 9 + */ Perhaps change to: Defines the subset o

RFR (JAXP) 8175830: Provide javadoc description for jdk.xml.dom module

Hi, Please review a module description for jdk.xml.dom. JBS: https://bugs.openjdk.java.net/browse/JDK-8175830 webrev: http://cr.openjdk.java.net/~joehw/jdk9/8175830/webrev/ Thanks, Joe

Re: RFR(s): 8176304: Number of javax/management test fails due to undeclared dependencies

Hi Sergei, I have several observations: - AFAIK you don't need to list modules that are required by a module already listed. so for instance, if you list jdk.management.agent then you don't need to list java.management or java.management.rmi (unless you need qualified exports from those

Review Request JDK-8175797: (ref) Reference::enqueue method should clear referent before enqueuing

This proposes to update Reference::enqueue method to clear this reference object before enqueuing it to the registered queue consistent with what the garbage collector does that clears the reference object before putting it in the pending queue for enqueuing. It has been a common pattern that Ref

RFR(s): 8176304: Number of javax/management test fails due to undeclared dependencies

Hi Team, Please take a look at the fix for javax.management tests. BugID: https://bugs.openjdk.java.net/browse/JDK-8176304 Webrev: http://cr.openjdk.java.net/~skovalev/8176304/webrev.00/ Issue: number of tests failing with "--limit-module" command line option due to missed dependencies. In gen

Re: ProcessHandle::onExit behavior

Sander, > On 6 Mar 2017, at 15:46, Sander Mak wrote: > > I was trying to get an example to work with the new ProcessHandle API. My > goal was to wait on another process (Spotify) to terminate before printing > something to the console: > > ProcessHandle handle = >ProcessHandle.allProc