On 19/04/2017 10:54 PM, Magnus Ihse Bursie wrote:
With JDK-8172312, the file src/jdk.jdi/share/classes/jdi-overview.html
is no longer included in the generated documentation. The information
provided by that file should move to
src/jdk.jdi/share/classes/module-info.java instead.
Looks good, but
> On Apr 19, 2017, at 11:26 AM, Kumar Srinivasan
> wrote:
>
>
> Made the change you recommended, and here is the updated webrev
> http://cr.openjdk.java.net/~ksrini/8076417/webrev.01/
+1
Mandy
On 4/20/17 2:26 AM, Kumar Srinivasan wrote:
Made the change you recommended, and here is the updated webrev
http://cr.openjdk.java.net/~ksrini/8076417/webrev.01/
Thank you Kumar!Looks good.
(I'm not official reviewer)
Thanks,
Amy
Thanks
Kumar
Hi, Kumar
As the removed test is the only one
> On Apr 19, 2017, at 2:51 PM, Mandy Chung wrote:
>
>
>> On Apr 19, 2017, at 2:02 AM, Peter Levart wrote:
>>
>> I wonder if there are (or will be) other places where such silent swallowing
>> of run-time exceptions happens or will happen. Wouldn't it be good to "fix"
>> Boolean.getBoolean()
> On Apr 19, 2017, at 2:02 AM, Peter Levart wrote:
>
> I wonder if there are (or will be) other places where such silent swallowing
> of run-time exceptions happens or will happen. Wouldn't it be good to "fix"
> Boolean.getBoolean() and friends?
>
> I filed the following bug to track this:
>
Martin wrote:
+ * The methods {@link #orElse(java.lang.Object) orElse()} and
It's sad that in 2017 we still can't write
{@link #orElse(T)}
... but ... we can and should write
{@link #orElse(Object) orElse(T)}
making the source and html more readable (orElse is not nullary)
Well we're not going
Hi Aleksej,
The changes look good. Some changes to the notes in the test may make it
a bit clearer on what scenarios are tested: move the current notes for
the method testResetEnabled to parseAndCheckReset, and then add scenario
description to the three test* methods, for example, testNoFeatur
Made the change you recommended, and here is the updated webrev
http://cr.openjdk.java.net/~ksrini/8076417/webrev.01/
Thanks
Kumar
Hi, Kumar
As the removed test is the only one test under jdk/asm, it needs to be
removed from jdk_other test group:
--- a/test/TEST.groups
+++ b/test/TEST.grou
Ah, yes, good catch. Thanks Amy.
Kumar
Hi, Kumar
As the removed test is the only one test under jdk/asm, it needs to be
removed from jdk_other test group:
--- a/test/TEST.groups
+++ b/test/TEST.groups
@@ -269,7 +269,6 @@
javax/transaction \
javax/xml \
-javax/xml/crypto \
-
> On 18 Apr 2017, at 20:29, Martin Buchholz wrote:
>
> + * The methods {@link #orElse(java.lang.Object) orElse()} and
>
> It's sad that in 2017 we still can't write
> {@link #orElse(T)}
> ... but ... we can and should write
> {@link #orElse(Object) orElse(T)}
> making the source and html mo
> On Apr 19, 2017, at 5:54 AM, Magnus Ihse Bursie
> wrote:
>
> With JDK-8172312, the file src/jdk.jdi/share/classes/jdi-overview.html is no
> longer included in the generated documentation. The information provided by
> that file should move to src/jdk.jdi/share/classes/module-info.java inste
[Looping in nio-dev]
I can file an issue and look into it.
Brian
On Apr 18, 2017, at 11:44 PM, Alan Bateman wrote:
> On 19/04/2017 05:44, Chan, Sunny wrote:
>
>> While reading the code for sun.nio.fs.WindowsFileSystemProvider and
>> sun.nio.fs.WindowsUserDefinedFileAttributeView, I noticed t
On 19/04/2017 13:54, Magnus Ihse Bursie wrote:
With JDK-8172312, the file src/jdk.jdi/share/classes/jdi-overview.html
is no longer included in the generated documentation. The information
provided by that file should move to
src/jdk.jdi/share/classes/module-info.java instead.
I also took the
Looks good to me.
/Erik
On 2017-04-19 14:54, Magnus Ihse Bursie wrote:
With JDK-8172312, the file src/jdk.jdi/share/classes/jdi-overview.html
is no longer included in the generated documentation. The information
provided by that file should move to
src/jdk.jdi/share/classes/module-info.java
With JDK-8172312, the file src/jdk.jdi/share/classes/jdi-overview.html
is no longer included in the generated documentation. The information
provided by that file should move to
src/jdk.jdi/share/classes/module-info.java instead.
I also took the liberty of removing a bunch of other overview.ht
On Wed, Apr 19, 2017 at 12:22 PM, Alan Bateman wrote:
> On 19/04/2017 10:18, Volker Simonis wrote:
>
>> :
>> That's a good suggestion. I've updated the patch with a slightly
>> modified comment:
>>
>> // Use an intermediate File object to construct a URI/URL without
>> // authority component as UR
On 19/04/2017 10:18, Volker Simonis wrote:
:
That's a good suggestion. I've updated the patch with a slightly
modified comment:
// Use an intermediate File object to construct a URI/URL without
// authority component as URLClassPath can't handle URLs with a UNC
// server name in the authority c
> On 19 Apr 2017, at 10:18, Volker Simonis wrote:
>
>> ...
>
> That's a good suggestion. I've updated the patch with a slightly
> modified comment:
>
> // Use an intermediate File object to construct a URI/URL without
> // authority component as URLClassPath can't handle URLs with a UNC
> // s
On Wed, Apr 19, 2017 at 9:03 AM, Alan Bateman wrote:
> On 18/04/2017 18:44, Volker Simonis wrote:
>
> Hi Alan, Chris,
>
> thanks for your help and feedback.
> It seems my fix was indeed "too optimistic". I've only briefly looked into
> the errors reported by Chris. The first one is due to a cyclic
Hi Mandy, Kim,
On 04/17/2017 10:53 PM, Mandy Chung wrote:
On Apr 17, 2017, at 1:47 PM, Kim Barrett wrote:
Please review this fix for a bug in JDK-8175797: the mechanism
provided by that change for reverting to the old behavior of
Reference.enqueue (for backward compatibility) does not work.
A
On 18/04/2017 18:44, Volker Simonis wrote:
Hi Alan, Chris,
thanks for your help and feedback.
It seems my fix was indeed "too optimistic". I've only briefly looked
into the errors reported by Chris. The first one is due to a cyclic
dependency between Paths.get() and FileSystems.getDefault().
21 matches
Mail list logo
