Re: JDK 9 RFR of JDK-8174171: Move spliterator testing of BitSet into big memory tests BitSetStreamTest

Thank you for explanation Amy. you still need a reviewer. Thank you -Hamlin On 2017/4/21 12:47, Amy Lu wrote: Thank you Hamlin for your comments. On 4/20/17 6:23 PM, Hamlin Li wrote: Hi Amy, Thank you for taking this. Have some minor comments about BitSetStreamTest.java 1. is below line

Re: JDK 9 RFR of JDK-8174171: Move spliterator testing of BitSet into big memory tests BitSetStreamTest

Thank you Hamlin for your comments. On 4/20/17 6:23 PM, Hamlin Li wrote: Hi Amy, Thank you for taking this. Have some minor comments about BitSetStreamTest.java 1. is below line necessary? or 2g big enough? 51 * @requires os.maxMemory >= 2g 2. I'm not sure if Xmx1024m should be a bigger va

Re: JDK 9 RFR: 8176168: Performance drop due to SAXParser SymbolTable reset

Looks fine. -Joe On 4/20/2017 5:17 PM, Aleks Efimov wrote: Hi Joe, Lance, Thank you both for the reviews! I've updated the test methods with comments per Joe suggestions [1]. Also the CCC request was approved recently. If there will be no further comments I'll push the changes. Best Regard

Re: JDK 9 RFR: 8176168: Performance drop due to SAXParser SymbolTable reset

Hi Joe, Lance, Thank you both for the reviews! I've updated the test methods with comments per Joe suggestions [1]. Also the CCC request was approved recently. If there will be no further comments I'll push the changes. Best Regards, Aleksei [1] http://cr.openjdk.java.net/~aefimov/8176168/01

Re: [9] RFR: 8178823: Unable to initialize HijrahCalendar: Hijrah-umalqura when running with a security manager

+1, Looks good Naoto, Thanks, Roger On 4/20/2017 4:50 PM, Lance Andersen wrote: Hi Naoto Looks fine Best Lance On Apr 20, 2017, at 3:42 PM, Naoto Sato wrote: Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8178823 The proposed fix is locate

Re: [9] RFR: 8178823: Unable to initialize HijrahCalendar: Hijrah-umalqura when running with a security manager

Hi Naoto Looks fine Best Lance > On Apr 20, 2017, at 3:42 PM, Naoto Sato wrote: > > Hello, > > Please review the fix to the following issue: > > https://bugs.openjdk.java.net/browse/JDK-8178823 > > The proposed fix is located at: > > http://cr.openjdk.java.net/~naoto/8178823/webrev.01/ > >

Re: JDK 9 RFR(s): 8167981: Optional: add notes explaining intended use

On 4/20/17 10:03 AM, Martin Buchholz wrote: This looks good. I don't think there's any need anymore to have fully qualified class names in @links, so just: {@link #orElseGet(Supplier) orElseGet} (but there's a global cleanup there) Thanks for reviewing. Yes, "java.util.function.Supplier"

[9] RFR: 8178823: Unable to initialize HijrahCalendar: Hijrah-umalqura when running with a security manager

Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8178823 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8178823/webrev.01/ The fix is to allow "accessSystemModule" RuntimePermission on reading the Hijrah properties file, which i

Re: RFR: JDK-8179022 Add serialization spec as markdown

> On Apr 20, 2017, at 11:47 AM, Magnus Ihse Bursie wrote: > > http://cr.openjdk.java.net/~ihse/JDK-8179022-add-markdown-serialization-spec/webrev.02 A passing comment. Copyright header is missing in make/devkit/createPandocBundle.sh Mandy

Re: RFR: JDK-8179022 Add serialization spec as markdown

Hi Magnus, How did you verify that the result was the same as the previous specification? It would have been good to separate the content changes from the other parts so they could be properly reviewed. The proposed markdown source does not favorably easily with the spec as I worked on it a co

Re: RFR: JDK-8179022 Add serialization spec as markdown

On 2017-04-20 15:59, Alan Bateman wrote: On 20/04/2017 14:49, Magnus Ihse Bursie wrote: Here's the first step towards fixing JDK-8177434 . A framework is added for converting markdown specs to html using pandoc. The Java serialization spec is

Re: RFR 8178915: Minor update to the PooledConnection javadoc

Hi Lance, The changes look good to me. -Joe On 4/20/2017 6:40 AM, Lance Andersen wrote: Hi all, This RFR makes a minor update to the PooledConnection javadoc. The CCC has been approved. Here is the diff: ——— $ hg diff diff -r 9ba6760481a8 src/java.sql/share/classes/javax/sql/PooledCon

Re: JDK 9 RFR(s): 8167981: Optional: add notes explaining intended use

This looks good. I don't think there's any need anymore to have fully qualified class names in @links, so just: {@link #orElseGet(Supplier) orElseGet} (but there's a global cleanup there) --- I would write "result". instead of "result." (but the latter has never made sense to me even as a chi

RFR [9] 8179021: Latest bugfixes to WebSocket/HPACK from the sandbox repo

Hello, Please review the following change: http://cr.openjdk.java.net/~prappo/8179021/webrev.00/ Along with refactoring this change contains a number of critical fixes for WebSocket. Critical fixes are applied to Receiver and OpeningHandshake. Also this change removes 2 convenience methods a

Re: RFR: JDK-8178037 Move information from jdi-overview.html into jdk.jdi module-info.java

> On Apr 20, 2017, at 12:57 AM, Magnus Ihse Bursie > wrote: > > > http://cr.openjdk.java.net/~ihse/JDK-8178037-fix-obsolete-overview-files/webrev.02/ Looks good. Mandy

Re: RFR: JDK-8179022 Add serialization spec as markdown

The build changes look good to me. I can't comment on the actual .md files. /Erik On 2017-04-20 15:49, Magnus Ihse Bursie wrote: Here's the first step towards fixing JDK-8177434 . A framework is added for converting markdown specs to html usin

Re: RFR: JDK-8179022 Add serialization spec as markdown

On 20/04/2017 14:49, Magnus Ihse Bursie wrote: Here's the first step towards fixing JDK-8177434 . A framework is added for converting markdown specs to html using pandoc. The Java serialization spec is added in markdown format as a proof of con

RFR: JDK-8179022 Add serialization spec as markdown

Here's the first step towards fixing JDK-8177434 . A framework is added for converting markdown specs to html using pandoc. The Java serialization spec is added in markdown format as a proof of concept. I also reintroduced the functionality to e

RFR 8178915: Minor update to the PooledConnection javadoc

Hi all, This RFR makes a minor update to the PooledConnection javadoc. The CCC has been approved. Here is the diff: ——— $ hg diff diff -r 9ba6760481a8 src/java.sql/share/classes/javax/sql/PooledConnection.java --- a/src/java.sql/share/classes/javax/sql/PooledConnection.javaSat Ap

Re: JDK 9 RFR of JDK-8174171: Move spliterator testing of BitSet into big memory tests BitSetStreamTest

Hi Amy, Thank you for taking this. Have some minor comments about BitSetStreamTest.java 1. is below line necessary? or 2g big enough? 51 * @requires os.maxMemory >= 2g 2. I'm not sure if Xmx1024m should be a bigger value. 55 * @run testng/othervm -Xms512m -Xmx1024m 3. spliteratorOfIntDataP

Re: Deprecated Java EE Modules in JDK9

On 20/04/2017 08:38, Heiko Wagner wrote: Sorry for my ignotance, but I need some advice on how to properly write a desktop app that uses JAX-WS to pull some data from a WS-I Service. I can understand why JAX-WS is deprecated and marked for removel to help out the Java EE crwod to migrate their

Re: Deprecated Java EE Modules in JDK9

Hi Heiko, On 04/20/2017 09:38 AM, Heiko Wagner wrote: Sorry for my ignotance, but I need some advice on how to properly write a desktop app that uses JAX-WS to pull some data from a WS-I Service. I can understand why JAX-WS is deprecated and marked for removel to help out the Java EE crwod to

JDK 9 RFR of JDK-8174171: Move spliterator testing of BitSet into big memory tests BitSetStreamTest

Please review this test-only change. Integer.MAX_VALUE bit set testdata in bitStreamTestcases of SpliteratorTraversingAndSplittingTest was removed in JDK-8169838 due to out of memory errors. It also cause issue in BitSetStreamTest (JDK-8079538). And yes, testing for this do consume lots of mem

Re: RFR: JDK-8178037 Move information from jdi-overview.html into jdk.jdi module-info.java

On 20/04/2017 5:57 PM, Magnus Ihse Bursie wrote: On 2017-04-20 04:21, David Holmes wrote: On 19/04/2017 10:54 PM, Magnus Ihse Bursie wrote: With JDK-8172312, the file src/jdk.jdi/share/classes/jdi-overview.html is no longer included in the generated documentation. The information provided by th

Re: RFR: JDK-8178037 Move information from jdi-overview.html into jdk.jdi module-info.java

On 2017-04-20 04:21, David Holmes wrote: On 19/04/2017 10:54 PM, Magnus Ihse Bursie wrote: With JDK-8172312, the file src/jdk.jdi/share/classes/jdi-overview.html is no longer included in the generated documentation. The information provided by that file should move to src/jdk.jdi/share/classes/

Deprecated Java EE Modules in JDK9

Sorry for my ignotance, but I need some advice on how to properly write a desktop app that uses JAX-WS to pull some data from a WS-I Service. I can understand why JAX-WS is deprecated and marked for removel to help out the Java EE crwod to migrate their application servers to JDK9, but I don't fu