Re: Accessing module internals from bytecode rewriting agent

Hi Jeremy, I think your email points out *why* turning this on out of the blocks is going to make things a ton more difficult. IMHO, 9 needs to be opt-in rather than opt-out. By 10 I think we’ll be ready for opt-out rather than opt-in. Kind regards, Kirk Pepperdine > On May 5, 2017, at 8:39 AM

Re: JDK 10 RFR of JDK-8138672: Math. negativeZeroFloatBits and Math. negativeZeroDoubleBits should be final

On May 4, 2017, at 5:39 PM, Paul Sandoz wrote: >> Please review the patch below to address >> >> JDK-8138672: Math. negativeZeroFloatBits and Math. negativeZeroDoubleBits >> should be final >> > > +1 -(-1) Brian

Re: JDK 10 RFR of JDK-8138672: Math. negativeZeroFloatBits and Math. negativeZeroDoubleBits should be final

> On 4 May 2017, at 16:59, joe darcy wrote: > > Hello, > > Please review the patch below to address > >JDK-8138672: Math. negativeZeroFloatBits and Math. negativeZeroDoubleBits > should be final > +1 Paul. > The build works after the change; no other static fields in java.lang.Math >

JDK 10 RFR of JDK-8138672: Math. negativeZeroFloatBits and Math. negativeZeroDoubleBits should be final

Hello, Please review the patch below to address JDK-8138672: Math. negativeZeroFloatBits and Math. negativeZeroDoubleBits should be final The build works after the change; no other static fields in java.lang.Math have a missing final modifier. Thanks, -Joe diff -r 32f118110e09 src/ja

Re: tutorial on using Cleaner-based finalization

Thanks, Peter and Roger. In addition to the classes listed by Lance, a complete list of the affected finalizers can be found in this JIRA comment: https://issues.apache.org/jira/browse/DERBY-6856?focusedCommentId=15990011&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comm

Re: Review Request: JDK-8179645: java.util.jar.Packer.newPacker and newUnpacker fails when running with security manager

On 5/4/2017 2:52 PM, Mandy Chung wrote: On May 4, 2017, at 2:13 PM, Alan Bateman wrote: On 04/05/2017 21:35, Mandy Chung wrote: java.util.jar.Packer.newPacker and newUnpacker fails when running with security manager. It is an existing bug but we uncovers this only now because a new RuntimeP

Re: Review Request: JDK-8179645: java.util.jar.Packer.newPacker and newUnpacker fails when running with security manager

> On May 4, 2017, at 2:13 PM, Alan Bateman wrote: > > > On 04/05/2017 21:35, Mandy Chung wrote: >> java.util.jar.Packer.newPacker and newUnpacker fails when running >> with security manager. It is an existing bug but we uncovers this >> only now because a new RuntimePermission “accessSystemMod

Re: RFR 8150681 Update JAR specification for multi-release jar files

New update here: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8150681-jar-spec-markdown-with-mr-jar/webrev/src/java.base/share/specs/jar/jar.md.sdiff.html

Re: Review Request: JDK-8179645: java.util.jar.Packer.newPacker and newUnpacker fails when running with security manager

On 04/05/2017 21:35, Mandy Chung wrote: java.util.jar.Packer.newPacker and newUnpacker fails when running with security manager. It is an existing bug but we uncovers this only now because a new RuntimePermission “accessSystemModules” is required to access resources from the system image. Webr

Re: RFR 8150681 Update JAR specification for multi-release jar files

Thanks, fixed, Paul. > On 4 May 2017, at 07:28, Sean Mullan wrote: > > Couple of typos on a quick review: > > 55: s/the the/the/ > 129-130: s/the exactly/exactly the/ > 144: fukes -> files? > > --Sean

Review Request: JDK-8179645: java.util.jar.Packer.newPacker and newUnpacker fails when running with security manager

java.util.jar.Packer.newPacker and newUnpacker fails when running with security manager. It is an existing bug but we uncovers this only now because a new RuntimePermission “accessSystemModules” is required to access resources from the system image. Webrev: http://cr.openjdk.java.net/~mchung/jdk9

Re: RFR 8179634: Add JDBC 4.2 to bullet list in package.html

+1 Joe On 5/4/2017 10:40 AM, Lance Andersen wrote: Hi, This RFR is for a trivial update to package.html to include 4.2 which was accidentally omitted — hg diff package.html diff -r a50b619ac159 src/java.sql/share/classes/java/sql/package.html --- a/src/java.sql/share/classes/java/sql

RFR 8179634: Add JDBC 4.2 to bullet list in package.html

Hi, This RFR is for a trivial update to package.html to include 4.2 which was accidentally omitted — hg diff package.html diff -r a50b619ac159 src/java.sql/share/classes/java/sql/package.html --- a/src/java.sql/share/classes/java/sql/package.html Wed May 03 12:58:17 2017 -0400 +++ b/s

Re: tutorial on using Cleaner-based finalization

> On May 4, 2017, at 11:32 AM, Mandy Chung wrote: > > >> On May 3, 2017, at 11:16 PM, Peter Levart wrote: >> >> Hi Rick, >> >> Allow me to join the discussion... >> >> On 05/04/2017 04:21 AM, Rick Hillegas wrote: >>> Thanks, Roger. That is a helpful example. >>> >>> Derby is a component wh

Re: RFR 8179566: Add additional jaxws messages to be translated

> On 4 May 2017, at 17:50, Roman Grigoriadi wrote: > > >> On 4 May 2017, at 17:21, Mandy Chung > > wrote: >> >> The JAX-WS in JDK 9 is going to be 2.3.0 [1]. java.xml.ws is not resolved >> by default. JAX-WS 2.1 API can only be loaded to the runtime from class

Re: RFR 8179566: Add additional jaxws messages to be translated

> On 4 May 2017, at 17:21, Mandy Chung wrote: > > The JAX-WS in JDK 9 is going to be 2.3.0 [1]. java.xml.ws is not resolved by > default. JAX-WS 2.1 API can only be loaded to the runtime from class path if > java.xml.ws is not resolved. The JAX-WS runtime in JDK 9 will not be loaded > in t

Re: RFR 8150681 Update JAR specification for multi-release jar files

On 03/05/2017 22:44, Paul Sandoz wrote: Hi, Please review an update to the JAR “specification” (in the loose sense of the term): - first, it has been moved from a closed repository into the idk repository (same shared location as the recently introduced serialisation specification) and conv

Re: RFR 8179566: Add additional jaxws messages to be translated

Got it, thank you Mandy! I will wait this update into repo until May 5th 11:30pm (Beijing). Thanks, Leo On 05/04/2017 11:21 PM, Mandy Chung wrote: The JAX-WS in JDK 9 is going to be 2.3.0 [1]. java.xml.ws is not resolved by default. JAX-WS 2.1 API can only be loaded to the runtime from clas

Re: tutorial on using Cleaner-based finalization

> On May 3, 2017, at 11:16 PM, Peter Levart wrote: > > Hi Rick, > > Allow me to join the discussion... > > On 05/04/2017 04:21 AM, Rick Hillegas wrote: >> Thanks, Roger. That is a helpful example. >> >> Derby is a component which can be quiesced and unloaded on >> resource-constrained platfo

Re: RFR: Update tables in java.base to be HTML5-friendly.

On 5/3/17 7:49 PM, Martin Buchholz wrote: --- Yes, "striped" is a much better name than "altrows". "striped-tables" as you suggest may be better. Choose your names carefully - we can't change them in the future. --- Well, we can, ... but ... A goal of creating specification(s) for the

Re: RFR 8179566: Add additional jaxws messages to be translated

The JAX-WS in JDK 9 is going to be 2.3.0 [1]. java.xml.ws is not resolved by default. JAX-WS 2.1 API can only be loaded to the runtime from class path if java.xml.ws is not resolved. The JAX-WS runtime in JDK 9 will not be loaded in this case. If this message is specific for this scenario, t

Re: RFR: Update tables in java.base to be HTML5-friendly.

On 5/3/17 7:49 PM, Martin Buchholz wrote: w3.org doc seems to suggest we should only be defining table styles with borders. https://www.w3.org/TR/html5/tabular-data.html#attr-table-border """Tables should not be used as layout aids. """ """User agents, especially those tha

Re: RFR 8179566: Add additional jaxws messages to be translated

Hi Mandy, Alan, Would you help to correct the messages ? We need to push this file into repo before May 5th to catch the JDK9 msg drop schedule. Otherwise I have to kick off the message drop without this jaxws update. Thanks, Leo On 05/04/2017 10:24 AM, Leo Jiang wrote: === Copy from David

Re: RFR 8150681 Update JAR specification for multi-release jar files

Couple of typos on a quick review: 55: s/the the/the/ 129-130: s/the exactly/exactly the/ 144: fukes -> files? --Sean On 5/3/17 5:44 PM, Paul Sandoz wrote: Hi, Please review an update to the JAR “specification” (in the loose sense of the term): - first, it has been moved from a closed repos

Re: tutorial on using Cleaner-based finalization

Hi Rick, On 5/3/2017 10:21 PM, Rick Hillegas wrote: Thanks, Roger. That is a helpful example. Derby is a component which can be quiesced and unloaded on resource-constrained platforms, then re-loaded when resources free up. Unloading means garbage collecting all the classloaders created by th

Re: Accessing module internals from bytecode rewriting agent

On 02.05.2017 18:46, Jeremy Manson wrote: People are using Xbootclasspath for a variety of things. It's worth keeping in mind when using such options that "Non-standard options are general purpose options that are specific to the Java HotSpot Virtual Machine, so they are not guaranteed to be

Re: AppCDS in OpenJDK?

To provide a more general answer: No commercial features are available in OpenJDK. cheers, dalibor topic -- Dalibor Topic | Principal Product Manager Phone: +494089091214 | Mobile: +491737185961 ORACLE Deutschland B.V. & Co. KG | Kühnehöfe 5 | 22761 Hamburg ORACLE De