RFR 9 (doc) 8180319 : Update Serialization spec to omit obsolete serialver -show and change history

2017-05-15 Thread Roger Riggs
Please review editorial updates to the serialization spec to remove obsolete serialver -show option and the obsolete change history. Webrev: http://cr.openjdk.java.net/~rriggs/webrev-serialver-noui-8180319/ Thanks, Roger

RFR: JDK-8180202: -XXaltjvm is not working anymore on MacOSX

2017-05-15 Thread Kumar Srinivasan
Hi David, Please review simple fix for JDK-8180202, recall we hard coded "server", this is incorrect because the function CheckJvmType will determin the correct jvmtype based on jvm.cfg *or* path/jvmtype specified by -XXaltjvm. IMO all this needs to be cleaned up when jvm.cfg is removed. Thanks

RE: RFR(S): 8180195: remove jaxp testlibrary

2017-05-15 Thread Frank Yuan
Looks fine, although I am not a reviewer. Thanks Frank > -Original Message- > From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On Behalf > Of Igor Ignatyev > Subject: RFR(S): 8180195: remove jaxp testlibrary > > http://cr.openjdk.java.net/~iignatyev//8180195/webrev.00

JDK 9 doc-only RFR of 8180353: FileOutputStream documentation does not indicate properly whether files get truncated or not

2017-05-15 Thread Brian Burkhalter
Please review at your convenience. Issue: https://bugs.openjdk.java.net/browse/JDK-8180353 Patch: [1] Thanks, Brian [1] Hg diff --- a/src/java.base/share/classes/java/io/FileOutputStream.java +++ b/src/java.base/share/classes/java/io/FileOutputStream.java @@ -91,6 +91,12 @@ * If the fi

RFR(S) : 8180386: remove jdk.testlibrary.TimeLimitedRunner

2017-05-15 Thread Igor Ignatyev
http://cr.openjdk.java.net/~iignatyev//8180386/webrev.00/index.html > lines changed: 2 ins; 88 del; 6 mod; Hi all, could you please review this small fix which removes TimeLimitedRunner class from jdk testlibrary? we have two TimeLimitedRunner classes one in jdk test library and another in th

Re: RFR(S): 8180195: remove jaxp testlibrary

2017-05-15 Thread huizhe wang
+1. Thanks Frank for checking. -Joe On 5/15/2017 7:50 PM, Frank Yuan wrote: Looks fine, although I am not a reviewer. Thanks Frank -Original Message- From: core-libs-dev [mailto:core-libs-dev-boun...@openjdk.java.net] On Behalf Of Igor Ignatyev Subject: RFR(S): 8180195: remove jaxp

Re: RFR: JDK-8180202: -XXaltjvm is not working anymore on MacOSX

2017-05-15 Thread David Holmes
Hi Kumar, On 15/05/2017 9:54 AM, Kumar Srinivasan wrote: Hi David, Please review simple fix for JDK-8180202, recall we hard coded "server", this is incorrect because the function CheckJvmType will determin the correct jvmtype based on jvm.cfg *or* path/jvmtype specified by -XXaltjvm. IMO all t

Re: RFR: JDK-8180202: -XXaltjvm is not working anymore on MacOSX

2017-05-15 Thread Kumar Srinivasan
Hi David, Please review simple fix for JDK-8180202, recall we hard coded "server", this is incorrect because the function CheckJvmType will determin the correct jvmtype based on jvm.cfg *or* path/jvmtype specified by -XXaltjvm. IMO all this needs to be cleaned up when jvm.cfg is removed. So

Re: RFR: JDK-8180202: -XXaltjvm is not working anymore on MacOSX

2017-05-15 Thread David Holmes
Hi Kumar, On 16/05/2017 12:21 AM, Kumar Srinivasan wrote: Hi David, Please review simple fix for JDK-8180202, recall we hard coded "server", this is incorrect because the function CheckJvmType will determin the correct jvmtype based on jvm.cfg *or* path/jvmtype specified by -XXaltjvm. IMO al

Re: Getting a live view of environment variables (Gradle and JDK 9)

2017-05-15 Thread David Holmes
Re-sending to core-libs-dev On 13/05/2017 5:56 PM, David Holmes wrote: Hi Dalibor, On 12/05/2017 11:28 PM, dalibor topic wrote: On 11.05.2017 18:29, Cédric Champeau wrote: Unfortunately, they are not safely mutable in multi-threaded programs on many operating system/libc combination