Re: RFR(10) 8176192: Incorrect usage of Iterator in Java 8 In com.sun.jndi.ldap.EventSupport.removeNamingListener

Hi Paul, Thanks for review, please find the modified webrev. http://cr.openjdk.java.net/~vtewari/8176192/webrev0.1/index.html Thanks, Vyom On Tuesday 13 June 2017 10:47 PM, Paul Sandoz wrote: Hi Vyom, EventSupport — You can achieve the same using an Iterator over the values of the map, th

Re: Accessing module internals from bytecode rewriting agent

Hi Jeremy, adding several --patch-module and a -XX:+IgnoreUnrecognizedVMOptions to the command lines that contains -Xbootclasspath/p should work for both 8 and 9 VMs, no ? Rémi - Mail original - > De: "Jeremy Manson" > À: "dalibor topic" > Cc: "core-libs-dev" > Envoyé: Mercredi 14 Ju

Re: (10) RFR of JDK-8181912,Refactor locale related shell test test/java/io/File/MacPathTest.sh to java test

Ping. Thank you -Hamlin On 2017/6/12 16:00, Hamlin Li wrote: Would you please review the below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8181912 webrev: http://cr.openjdk.java.net/~mli/8181912/webrev.00/ Thank you -Hamlin

Re: (10) RFR of JDK-8179242, OutOfMemoryError in java/util/Arrays/ParallelPrefix.java

Hi Paul, Please check my comments inline below. On 2017/6/14 1:23, Paul Sandoz wrote: On 12 Jun 2017, at 20:37, Hamlin Li wrote: Hi Paul, Good idea. Although the downside is the test will depend on java.management and jdk.management modules, I think it's acceptable. Although to Roger’s p

Re: (10) RFR of JDK-8179242, OutOfMemoryError in java/util/Arrays/ParallelPrefix.java

Hi Roger, Runtime.maxMemory() is for the memory JVM is trying to use, e.g. if you set -Xmx128M then you get 128M. But what we try to do is to avoid running large array size test when total physical memory of system is lower than 2G, to get total physical memory I think OperatingSystemMXBean

Re: RFR 8181832: Broken link in javax/sql/rowset/spi/package-summary.html

> On Jun 13, 2017, at 4:13 PM, Lance Andersen wrote: > > http://cr.openjdk.java.net/~lancea/8181832/webrev.01/ > Looks good. Mandy

Re: RFR 8181832: Broken link in javax/sql/rowset/spi/package-summary.html

> On Jun 13, 2017, at 6:34 PM, Mandy Chung wrote: > > >> On Jun 13, 2017, at 3:17 PM, Lance Andersen >> wrote: >> >> A few more updates as there was a bit more crud to address. The webrev is >> at: >> >> http://cr.openjdk.java.net/~lancea/8181832/webrev.00/ >>

Re: RFR 8181832: Broken link in javax/sql/rowset/spi/package-summary.html

> On Jun 13, 2017, at 3:17 PM, Lance Andersen wrote: > > A few more updates as there was a bit more crud to address. The webrev is at: > > http://cr.openjdk.java.net/~lancea/8181832/webrev.00/ > 483 Java Logging All modules are in the

Re: RFR 8181832: Broken link in javax/sql/rowset/spi/package-summary.html

A few more updates as there was a bit more crud to address. The webrev is at: http://cr.openjdk.java.net/~lancea/8181832/webrev.00/ Best Lance > On Jun 9, 2017, at 9:38 AM, Lance Andersen wrote: > >> >> On Jun 9, 2017, at 9:26 AM, Alan

Re: RFR(10): 8181147: JNU_GetStringPlatformChars should have a fast path for UTF-8

On 2017-06-13 21:09, Martin Buchholz wrote: Looks good to me, although still hoping for more review from others. I expect Sherman to weigh in. :-) +if (bytes != 0) { Style: use NULL. Done. +static jstring newStringJava(JNIEnv *env, const char *str) { I expected two versions, one

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Aleks, can you please address Lance’s comments and commit the patch to JDK? —Dmitry > On 13 Jun 2017, at 20:28, Mandy Chung wrote: > > My comment can be addressed separately as a follow-up issue. I’m okay with > that. > > I suggest to get Aleks’ help to get this change in JDK 9 asap. > > M

Re: RFR(10): 8181147: JNU_GetStringPlatformChars should have a fast path for UTF-8

Looks good to me, although still hoping for more review from others. +if (bytes != 0) { Style: use NULL. +static jstring newStringJava(JNIEnv *env, const char *str) { I expected two versions, one that took a length and one that did not, as you did with newString8859_1. --- TIL that jbyte

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

My comment can be addressed separately as a follow-up issue. I’m okay with that. I suggest to get Aleks’ help to get this change in JDK 9 asap. Mandy > On Jun 13, 2017, at 11:11 AM, Lance Andersen > wrote: > > I think that is fine. You would also want to make sure that Mandy’s feedback >

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

I think that is fine. You would also want to make sure that Mandy’s feedback was addressed. Best Lance > On Jun 13, 2017, at 2:08 PM, Dmitry Kornilov > wrote: > > Roman is on vacation this week and coming back next Tuesday, May 20. If we > are in a hurry with this sync (and we are) I can a

Re: RFR: 8176508 Update JAX-WS RI integration to latest version

Roman is on vacation this week and coming back next Tuesday, May 20. If we are in a hurry with this sync (and we are) I can ask Aleks Efimov to make these changes and commit it to JDK. —Dmitry > On 13 Jun 2017, at 01:24, Lance Andersen wrote: > > Hi Roman, > > Overall looks OK. > > A coupl

Re: (10) RFR of JDK-8179242, OutOfMemoryError in java/util/Arrays/ParallelPrefix.java

> On 12 Jun 2017, at 20:37, Hamlin Li wrote: > > Hi Paul, > > Good idea. Although the downside is the test will depend on java.management > and jdk.management modules, I think it's acceptable. > Although to Roger’s point is there a simpler way? > Also disable to run ParallelPrefix.java in

Re: RFR(10) 8176192: Incorrect usage of Iterator in Java 8 In com.sun.jndi.ldap.EventSupport.removeNamingListener

Hi Vyom, EventSupport — You can achieve the same using an Iterator over the values of the map, thereby simplifying the code. RemoveNamingListenerTest — 50 private static Exception exception; This should be marked volatile. Paul. > On 13 Jun 2017, at 01:30, Vyom Tewari wrote: > > H

Re: RFR(10): 8181147: JNU_GetStringPlatformChars should have a fast path for UTF-8

http://mail.openjdk.java.net/pipermail/core-libs-dev/2017-June/048233.html for missing context> Updated webrevs: http://cr.openjdk.java.net/~redestad/8181147/jdk.05/ http://cr.openjdk.java.net/~redestad/8181147/top.04/ In this version there are various cleanups based on Martin's comments, impro

Re: (10) RFR of JDK-8179242, OutOfMemoryError in java/util/Arrays/ParallelPrefix.java

Hi Hamlin, For max memory is Runtime.maxMemory insufficient? Thanks, Roger On 6/12/2017 11:37 PM, Hamlin Li wrote: Hi Paul, Good idea. Although the downside is the test will depend on java.management and jdk.management modules, I think it's acceptable. Also disable to run ParallelPrefix.ja

Re: RFR 8181104 Fix specs for updateAndGet and related methods

> On 13 Jun 2017, at 02:49, Paul Sandoz wrote: > > Hi, > > http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8181104-updateAndGet-atomicty-ordering/webrev/index.html Looks fine Paul. -Chris.

RFR(10) 8176192: Incorrect usage of Iterator in Java 8 In com.sun.jndi.ldap.EventSupport.removeNamingListener

Hi All, Please find the code change for below issue. BugId : https://bugs.openjdk.java.net/browse/JDK-8176192 Webrev : http://cr.openjdk.java.net/~vtewari/8176192/webrev0.0/index.html If the hashtable is structurally modified while enumerating over the values then the results of enumer