JDK 10 RFR of JDK-8181575: Refactor locale related shell test java/nio/charset/spi/basic.sh to java

2017-06-18 Thread Amy Lu
java/nio/charset/spi/basic.sh Please review this patch to refactor the shell test to java. bug: https://bugs.openjdk.java.net/browse/JDK-8181575 webrev: http://cr.openjdk.java.net/~amlu/8181575/webrev.00/ Thanks, Amy

JDK 10 RFR of JDK-8182421: Add @modules to java/nio/charset/coders/SJISMappingPropTest.java

2017-06-18 Thread Amy Lu
java/nio/charset/coders/SJISMappingPropTest.java I forgot to add module dependency when converting this test to java version. Please review the patch to add @modules jdk.charsets Thanks, Amy --- a/test/java/nio/charset/coders/SJISMappingPropTest.java +++ b/test/java/nio/charset/coders/SJISMap

Re: (10) RFR of JDK-8181478, Refactor java/io shell tests to plain java tests

2017-06-18 Thread Hamlin Li
On 2017/6/17 1:31, Paul Sandoz wrote: On 14 Jun 2017, at 23:29, Hamlin Li wrote: Hi Alan, Paul, Thank you for review, new webrev at: http://cr.openjdk.java.net/~mli/8181478/webrev.01/ Please also check my comments inline. On 2017/6/15 1:28, Alan Bateman wrote: On 14/06/2017 18:20, Paul