RFR(S) : 8182565 : remove jdk.testlibrary.Utils::tryFindJvmPid and waitForJvmPid methods

http://cr.openjdk.java.net/~iignatyev//8182565/webrev.00/index.html > 57 lines changed: 0 ins; 57 del; 0 mod; Hi all, could you please review this small patch which removes two unused methods from jdk.testlibrary.Utils class? webrev:

Re: JDK 10 RFR of JDK-8181575: Refactor locale related shell test java/nio/charset/spi/basic.sh to java

Minor stuff below, no need for another round from me. Paul. CharsetProviderBasicTest — 85 public static Iterator testCases() { 86 List cases = new ArrayList<>(); 87 Stream.of("", "ja_JP.eucJP", "tr_TR") 88 .forEach(locale -> { 89

Re: Accessing module internals from bytecode rewriting agent

On 15 June 2017 at 21:31, Jeremy Manson wrote: > My initial thought in this general direction was to write a JVMTI agent > that takes a list of JAR files as arguments. It then does two things: > > - Intercepts all loads of classes using the ClassFileLoadHook, checks to >

Re: (10) RFR of JDK-8181478, Refactor java/io shell tests to plain java tests

> On 18 Jun 2017, at 19:47, Hamlin Li wrote: > > > > On 2017/6/17 1:31, Paul Sandoz wrote: >>> On 14 Jun 2017, at 23:29, Hamlin Li wrote: >>> >>> Hi Alan, Paul, >>> >>> Thank you for review, new webrev at: >>>

JDK-8181769: Introduce interface with type-safe equals

Hello, Recently noticed that RFE JDK-8181769 (Introduce interface with type-safe equals) is closed as duplicate of some other RFE. However I think these RFEs are unrelated. The idea behind JDK-8181769 is NOT to supply custom equality functions to collections, but to provide means to enforce

Re: JDK 10 RFR of JDK-8182421: Add @modules to java/nio/charset/coders/SJISMappingPropTest.java

On 19/06/2017 04:58, Amy Lu wrote: java/nio/charset/coders/SJISMappingPropTest.java I forgot to add module dependency when converting this test to java version. Please review the patch to add @modules jdk.charsets Looks good.

JDK 10 RFR of JDK-8181575: Refactor locale related shell test java/nio/charset/spi/basic.sh to java

java/nio/charset/spi/basic.sh Please review this patch to refactor the shell test to java. bug: https://bugs.openjdk.java.net/browse/JDK-8181575 webrev: http://cr.openjdk.java.net/~amlu/8181575/webrev.00/ Thanks, Amy