On 7/7/17 5:50 PM, huizhe wang wrote:
Hi Jon,
For the table in CatalogFeatures, the id attribute for Type and Value
are not used, may be unnecessary. Instead, scope="col" can be added,
is that right?
50 * Type
51 * Value
I'm new to accessibility, but it seems to me the following can use
s
Here's the updated webrev:
http://cr.openjdk.java.net/~joehw/jdk10/8181154/webrev01/
Thanks,
Joe
On 7/7/2017 10:59 AM, huizhe wang wrote:
#11
com/sun/org/apache/xerces/internal/jaxp/datatype/XMLGregorianCalendarImpl.java
1166 final public void setYear(BigInteger year) {
nit: for cons
Hi Jon,
For the table in CatalogFeatures, the id attribute for Type and Value
are not used, may be unnecessary. Instead, scope="col" can be added, is
that right?
50 * Type
51 * Value
I'm new to accessibility, but it seems to me the following can use
scope="colgroup" instead?
46 * Value [
Sorry, I meant to include that; will post shortly, beside the webrev.
-- Jon
On 07/07/2017 01:33 PM, Lance Andersen wrote:
Hi Jon,
The changes looked good to me. Is the html available by chance to do
an extra sanity check?
Best
Lance
On Jul 7, 2017, at 2:14 PM, Jonathan Gibbons
mailto:jo
Hi Jon,
The changes looked good to me. Is the html available by chance to do an extra
sanity check?
Best
Lance
> On Jul 7, 2017, at 2:14 PM, Jonathan Gibbons
> wrote:
>
> Please review the following fixes to the doc comments in the jaxp repo.
>
> The primary goal is to fix user-written tab
Please review the following fixes to the doc comments in the jaxp repo.
The primary goal is to fix user-written tables in doc comments for
accessibility, either by updating tables to use scope=row|col in header
cells for simple tables, or by using the headings attribute in more
complex tables.
#11
com/sun/org/apache/xerces/internal/jaxp/datatype/XMLGregorianCalendarImpl.java
1166 final public void setYear(BigInteger year) {
nit: for consistency you should reorder the keywords to:
public final void
same file:
- BigInteger.valueOf((long) 1) => BigInteger.ONE
- new
+1
Paul.
> On 6 Jul 2017, at 20:11, Amy Lu wrote:
>
> java/nio/channels/DatagramChannel/Disconnect.java
>
> This test is known to fail intermittently (JDK-8154018), this patch is to
> mark the test accordingly with keyword 'intermittent'.
>
> Please review.
>
> bug: https://bugs.openjdk.java
Hi all,
Any comment on downporting a fix to JDK9u and JDK8u, which simply removes
volatile?
Regards,
Ogata
Kazunori Ogata/Japan/IBM wrote on 2017/07/03 17:28:54:
> From: Kazunori Ogata/Japan/IBM
> To: "Langer, Christoph"
> Cc: core-libs-dev , "nio-
> d...@openjdk.java.net"
> Date: 2017/07/0
Further testing has shown the escaping to be necessary. Apologies folks,
I'm withdrawing this review.
-Rob
On 06/07/17 04:57, Rob McKenna wrote:
> Thanks Vyom, updated test at:
>
> http://cr.openjdk.java.net/~robm/8177806/webrev.02/
>
> The sleep proved necessary in a similar earlier test s
10 matches
Mail list logo
