Re: [9] RFR 8184119 Incorrect return processing for the LF editor of MethodHandles.permuteArguments

Looks good. Best regards, Vladimir Ivanov On 7/11/17 7:04 AM, Paul Sandoz wrote: Hi, Please review this small fix to MethodHandle.permuteArguments that causes a VM crash: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8184119-permute-args-return-an-arg/webrev/

Re: [9] RFR 8184119 Incorrect return processing for the LF editor of MethodHandles.permuteArguments

On Jul 10, 2017, at 9:04 PM, Paul Sandoz wrote: > > Please review this small fix to MethodHandle.permuteArguments that causes a > VM crash: > > > http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8184119-permute-args-return-an-arg/webrev/ > >

[9] RFR 8184119 Incorrect return processing for the LF editor of MethodHandles.permuteArguments

Hi, Please review this small fix to MethodHandle.permuteArguments that causes a VM crash: http://cr.openjdk.java.net/~psandoz/jdk9/JDK-8184119-permute-args-return-an-arg/webrev/ https://bugs.openjdk.

Re: (10/jaxp) RFR of JDK-8184062: wrong @modules javax.xml at jaxp/test/javax/xml/jaxp/unittest/stream/XMLStreamWriterTest/SurrogatesTest.java

Hi Lance, Amy, As you suggested, deleted @modules and redundant @test in SurrogatesTest.java, the change is pushed. Thank you -Hamlin On 2017/7/10 20:20, Lance Andersen wrote: Hi Hamilin On Jul 10, 2017, at 5:59 AM, Amy Lu > wrote: I noticed the module dependen

Re: RFR: 8184021: Fix tables in jaxp doc comments to be accessible

Thanks. I see the ERROR. I'm not sure of the reasoning why your fix works: maybe because the data cell is empty, it doesn't need headers. I'll do more experiments! Anyway, I'm happy to go with the suggested fix. -- Jon On 07/10/2017 05:40 PM, huizhe wang wrote: That looks great! Almost a

Re: RFR: 8184021: Fix tables in jaxp doc comments to be accessible

That looks great! Almost all "green"! The only exception is the table in javax/xml/validation/Validator.java where the empty cell resulted in a reported "ERROR". I tried changing to and saw that the tool happily accepted it: - 138 * + 138 * If you decide to adopt the above

Re: RFR: 8184021: Fix tables in jaxp doc comments to be accessible

Here is the amended webrev for the work on fixing the tables (and other nits) in the jaxp docs. As we discussed, I changed the two manually edited tables, in CatalogFeatures and XMLStreamWriter, to use scope=row/col. There are now no tables in the jaxp repo using headers to identify row and c

Binding on established (pipe endpoint) ports on Windows

Hello, I had the problem in a project that having a number of Pipe Objects (from the default Windows Selector Provider) produced a range of used TCP ports. This is somewhat expected (if you accept the fact it uses Sockets for this): > netstat -nao | findstr 5600 TCP127.0.0.1:5106712

Re: Is there any reason why the MacOS X port doesn't provide a UserDefinedFileAttributeView?

On Jul 3, 2017, at 1:05 PM, Alan Bateman wrote: > On 03/07/2017 20:39, Simon Spero wrote: >> It seems like it ought be relatively simple to add, since the API is not >> too far off of Linux (with NO_FOLLOW as an option to syscall rather than a >> separate entry point). >> > This has been discus

Re: RFR (JDK10/jaxp) 8181154: Fix lint warnings in JAXP repo: deprecation

Hi Lance, Daniel, I pushed the changeset after adding 'final' to the following, and then logged this issue [1] for investigating the deprecated method. [1] https://bugs.openjdk.java.net/browse/JDK-8184103 Thanks again for the reviews! Joe On 7/10/2017 7:56 AM, Lance Andersen wrote: On Jul

Re: RFR: 8184021: Fix tables in jaxp doc comments to be accessible

Jon, Glad to know that works out. Hopefully this exercise with the jaxp repo can be a bit helpful to your effort and utility. Thanks for using the jaxp repo for this exercise! Best, Joe On 7/8/2017 9:58 AM, Jonathan Gibbons wrote: Joe, Thanks for the feedback. I've done some experiments

Re: RFR (JDK10/jaxp) 8181154: Fix lint warnings in JAXP repo: deprecation

> On Jul 10, 2017, at 6:10 AM, Daniel Fuchs wrote: > > Hi Joe, > > Looks good to me. I have two additional comments, one nit - and > one for some later follow-up - so no need for a new webrev. > > > 1. Nit: I think it should be final as well: > > +++ > new/src/java.xml/share/classes/com/sun

Re: (10/jaxp) RFR of JDK-8184062: wrong @modules javax.xml at jaxp/test/javax/xml/jaxp/unittest/stream/XMLStreamWriterTest/SurrogatesTest.java

Hi Hamilin > On Jul 10, 2017, at 5:59 AM, Amy Lu wrote: > > I noticed the module dependency is declared at > test/javax/xml/jaxp/unittest/TEST.properties > So @modules in this test file can just be deleted. > Agree and on a quick scan this is the only test in that directory which includes @m

Re: RFR (JDK10/jaxp) 8181154: Fix lint warnings in JAXP repo: deprecation

Hi Joe, Looks good to me. I have two additional comments, one nit - and one for some later follow-up - so no need for a new webrev. 1. Nit: I think it should be final as well: +++ new/src/java.xml/share/classes/com/sun/org/apache/xml/internal/serializer/OutputPropertiesFactory.java 2017-07-0

Re: (10/jaxp) RFR of JDK-8184062: wrong @modules javax.xml at jaxp/test/javax/xml/jaxp/unittest/stream/XMLStreamWriterTest/SurrogatesTest.java

I noticed the module dependency is declared at test/javax/xml/jaxp/unittest/TEST.properties So @modules in this test file can just be deleted. Moreover, just noticed there are two @test which should be cleaned up. ( Not a reviewer.) Thanks, Amy On 7/10/17 5:17 PM, Hamlin Li wrote: Would you

(10/jaxp) RFR of JDK-8184062: wrong @modules javax.xml at jaxp/test/javax/xml/jaxp/unittest/stream/XMLStreamWriterTest/SurrogatesTest.java

Would you please review below patch? bug: https://bugs.openjdk.java.net/browse/JDK-8184062 webrev: http://cr.openjdk.java.net/~mli/8184062/webrev.00/, also attach diff as below Thank you -Hamlin diff -r 18b09cba334b