Re: RFR 10: 8184808 (process) isAlive should use pid for validity, not /proc/pid

2017-07-18 Thread Felix Yang
Hi Roger, is it necessary to add the bug id to OnExitTest? -Felix On 2017/7/19 2:46, Roger Riggs wrote: Please review a fix for an intermittent failure in the ProcessHandle OnExitTest that fails frequently on Solaris. ProcessHandle.isAlive is using /proc/pid/psinfo to determine if a pro

[10] RFR (XS) 8183902: Remove unnecessary definitions in locale_str.h for macOS

2017-07-18 Thread Naoto Sato
Hello, Please review this small fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8183902 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8183902/webrev.00/ This is a leftover fix to 8160199. With the fix to 8160199, there is no need to supplement the lan

Re: RFR 10: 8184808 (process) isAlive should use pid for validity, not /proc/pid

2017-07-18 Thread Roger Riggs
Hi Thomas, Yes, if there is no access to the pid, then it can't report alive or not, and assume not. If there access restrictions it will apply to the waitid/waitpid in the waitForProcessExit0 logic also and the answer will be at least consistent (and avoid a possible race between //proc/pid/

Re: RFR 10: 8184808 (process) isAlive should use pid for validity, not /proc/pid

2017-07-18 Thread Thomas Stüfe
Hi Roger, I think this may fail if you have no permission to send a signal to that process. In that case, kill(2) may yield EPERM and isAlive may return false even though the process is alive. But then, I am not sure if that could happen in that particular scenario, plus it may also mean that you

RFR 10: 8184808 (process) isAlive should use pid for validity, not /proc/pid

2017-07-18 Thread Roger Riggs
Please review a fix for an intermittent failure in the ProcessHandle OnExitTest that fails frequently on Solaris. ProcessHandle.isAlive is using /proc/pid/psinfo to determine if a process is alive and it's start time. However, it appears that the between the process exiting and the reaping of

Re: RFR 8177357: tools/jar/multiRelease/ApiValidatorTest.java failed due to "Exception java.nio.file.DirectoryNotEmptyException"

2017-07-18 Thread Paul Sandoz
> On 17 Jul 2017, at 16:51, Andrey Nazarov wrote: > > Hi, > > Could you review simple test fix? > > http://cr.openjdk.java.net/~anazarov/JDK-8177357/webrev.00/webrev > > JBS: https://bugs.openjdk.java.net/browse/JDK-8177357 > Looks ok. (It bothers me that deletion of a directory is so fragi

Re: RFR: jsr166 jdk10 integration wave 1

2017-07-18 Thread Martin Buchholz
After a long delay, we are finally ready to try again to get in jsr166 jdk10 integration wave 1. The set of changes has grown a lot over the past few months (too much?), and contains the usual hard-to-review tck test improvements. Our infrastructure for generating these commits has changed a lot

Re: [10] RFR: 8184665: Skip name and alias checks for standard Charsets

2017-07-18 Thread Claes Redestad
On 07/18/2017 04:59 PM, Xueming Shen wrote: +1 Thanks! * the test needs a bugid before pushing. Will do. /Claes

Re: [10] RFR: 8184665: Skip name and alias checks for standard Charsets

2017-07-18 Thread Xueming Shen
+1 * the test needs a bugid before pushing. On 7/18/17, 7:16 AM, Claes Redestad wrote: Hi Sherman, On 07/14/2017 07:42 PM, Xueming Shen wrote: Hi Claes, The change looks fine. The only concern is that, in theory, it appears we no longer have any "check" to guarantee that all "alias" names

Re: [10] RFR: 8184665: Skip name and alias checks for standard Charsets

2017-07-18 Thread Claes Redestad
Hi Sherman, On 07/14/2017 07:42 PM, Xueming Shen wrote: Hi Claes, The change looks fine. The only concern is that, in theory, it appears we no longer have any "check" to guarantee that all "alias" names defined for these 3 charsets indeed follow the spec? The consequence of this is that some

RE: JEP [DRAFT]: Container aware Java

2017-07-18 Thread Baesken, Matthias
Hi Bob, VMWare has the option to install additional tools, in case they are installed you get a number of metrics from the guests. Some info can be found here : https://www.vmware.com/support/developer/guest-sdk/ Running in the guests you would load libvmGuestLib.so / vmGuestLib.dll

Re: JEP [DRAFT]: Container aware Java

2017-07-18 Thread Bob Vandette
> On Jul 17, 2017, at 11:55 AM, Volker Simonis wrote: > > On Fri, Jul 14, 2017 at 6:54 PM, Bob Vandette wrote: >> >>> On Jul 14, 2017, at 12:15 PM, Volker Simonis >>> wrote: >>> >>> Hi Bob, >>> >>> thanks for starting this JEP. I think it is long overdue and will be >>> very helpful for ma