Re: RFR 8184904/10, jdk/internal/jrtfs/WithSecurityManager fails with exploded builds

Hi Alan, if I understand correctly, you meant that just to check for ${java.home}/lib/modules is enough? Please review the updated patch. I also adjusted checking in Basic.java, which also has duplicate checking and is problematic (jrt-fs.jar is no longer under JDK root directory) Webr

RFR 8184961: jdk.test.lib.util.FileUtils.deleteFileWithRetry0 should wait for absence of a file

Hi, Could you review fix in test library which should help to resolve intermittent issues on Windows machines during directories clean up. Bug: https://bugs.openjdk.java.net/browse/JDK-8184961 Review: http://cr.openjdk.java.net/~anazarov/JDK

Re: RFR 8177357: tools/jar/multiRelease/ApiValidatorTest.java failed due to "Exception java.nio.file.DirectoryNotEmptyException"

> On 18 Jul 2017, at 11:38, Paul Sandoz wrote: > > >> On 17 Jul 2017, at 16:51, Andrey Nazarov wrote: >> >> Hi, >> >> Could you review simple test fix? >> >> http://cr.openjdk.java.net/~anazarov/JDK-8177357/webrev.00/webrev >> >> JBS: https://bugs.openjdk.java.net/browse/JDK-8177357 >> >

Re: [10] RFR (XS) 8183902: Remove unnecessary definitions in locale_str.h for macOS

Hi Naoto, The update looks fine. Roger On 7/18/2017 6:23 PM, Naoto Sato wrote: Hello, Please review this small fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8183902 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8183902/webrev.00/ This is a lefto

Re: RFR 10: 8184808 (process) isAlive should use pid for validity, not /proc/pid

Hi Felix, OnExitTest is unchanged and was the test the discovered the bug; so I don't think it needs a @bug. Thanks, Roger On 7/19/2017 12:27 AM, Felix Yang wrote: Hi Roger, is it necessary to add the bug id to OnExitTest? -Felix On 2017/7/19 2:46, Roger Riggs wrote: Please review a

Re: [10] RFR (XS) 8183902: Remove unnecessary definitions in locale_str.h for macOS

The fix looks good, Naoto. Thanks, -Brent On 7/18/17 3:23 PM, Naoto Sato wrote: Hello, Please review this small fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8183902 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/8183902/webrev.00/ This is a leftov

Re: JDK 9 rejects zip files where the modified day or month is 0 (JDK-8184940)

I support this change and commented on the bug. Too late for jdk9, but should go into a jdk9 update. On Wed, Jul 19, 2017 at 11:29 AM, Liam Miller-Cushon wrote: > Hello, > > While testing JDK 9 we noticed that zip archives containing zeroed-out > dates are no longer accepted. These archives are

Re: 8184917: System.initPhase1 does not need to pre-load libzip

Hi Alan, this looks good to me! /Claes On 2017-07-19 15:47, Alan Bateman wrote: System.initPhase1 (formerly initializeSystemClasses) currently pre-loads the zip library. I'd like to drop this in jdk10/jdk10 so that it is loaded lazily and so reduce the code executed in this phase of startu

Re: [10] RFR: 8184603: Create ObjectStreamField signature lazily when possible

Hi, On 7/19/2017 5:49 AM, Peter Levart wrote: Hi Claes, On 07/17/2017 02:16 PM, Claes Redestad wrote: Hi Peter! On 2017-07-15 14:08, Peter Levart wrote: It seems that interning signature(s) is important for correctness (for example, in ObjectOutputStream.writeTypeString(str) the 'str' is

8184917: System.initPhase1 does not need to pre-load libzip

System.initPhase1 (formerly initializeSystemClasses) currently pre-loads the zip library. I'd like to drop this in jdk10/jdk10 so that it is loaded lazily and so reduce the code executed in this phase of startup. One motivation is that the zip code no longer uses native methods in libzip to a

Re: [10] RFR: 8184603: Create ObjectStreamField signature lazily when possible

Hi Claes, On 07/17/2017 02:16 PM, Claes Redestad wrote: Hi Peter! On 2017-07-15 14:08, Peter Levart wrote: It seems that interning signature(s) is important for correctness (for example, in ObjectOutputStream.writeTypeString(str) the 'str' is used to lookup a handle so that handles are put

Re: RFR 8184904/10, jdk/internal/jrtfs/WithSecurityManager fails with exploded builds

On 19/07/2017 10:43, Felix Yang wrote: Hi all, please review a patch to skip parts of testing with exploded builds. Bug: https://bugs.openjdk.java.net/browse/JDK-8184904 Webrev: http://cr.openjdk.java.net/~xiaofeya/8184904/webrev.00/ The check for the image type should be indepen

RFR 8184904/10, jdk/internal/jrtfs/WithSecurityManager fails with exploded builds

Hi all, please review a patch to skip parts of testing with exploded builds. Bug: https://bugs.openjdk.java.net/browse/JDK-8184904 Webrev: http://cr.openjdk.java.net/~xiaofeya/8184904/webrev.00/ Thanks, Felix

[10] RFR 8134512 : provide Alpha-Numeric (logical) Comparator

Hello! It is a proposal to provide a String comparator, which will pay attention to the numbers embedded into the strings (should they present). This proposal was initially discussed back in 2014 and seemed to bring some interest from the community: http://mail.openjdk.java.net/pipermail/cor

Re: RFR 10: 8184808 (process) isAlive should use pid for validity, not /proc/pid

Hi Roger, On Tue, Jul 18, 2017 at 9:01 PM, Roger Riggs wrote: > Hi Thomas, > > Yes, if there is no access to the pid, then it can't report alive or not, > and assume not. > If there access restrictions it will apply to the waitid/waitpid in the > waitForProcessExit0 > logic also and the answer w