Re: RFR 10: 8184808 (process) isAlive should use pid for validity, not /proc/pid

2017-07-20 Thread Thomas Stüfe
Hi Roger, On Thu, Jul 20, 2017 at 4:25 PM, Roger Riggs wrote: > Hi Thomas, > > Thanks for the investigation and links. > The variations, across os's, in the status of exited vs reaped (zombie) > process have been a > problem for quite a while (for portable apps). > > The description of waitpid i

RFR: JDK-8183579: refactor and cleanup launcher help messages

2017-07-20 Thread Kumar Srinivasan
Hi, Please review refactoring and clean up of the java launcher's help/usage messages. The highlights of the changes are as follows: 1. Helper.java: is renamed from LauncherHelper.java, simpler name, containing mostly methods to help with class loading, module assistance etc. 2. OptionHe

Re: RFR 10: 8184808 (process) isAlive should use pid for validity, not /proc/pid

2017-07-20 Thread Roger Riggs
Hi Thomas, Thanks for the investigation and links. The variations, across os's, in the status of exited vs reaped (zombie) process have been a problem for quite a while (for portable apps). The description of waitpid is focused heavily on child processes; this a particular case is dealing wit

Re: RFR 8184904/10, jdk/internal/jrtfs/WithSecurityManager fails with exploded builds

2017-07-20 Thread Felix Yang
Hi Alan, pushed as suggested. Thanks, Felix > On 20 Jul 2017, at 7:23 PM, Alan Bateman wrote: > > This skips the testing on exploded builds, which I think is okay. A minor > point before pushing is that you replace "lib/modules" with "lib", "modules" > as the elements will be joined by the

Re: RFR 8184904/10, jdk/internal/jrtfs/WithSecurityManager fails with exploded builds

2017-07-20 Thread Alan Bateman
On 20/07/2017 04:22, Felix Yang wrote: Hi Alan, if I understand correctly, you meant that just to check for ${java.home}/lib/modules is enough? Please review the updated patch. I also adjusted checking in Basic.java, which also has duplicate checking and is problematic (jrt-fs.jar is