Re: [10] RFR(M) 8182701: Modify JVMCI to allow Graal Compiler to expose platform MBean

2017-07-24 Thread Mandy Chung
Vladimir, I believe you don’t want to add the dependency from JVMCI to java.management. Otherwise, JVMCI can’t run with only java.base. Is the MBean in jdk.internal.vm.compiler or in Lab’s Graal compiler? src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/services/src/jdk/vm/ci/services/internal/

Re: RFR: JDK-8184217: Redundant tag before list

2017-07-24 Thread Lance Andersen
+1 > On Jul 24, 2017, at 4:44 PM, Jonathan Gibbons > wrote: > > Please review a small fix to the documentation for the java.rmi module. > > No webrev; here is the patch to remove an unnecessary line: > > $ hg diff -R jdk > diff -r 13119f57b8da src/java.rmi/share/classes/module-info.java > ---

RFR: JDK-8184217: Redundant tag before list

2017-07-24 Thread Jonathan Gibbons
Please review a small fix to the documentation for the java.rmi module. No webrev; here is the patch to remove an unnecessary line: $ hg diff -R jdk diff -r 13119f57b8da src/java.rmi/share/classes/module-info.java --- a/src/java.rmi/share/classes/module-info.javaMon Jul 24 10:18:33 2017 -04

Re: RFR: 8185150: javax/activation/CommandInfo.html has empty

2017-07-24 Thread Jonathan Gibbons
Thanks, Lance. -- Jon On 07/24/2017 01:16 PM, Lance Andersen wrote: +1 On Jul 24, 2017, at 4:07 PM, Jonathan Gibbons mailto:jonathan.gibb...@oracle.com>> wrote: Please review a trivial fix to remove a superfluous in a javadoc comment. No webrev; here is the patch: $ hg diff -R jaxws dif

Re: RFR: 8185150: javax/activation/CommandInfo.html has empty

2017-07-24 Thread Lance Andersen
+1 > On Jul 24, 2017, at 4:07 PM, Jonathan Gibbons > wrote: > > Please review a trivial fix to remove a superfluous in a javadoc comment. > > No webrev; here is the patch: > > $ hg diff -R jaxws > diff -r 97e67df03f88 > src/java.activation/share/classes/javax/activation/CommandInfo.java > --

RFR: 8185150: javax/activation/CommandInfo.html has empty

2017-07-24 Thread Jonathan Gibbons
Please review a trivial fix to remove a superfluous in a javadoc comment. No webrev; here is the patch: $ hg diff -R jaxws diff -r 97e67df03f88 src/java.activation/share/classes/javax/activation/CommandInfo.java --- a/src/java.activation/share/classes/javax/activation/CommandInfo.java Thu J

Re: JDK 10 RFR of JDK-8183377: Refactor java/lang/ClassLoader/deadlock shell tests to java

2017-07-24 Thread Mandy Chung
> On Jul 17, 2017, at 12:49 AM, Amy Lu wrote: > > On 7/14/17 4:41 PM, Mandy Chung wrote: >> I think compiling the other classes to a destination explicitly to replace: >> 29 * @build Alice Bob SupAlice SupBob >> 30 * @run driver SetupLoader >> >> will make the test clearer. It’d be good

Re: [10] RFR 8134512 : provide Alpha-Numeric (logical) Comparator

2017-07-24 Thread Roger Riggs
Hi Ivan, Thanks for bringing this up again. Some initial comments, not a full review. Though the enhancement says that no consideration is given to sign characters they may produce puzzling results for strings like "-2000" and "-2001" where the strings appear to be signed numbers but the comp

Re: [10] RFR 8134512 : provide Alpha-Numeric (logical) Comparator

2017-07-24 Thread Jonathan Bluett-Duncan
You're welcome Ivan! I'm just proofreading the new webrev, and a few more things have occurred to me: 1. What happens if the comparators are given the elements {"1abc", "2abc", "10abc"} to compare? Would they sort the elements as {"1abc", "2abc", "10abc"} or as {"1abc", "10abc", "2abc"}? What abo

Re: [10] RFR: 8185104: Generate CharacterDataLatin1 lookup tables directly

2017-07-24 Thread Claes Redestad
On 07/24/2017 10:29 AM, Alan Bateman wrote: On 23/07/2017 14:37, Claes Redestad wrote: Proposed patch is to drop passing -string to GenerateCharacter for the latin1 case: Webrev: http://cr.openjdk.java.net/~redestad/8185104/jdk.00/ Bug:https://bugs.openjdk.java.net/browse/JDK-8185104 Thi

Re: [10] RFR: 8185104: Generate CharacterDataLatin1 lookup tables directly

2017-07-24 Thread Alan Bateman
On 23/07/2017 14:37, Claes Redestad wrote: Hi, java.lang.CharacterDataLatin1 and others are generated at build time by the GenerateCharacter tool, which has a -string mode to generate lookup tables as Strings literals rather than arrays directly. This serves multiple purposes: 1. it reduc