Re: RFR: JDK-8185758: jdk.smartcardio has broken docs for exceptions

> On Aug 2, 2017, at 4:21 PM, Jonathan Gibbons > wrote: > > (I'm not sure if there is a better list for this request, but the request is > so simple, I'm hoping it will be sufficient. > > Please review this very simple fix to replace two uses of ... > with {@code...}. > > The underlying pro

Re: RFR: JDK-8185758: jdk.smartcardio has broken docs for exceptions

The change looks good! With kind regards, Ivan On 8/2/17 4:21 PM, Jonathan Gibbons wrote: (I'm not sure if there is a better list for this request, but the request is so simple, I'm hoping it will be sufficient. Please review this very simple fix to replace two uses of ... with {@code...}.

RFR: JDK-8185758: jdk.smartcardio has broken docs for exceptions

(I'm not sure if there is a better list for this request, but the request is so simple, I'm hoping it will be sufficient. Please review this very simple fix to replace two uses of ... with {@code...}. The underlying problem being fixed is incorrect handling of the first sentence in a couple

Re: [10] RFR 8185754 : Typo in java.util.regex.Pattern javadoc: no slash in \p class

Thanks! Pushed. On 8/2/17 4:00 PM, Brian Burkhalter wrote: Hi Ivan, These look fine. Brian On Aug 2, 2017, at 3:36 PM, Ivan Gerasimov > wrote: Would you please help review the fix? --- a/src/java.base/share/classes/java/util/regex/Pattern.java +++ b/src

Re: [10] RFR 8185754 : Typo in java.util.regex.Pattern javadoc: no slash in \p class

Hi Ivan, These look fine. Brian On Aug 2, 2017, at 3:36 PM, Ivan Gerasimov wrote: > Would you please help review the fix? > > --- a/src/java.base/share/classes/java/util/regex/Pattern.java > +++ b/src/java.base/share/classes/java/util/regex/Pattern.java > @@ -667,11 +667,11 @@ > […] > - *

[10] RFR 8185754 : Typo in java.util.regex.Pattern javadoc: no slash in \p class

Hello! A couple of typos was spotted in the javadoc. Would you please help review the fix? diff --git a/src/java.base/share/classes/java/util/regex/Pattern.java b/src/java.base/share/classes/java/util/regex/Pattern.java --- a/src/java.base/share/classes/java/util/regex/Pattern.java +++ b/src/

Re: RFR 8185719 [testlibrary] : RMI TestSocketFactory does not flush

Hi Daniel, Yep, it does not try/need to handle the case where a prefix of the match appears within the match. When a mismatch is detected, it starts fresh for a match. Someday, it may need an upgrade, but for now its sufficient. Thanks, Roger On 8/2/2017 11:43 AM, Daniel Fuchs wrote: Hi Ro

Re: RFR 8185719 [testlibrary] : RMI TestSocketFactory does not flush

Hi Roger, On 02/08/2017 16:32, Roger Riggs wrote: Hi Daniel, I considered keeping track of the partial match across the flush, but it could only work if the partial match was a prefix of the replacement string. It got complicated quickly. Since this is used (only) for RMI, in which flushe

Re: RFR 8185719 [testlibrary] : RMI TestSocketFactory does not flush

Hi Daniel, I considered keeping track of the partial match across the flush, but it could only work if the partial match was a prefix of the replacement string. It got complicated quickly. Since this is used (only) for RMI, in which flushes are used at the end of messages, it seemed suffic

Re: RFR 8185719 [testlibrary] : RMI TestSocketFactory does not flush

Hi Roger, I wonder if the MatchReplaceOutputStream should store the partial match index at the time the partial bytes are flushed in order to verify that this was indeed a partial match, and report an error if it later finds that flush() was indeed called during a full match? The potential Error

Re: RFR 8185719 [testlibrary] : RMI TestSocketFactory does not flush

Hi Roger, the changes seem reasonable. Best Lance > On Aug 2, 2017, at 10:21 AM, Roger Riggs wrote: > > Please review a correction in the RMI TestSocketFactory > MatchReplaceOutputStream to correctly flush > partial matches. It can cause hangs when the one or more bytes before a > flush are

Re: [10] RFR(M) 8182701: Modify JVMCI to allow Graal Compiler to expose platform MBean

> On Aug 2, 2017, at 7:08 AM, Jaroslav Tulach > wrote: > >> This is Graal-specific MBean. It doesn’t seem that it must be registered as >> “platform mbean” which has to implement PlatformManagedObject. >> >> Graal can register the MBean at runtime when java.management is present by >> calling

RFR 8185719 [testlibrary] : RMI TestSocketFactory does not flush

Please review a correction in the RMI TestSocketFactory MatchReplaceOutputStream to correctly flush partial matches. It can cause hangs when the one or more bytes before a flush are a partial match for the pattern and the consumer is waiting for the pending bytes. Webrev: http://cr.openjdk.j

Re: [10] RFR(M) 8182701: Modify JVMCI to allow Graal Compiler to expose platform MBean

> This is Graal-specific MBean. It doesn’t seem that it must be registered as > “platform mbean” which has to implement PlatformManagedObject. > > Graal can register the MBean at runtime when java.management is present by > calling ManagementFactory.getPlatformMBeanServer().registerMBean method.

Re: Review Request: JDK-8185541: Add back test cases for resource lookup from bootclasspath

On 01/08/2017 20:05, Mandy Chung wrote: This patch adds back the test cases that were added for JDK-6760902 but later were removed by JDK-8142968. Those test cases are useful and converted to use -Xbootclasspath/a. Webrev at: http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8185541/webrev.00/

Re: [10] RFR 8134512 : provide Alpha-Numeric (logical) Comparator

On 7/28/17 12:16 PM, Jonathan Bluett-Duncan wrote: Hi Ivan, It looks like the MyComparator code example which you gave in your last email lost its formatting along the way, so I'm finding it difficult to read. Would you mind resubmitting it? Oh, sorry about that. I've just uploaded anothe