RFR(jdk10/jaxp) 8163121: BCEL: update to the latest 6.0 release

2017-08-08 Thread huizhe wang
Please review an update to BCEL release 6.0 [1]. The sources are basically that from the release bundle with the following exceptions: * Classes that were not included in the original version are excluded; * Classes that are deprecated in BCEL 6.0 are removed; * Classes that are used only f

Re: RFR: jsr166 jdk10 integration wave 2

2017-08-08 Thread Martin Buchholz
On Tue, Aug 8, 2017 at 5:21 AM, Peter Levart wrote: > Hi Martin, > > Just a purely theoretical question... > > On 08/08/2017 02:06 AM, Martin Buchholz wrote: > >> Need to fix >> >> >> 1. JDK-8185830 >> >> ConcurrentSkipListSet.clone() fails w

Re: RFR: JDK-8185984: fix a11y and html issues in java.logging module

2017-08-08 Thread mandy chung
Looks fine to me. Mandy On 8/8/17 1:23 PM, Jonathan Gibbons wrote: Please review a few small changes for accessibility and HTML issue in the API docs for the java.logging module. JBS: https://bugs.openjdk.java.net/browse/JDK-8185984 Webrev: http://cr.openjdk.java.net/~jjg/8185984/webrev.00/

Re: RFR: JDK-8185984: fix a11y and html issues in java.logging module

2017-08-08 Thread Daniel Fuchs
Hi Jon, Looks good to me! best regards, -- daniel On 08/08/17 21:23, Jonathan Gibbons wrote: Please review a few small changes for accessibility and HTML issue in the API docs for the java.logging module. JBS: https://bugs.openjdk.java.net/browse/JDK-8185984 Webrev: http://cr.openjdk.java.n

RFR: JDK-8185984: fix a11y and html issues in java.logging module

2017-08-08 Thread Jonathan Gibbons
Please review a few small changes for accessibility and HTML issue in the API docs for the java.logging module. JBS: https://bugs.openjdk.java.net/browse/JDK-8185984 Webrev: http://cr.openjdk.java.net/~jjg/8185984/webrev.00/ -- Jon

Re: RFR: jsr166 jdk10 integration wave 2

2017-08-08 Thread Paul Sandoz
> On 7 Aug 2017, at 17:06, Martin Buchholz wrote: > > Need to fix > > > 1. JDK-8185830 > > ConcurrentSkipListSet.clone() fails with UnsupportedOperationException > http://cr.openjdk.java.net/~martin/webrevs/openjdk10/jsr166-integration/ >

Re: RFR: jsr166 jdk10 integration wave 2

2017-08-08 Thread Peter Levart
On 08/08/2017 02:21 PM, Peter Levart wrote: Hi Martin, Just a purely theoretical question... On 08/08/2017 02:06 AM, Martin Buchholz wrote: Need to fix 1. JDK-8185830 ConcurrentSkipListSet.clone() fails with UnsupportedOperationExcept

Re: RFR: jsr166 jdk10 integration wave 2

2017-08-08 Thread Peter Levart
Hi Martin, Just a purely theoretical question... On 08/08/2017 02:06 AM, Martin Buchholz wrote: Need to fix 1. JDK-8185830 ConcurrentSkipListSet.clone() fails with UnsupportedOperationException http://cr.openjdk.java.net/~martin/webrevs/