Re: RFR(s): 8186851 fix misspellings of "dependent" and "independent" in the JDK repo

+1 On 8/28/2017 2:38 PM, Stuart Marks wrote: Hi all, I was irked by some misspellings so I decided to create a quick fix. Webrev:     http://cr.openjdk.java.net/~smarks/reviews/8186851/webrev.0/ Bug:     https://bugs.openjdk.java.net/browse/JDK-8186851 Most of the changes are in core libs

FW: RFR(S): [testbug] add @requires vm.cds to CDS tests in jdk test suite

Hi, could I please get a review on core-libs-dev? Thanks, Goetz. -Original Message- From: David Holmes [mailto:david.hol...@oracle.com] Sent: Dienstag, 29. August 2017 00:33 To: Lindenmaier, Goetz ; serviceability-dev (serviceability-...@openjdk.java.net) Cc: mikhailo Subject: Re:

Re: Review Request JDK-8186050: StackFrame should provide the method signature

On 8/28/17 4:23 PM, Paul Sandoz wrote: Hi Mandy, MethodType::fromMethodDescriptorString​ (and the three arg Class.forName) requires that a class loader be supplied. Perhaps for the thing consuming StackWalker it’s not possible to reproduce a MethodType (or components of) from the descriptor

RFR(XXS): Exclude tools/jlink/CheckExecutable.java until 8182878 is fixed.

Hi Could you please review very small fix which quarantines test tools/jlink/CheckExecutable.java until corresponding infra issue is fixed. bug: https://bugs.openjdk.java.net/browse/JDK-8186581 diff: diff -r daed9a0332d3 test/ProblemList.txt -

Re: [10] RFR JDK-8186713: Document default rounding mode in NumberFormat

Hi Nishit, I suggest these changes in NumberFormat.java: 184:delete the line 186:s/{@code NumberFormat}/The default implementation/ 187-188:s/By default, it uses/It uses/ With these changes I am fine with the patch and no need to send an updated webrev unless you

Re: Review Request JDK-8186050: StackFrame should provide the method signature

Hi Mandy, MethodType::fromMethodDescriptorString​ (and the three arg Class.forName) requires that a class loader be supplied. Perhaps for the thing consuming StackWalker it’s not possible to reproduce a MethodType (or components of) from the descriptor string much like it may not possible to re

Review Request JDK-8186050: StackFrame should provide the method signature

Method signature is missing in the StackFrame API. This proposes to add StackFrame::getMethodDescriptor method to return the method descriptor in a stack frame. Webrev at: http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8186050/webrev.00/index.html There are a couple options how to present th

Re: RFR(s): 8186851 fix misspellings of "dependent" and "independent" in the JDK repo

Hi Stuart, Looks fine. Brian On Aug 28, 2017, at 2:38 PM, Stuart Marks wrote: > I was irked by some misspellings so I decided to create a quick fix. > > […] > > Most of the changes are in core libs and in Swing, so I'm posting to both > lists.

RFR(s): 8186851 fix misspellings of "dependent" and "independent" in the JDK repo

Hi all, I was irked by some misspellings so I decided to create a quick fix. Webrev: http://cr.openjdk.java.net/~smarks/reviews/8186851/webrev.0/ Bug: https://bugs.openjdk.java.net/browse/JDK-8186851 Most of the changes are in core libs and in Swing, so I'm posting to both lists. Th

Re: RFR (S) 8173715: Remove FlatProfiler

The man pages in jdk repo are an older version and they have not been updated (sadly to say).  Hopefully we can resume working on the man pages doc work soon. Removing -Xprof from these man pages is fine with me.  So yes please also update bsd for completely. Can you file a docs issue to upd

Re: RFR (S) 8173715: Remove FlatProfiler

Gerard, The launcher change looks okay.  Removing -Xprof from these man pages is okay.  The man pages in jdk repo are an older version and they have not been updated.  Can you file a docs issue to update the online version of the man page that the docs team maintains? Mandy hi all, (this

Re: RFR (S) 8173715: Remove FlatProfiler

Besides the launcher.properties files of other languages, there was a bsd file in the jdk that had -Xprof: bsd/doc/man/java.1:\-Xprof Does that have to be updated.  Otherwise I think it looks good. thanks, Coleen On 8/16/17 1:48 PM, Gerard Ziemski wrote: hi all, (this is jdk part of the

Re: [10] RFR 8186469 MethodHandle.invokeWithArguments jumbo-arity

> On 28 Aug 2017, at 03:47, stanislav lukyanov > wrote: > > On 25.08.2017 21:38, Paul Sandoz wrote: >>> On 25 Aug 2017, at 00:47, stanislav lukyanov >>> wrote: >>> >>> >>> On 24.08.2017 23:43, Paul Sandoz wrote: > On 23 Aug 2017, at 23:49, stanislav lukyanov > wrote: > I still

Re: RFR 8173715: Remove Flat Profiler

Ping. > On Aug 24, 2017, at 2:59 AM, David Holmes wrote: > > On 24/08/2017 2:20 AM, Gerard Ziemski wrote: >> Thank you David. >> Do I need a second reviewer here? > > Yes any launcher changes should be signed off by launcher folk - so I've > directly cc'd Kumar, who is hopefully around :) > >

Re: [10] RFR 8171049: Era.getDisplayName doesn't work with non-IsoChronology

Hi Naoto, Thanks for following up on the suggestions. I agree your original proposal find, as is, the alternative APIs are package private and are not readily available. And I agree a static builder would not be valuable since it is not reusable and it would not be a good use of memory since

Re: [10] RFR 8186469 MethodHandle.invokeWithArguments jumbo-arity

On 25.08.2017 21:38, Paul Sandoz wrote: On 25 Aug 2017, at 00:47, stanislav lukyanov wrote: On 24.08.2017 23:43, Paul Sandoz wrote: On 23 Aug 2017, at 23:49, stanislav lukyanov wrote: I still think that instead of debugging this spec and making sure that it behaves similarly to `asType` i

Re: [10] RFR JDK-8186713: Document default rounding mode in NumberFormat

Hi Brian, > L178-195: Is a list necessary here? The list approach is used to clearly mention that these two points are under "Implementation Requirements". If it does not look good, another way could be to use @implSpec tag for individual points, separated by . Please check if this is fine.