RE: [10] [testbug] RFR of JDK-8187700 SetAuthenticator tests should handle the proxy port

2017-10-08 Thread Frank Yuan
Hi Daniel and all Would you like to have a look on this review? It's the same issue as JDK-8188086 but in SetAuthenticator tests. The fix's verified by running the test in loop. Thanks Frank From: Frank Yuan [mailto:frank.y...@oracle.com] Subject: [10] [testbug] RFR of JDK-8187700

Re: RFR (XS) 8188828 Intermittent ClassNotFoundException: jdk.test.lib.Platform for compiler tests

2017-10-08 Thread David Holmes
Hi Ioi, This seems like a temporary workaround - fine for now - but what is the real fix here? It's crazy that one test library class can't use another class from the same test library! Thanks, David On 7/10/2017 6:19 AM, Ioi Lam wrote: Please review this very simple change: https://bugs.o

Re: RFR: 8187954 Update JAX-WS RI integration to latest version

2017-10-08 Thread Jack Li
Hi Lance, the change is incorrect, it should be “javax/xml/bind”. thanks a lot for your finding, do you think I need to fix it and resubmit the webrev this time? or can you skip this file this time and I fix it in next integration? > On Oct 4, 2017, at 02:09, Lance Andersen wrote: > > Hi Jack,

Re: Review Request JDK-8164512: Replace ClassLoader use of finalizer with phantom reference to unload native library

2017-10-08 Thread David Holmes
Hi Mandy, This all looks fine to me now. Thanks, David On 7/10/2017 5:37 AM, mandy chung wrote: Hi David, Thanks for raising the lazy initialization issue.  The recent version of ClassLoader.java in webrev.03 is uploaded in place: http://cr.openjdk.java.net/~mchung/jdk10/webrevs/8164512/web