Re: RFR (JDK10/JAXP) 8191938: Fix lint warnings in JAXP repo: a few Deprecation warrnings and enable -Xlint:all

Looks fine Joe; good to see this work get in :-) Thanks, -Joe On 11/30/2017 10:23 PM, Joe Wang wrote: Hi all, The webrev is updated with a javac flag that includes a set of public APIs in java.xml that we care about with regards to doclint.

Re: RFR (JDK10/JAXP) 8191938: Fix lint warnings in JAXP repo: a few Deprecation warrnings and enable -Xlint:all

Hi all, The webrev is updated with a javac flag that includes a set of public APIs in java.xml that we care about with regards to doclint. http://cr.openjdk.java.net/~joehw/jdk10/8191938/webrev/ Thanks, Joe On 11/30/17, 11:25 AM, Joe Wang wrote: Hi Jon, all, For the LastModified tag, yes,

RFR (JDK10) 8183743: Umbrella: add overloads that take a Charset parameter

Hi, Adding convenient methods that take a Charset to several classes that have already had methods with a Charset/Encoding name as a parameter. To avoid any impact on compatibility and JCK tests, we've kept the existing methods virtually untouched except making a reference to the new ones to

Re: RFR 8187222 : ClassLoader.getSystemClassLoader not clear if recursive initialization leads to ISE or unspecified error

On 11/30/17 1:35 PM, Brent Christian wrote: Hi, Please review the following change: Bug: https://bugs.openjdk.java.net/browse/JDK-8187222 Webrev: http://cr.openjdk.java.net/~bchristi/8187222/webrev.00/ Thanks for fixing it. This is indeed a bug that should throw ISE when

RFR JDK-8191918: tomcat gzip-compressed response bodies appear to be broken in update 151

Hi, Please help review the change for JDK-8191918: issue: https://bugs.openjdk.java.net/browse/JDK-8191918 webrev: http://cr.openjdk.java.net/~sherman/8191918/webrev This is the backport/identical change we have already putback into earlier update releases for JDK-8189789. It includes two

Re: RFR 8186961 Class.getFields() does not return fields of previously visited super interfaces/classes.

On 2017-11-30 23:25, Paul Sandoz wrote: On 30 Nov 2017, at 13:00, Claes Redestad wrote: Hi, as expected this is quite a bit easier to follow. Thanks! As any heavy use of reflection is likely to hit cached data, then heavily optimizing might be ill-advised

Re: RFR 8186961 Class.getFields() does not return fields of previously visited super interfaces/classes.

> On 30 Nov 2017, at 13:00, Claes Redestad wrote: > > Hi, > > as expected this is quite a bit easier to follow. Thanks! > > As any heavy use of reflection is likely to hit cached data, then heavily > optimizing might be ill-advised here. > > A simpler

RFR 8187222 : ClassLoader.getSystemClassLoader not clear if recursive initialization leads to ISE or unspecified error

Hi, Please review the following change: Bug: https://bugs.openjdk.java.net/browse/JDK-8187222 Webrev: http://cr.openjdk.java.net/~bchristi/8187222/webrev.00/ The method description of ClassLoader.getSystemClassLoader() states (in regards to setting a custom system classloader): "If circular

Re: RFR 8186961 Class.getFields() does not return fields of previously visited super interfaces/classes.

Hi, as expected this is quite a bit easier to follow. Thanks! As any heavy use of reflection is likely to hit cached data, then heavily optimizing might be ill-advised here. A simpler optimization might be to check if the class has any superclass or interfaces whatsoever first, since if not

Re: RFR(m): 8177290 add copy factory methods for unmodifiable List, Set, Map

OK ! you convince me. Rémi - Mail original - > De: "Stuart Marks" > À: "Remi Forax" > Cc: "core-libs-dev" > Envoyé: Mercredi 29 Novembre 2017 06:21:41 > Objet: Re: RFR(m): 8177290 add copy factory methods for

Re: RFR 8186961 Class.getFields() does not return fields of previously visited super interfaces/classes.

Here is the updated webrev: http://cr.openjdk.java.net/~psandoz/jdk10/JDK-8186961-iface-static-fields-get/webrev/ I opted for the simple solution using a LinkedHashSet. It’s possible to heavily optimize (avoiding the production of a linked hash set until required [*]) but the resulting code

Re: RFR (JDK10/JAXP) 8191938: Fix lint warnings in JAXP repo: a few Deprecation warrnings and enable -Xlint:all

Hi Jon, all, For the LastModified tag, yes, "make docs" was fine. Note that it will appear only in impl classes. For the webrev, I also updated the javac flag from doclint:none to a set of java.xml public packages that we care about.

Re: RFR(s): 8160406: Collection.toArray() spec should be explicit about returning precisely an Object[]

On 11/29/17 7:28 PM, Martin Buchholz wrote: I would make one change. +     * @param the static component type of the array to contain the collection Just drop runtime/static     * @param the component type of the array to contain the collection the "static" is "obvious" and the caller

Re: RFR 8186961 Class.getFields() does not return fields of previously visited super interfaces/classes.

Hi Caes, As we discussed off list the post loop logic is easily missed. However, i found another obvious issue i missed with two classes (super/sub) extending from the same interface that declares a field. See updated test case in the webrev. I have an idea to retain Field[] arrays and then

Re: RFR: 8189331 [testbug] java/io/Serializable/maskSyntheticModifier/MaskSyntheticModifierTest.java failed incorrect serialVersionUID

+1 Lance Andersen| Principal Member of Technical Staff | +1.781.442.2037 Oracle Java Engineering 1 Network Drive Burlington, MA 01803 lance.ander...@oracle.com Sent from my iPad > On Nov 30, 2017, at 10:20 AM, Roger Riggs wrote: > > Please review a test fix to copy

RFR: 8189331 [testbug] java/io/Serializable/maskSyntheticModifier/MaskSyntheticModifierTest.java failed incorrect serialVersionUID

Please review a test fix to copy the golden Foo.class into the classpath instead of the current directory. webrev:  http://cr.openjdk.java.net/~rriggs/webrev-synthetic-8189331/ issue:    https://bugs.openjdk.java.net/browse/JDK-8189331 Thanks, Roger

Re: RFR JDK-8187910: Charset MS950_HKSCS not supported in JDK 9

On 30/11/2017 07:12, Xueming Shen wrote: Hi Please help review the change for JDK-8187910. issue: https://bugs.openjdk.java.net/browse/JDK-8187910 webrev: http://cr.openjdk.java.net/~sherman/8187910/webrev The change is to add charset MS950_HKSCS into sun.nio.cs/"standard charset provider"

RE: RFR: 8189102: All tools should support -?, -h and --help

Thanks, Robert! Best regards, Goetz. > -Original Message- > From: Robert Field [mailto:robert.fi...@oracle.com] > Sent: Mittwoch, 29. November 2017 19:31 > To: Lindenmaier, Goetz > Cc: Kumar Srinivasan ; serviceability-dev >