RFR 8080225 FileInput/OutputStream/FileChannel cleanup should be improved

Please review a revision to the work on remove a dependency on finalization from FileInputStream, FileOutputStream, and add cleanup of closing file descriptors in FileChannel. The previous version was too aggressive in removing the finalize method and was considered to be insufficiently

Re: RFR 8187222 : ClassLoader.getSystemClassLoader not clear if recursive initialization leads to ISE or unspecified error

> On Dec 1, 2017, at 5:17 PM, Mandy Chung wrote: > > >>> On Dec 1, 2017, at 4:46 PM, Brent Christian >>> wrote: >>> >>> On 12/1/17 11:40 AM, Brent Christian wrote: >>> On 12/1/17 8:33 AM, mandy chung wrote: > Better still might be for

Re: RFR: JDK-8192935 Fix EnumSet's SerializationProxy javadoc

On 12/1/17 4:42 PM, Martin Buchholz wrote: 1. JDK-8192935 http://cr.openjdk.java.net/~martin/webrevs/openjdk10/EnumSet-SerializationProxy/EnumSet-SerializationProxy.patch --- a/src/java.base/share/classes/java/util/EnumSet.java +++

Re: RFR 8187222 : ClassLoader.getSystemClassLoader not clear if recursive initialization leads to ISE or unspecified error

> On Dec 1, 2017, at 4:46 PM, Brent Christian > wrote: > >> On 12/1/17 11:40 AM, Brent Christian wrote: >> On 12/1/17 8:33 AM, mandy chung wrote: Better still might be for initSystemClassLoader to re-throw the cause so that it appears immediately after

Re: RFR JDK-8191918: tomcat gzip-compressed response bodies appear to be broken in update 151

+1 This is a good example of where “var” can really reduce the verbosity, up to you. Also ByteArrayOutputStream.close is a no-op, you don’t need the finally block. Paul. > On 1 Dec 2017, at 17:04, Xueming Shen wrote: > > On 12/1/17, 3:40 PM, Paul Sandoz wrote: >>

Re: RFR JDK-8191918: tomcat gzip-compressed response bodies appear to be broken in update 151

On 12/1/17, 3:40 PM, Paul Sandoz wrote: On 30 Nov 2017, at 14:46, Xueming Shen wrote: Hi, Please help review the change for JDK-8191918: issue: https://bugs.openjdk.java.net/browse/JDK-8191918 webrev: http://cr.openjdk.java.net/~sherman/8191918/webrev

Re: RFR 8187222 : ClassLoader.getSystemClassLoader not clear if recursive initialization leads to ISE or unspecified error

On 12/1/17 11:40 AM, Brent Christian wrote: On 12/1/17 8:33 AM, mandy chung wrote: Better still might be for initSystemClassLoader to re-throw the cause so that it appears immediately after the "Error occurred during initialization of VM" message that the VM will fail with. Yes that would be

RFR: JDK-8192935 Fix EnumSet's SerializationProxy javadoc

1. JDK-8192935 http://cr.openjdk.java.net/~martin/webrevs/openjdk10/EnumSet-SerializationProxy/EnumSet-SerializationProxy.patch

Re: RFR JDK-8191918: tomcat gzip-compressed response bodies appear to be broken in update 151

> On 30 Nov 2017, at 14:46, Xueming Shen wrote: > > Hi, > > Please help review the change for JDK-8191918: > > issue: https://bugs.openjdk.java.net/browse/JDK-8191918 > webrev: http://cr.openjdk.java.net/~sherman/8191918/webrev > InflateIn_DeflateOut.java — 174

Re: RFR 8186961 Class.getFields() does not return fields of previously visited super interfaces/classes.

> On Dec 1, 2017, at 2:52 PM, Paul Sandoz wrote: > > > >> On 1 Dec 2017, at 12:16, mandy chung wrote: >> >> >> >>> On 11/30/17 12:17 PM, Paul Sandoz wrote: >>> Here is the updated webrev: >>> >>> >>>

Re: RFR 8186961 Class.getFields() does not return fields of previously visited super interfaces/classes.

> On 1 Dec 2017, at 12:16, mandy chung wrote: > > > > On 11/30/17 12:17 PM, Paul Sandoz wrote: >> Here is the updated webrev: >> >> >> http://cr.openjdk.java.net/~psandoz/jdk10/JDK-8186961-iface-static-fields-get/webrev/ >> >> >> I opted for the simple solution

Re: RFR (JDK10) 8183743: Umbrella: add overloads that take a Charset parameter

On 12/1/17, 3:16 AM, Alan Bateman wrote: On 01/12/2017 06:11, Joe Wang wrote: Hi, Adding convenient methods that take a Charset to several classes that have already had methods with a Charset/Encoding name as a parameter. To avoid any impact on compatibility and JCK tests, we've kept the

Re: RFR 8186961 Class.getFields() does not return fields of previously visited super interfaces/classes.

On 11/30/17 12:17 PM, Paul Sandoz wrote: Here is the updated webrev: http://cr.openjdk.java.net/~psandoz/jdk10/JDK-8186961-iface-static-fields-get/webrev/ I opted for the simple solution using a LinkedHashSet. This fix looks good except a typo in the test: 94 "Class %s does not

Re: RFR 8187222 : ClassLoader.getSystemClassLoader not clear if recursive initialization leads to ISE or unspecified error

On 12/1/17 8:33 AM, mandy chung wrote: Better still might be for initSystemClassLoader to re-throw the cause so that it appears immediately after the "Error occurred during initialization of VM" message that the VM will fail with. Yes that would be better. So would I do this for

Re: RFR (JDK10/JAXP) 8191938: Fix lint warnings in JAXP repo: a few Deprecation warrnings and enable -Xlint:all

Thanks Joe! Pushed. Thanks for helping me getting this work done, finally! From 5230 warnings in your original count, plus some new warnings introduced by JDK 9, down to zero, it's been two years already. I'm happy we join in the big family to be lint free :-) -Joe On 11/30/17, 10:43 PM,

Re: RFR 8187222 : ClassLoader.getSystemClassLoader not clear if recursive initialization leads to ISE or unspecified error

On 12/1/17 2:32 AM, Alan Bateman wrote: On 30/11/2017 22:57, mandy chung wrote: : This is indeed a bug that should throw ISE when ClassLoader.getSystemClassLoader is called during the initialization of the system class loader, as the spec states. line 1921: I suggest to revise the

RE: RFR: 8189102: All tools should support -?, -h and --help

Hi Kumar, I'm already looking at the issues from your other mail. Detailed comments will follow. I'll also check and fix the new tests you report. I think we don't run the langtool tests, i.e. I know we didn't run them before the repos were merged. Obviously we should add them to our testing

Re: [10] RFR 8187551: MessageFormat.setFormat(int, Format) AIOOBE not thrown when documented

Hi Nishit, Please add the new test to test/jdk/java/text/Format/MessageFormat/MessageRegression.java instead of creating a new test. Also the convention for test names should be a functional description of the test; bug numbers are uninformative. (I'm a bit surprised there are few/no

Re: RFR: 8189102: All tools should support -?, -h and --help

Hi, Besides my private comments to you, there are 2-3 internal tests which fail. Have you run all the langtools tests ? There are 4 Windows tests that fail with langtools: jdk/javadoc/doclet/testHelpOption/TestHelpOption.java jdk/javadoc/tool/CheckResourceKeys.java

Re: RFR (JDK10) 8183743: Umbrella: add overloads that take a Charset parameter

On 01/12/2017 06:11, Joe Wang wrote: Hi, Adding convenient methods that take a Charset to several classes that have already had methods with a Charset/Encoding name as a parameter. To avoid any impact on compatibility and JCK tests, we've kept the existing methods virtually untouched

Re: RFR 8187222 : ClassLoader.getSystemClassLoader not clear if recursive initialization leads to ISE or unspecified error

On 30/11/2017 22:57, mandy chung wrote: : This is indeed a bug that should throw ISE when ClassLoader.getSystemClassLoader is called during the initialization of the system class loader, as the spec states. line 1921: I suggest to revise the message to make it clearer:     

[10] RFR 8187551: MessageFormat.setFormat(int, Format) AIOOBE not thrown when documented

Hi, Please review the fix for JDK-8187551. Bug: https://bugs.openjdk.java.net/browse/JDK-8187551 Webrev: http://cr.openjdk.java.net/~nishjain/8187551/webrev.02/ Fix: As documented, updated MessageFormat.setFormat() to throw AIOOBE with invalid format element index. Thanks Martin Buchholz