Re: RFR 8192958 [JDK10] : TEST.groups: group jdk_util_other: file not found: jdk/internal/util

2017-12-03 Thread David Holmes
Looks good! Thanks, David On 4/12/2017 4:30 PM, Muneer Kolarkunnu wrote: Hi, Please review the fix for JDK- 8192958. Bug: https://bugs.openjdk.java.net/browse/JDK-8192958 Webrev: http://cr.openjdk.java.net/~akolarkunnu/8192958/webrev.00/ Issue: There was only one test case under t

Re: [10] RFR 8187551: MessageFormat.setFormat(int, Format) AIOOBE not thrown when documented

2017-12-03 Thread Nishit Jain
Thanks Roger, Updated the webrevto add the new test case in MessageRegression.java http://cr.openjdk.java.net/~nishjain/8187551/webrev.03/ Regards, Nishit Jain On 01-12-2017 20:40, Roger Riggs wrote: Hi Nishit, Please add the new test to test/jdk/java/text/Format/MessageFormat/MessageRegress

RFR 8192958 [JDK10] : TEST.groups: group jdk_util_other: file not found: jdk/internal/util

2017-12-03 Thread Muneer Kolarkunnu
Hi, Please review the fix for JDK- 8192958. Bug: https://bugs.openjdk.java.net/browse/JDK-8192958 Webrev: http://cr.openjdk.java.net/~akolarkunnu/8192958/webrev.00/ Issue: There was only one test case under the folder "jdk/internal/util" which was jdk/internal/util/jar/VersionedStream.ja

Re: Android and Log4j

2017-12-03 Thread Ralph Goers
> On Dec 3, 2017, at 12:19 PM, Alan Bateman wrote: > > On 03/12/2017 18:25, Ralph Goers wrote: >> Log4j added support for Java 9 by: >> Converting the Log4j-API jar to a multi-release jar that includes support >> for StackWalker and the new Process Id support. >> Adding a module-info.jar to th

RFR: 8176188: jdk/internal/misc/JavaLangAccess/NewUnsafeString.java failing since 9-b93

2017-12-03 Thread Claes Redestad
Hi, the compact strings JEP changed semantics of the package-private String(char[], boolean) constructor to do the same as the public String(char[]) constructor. Previously the former was used in trusted, internal code to avoid copying the given char[], but since the char[] now has to be conv

Re: RFR (JDK10) 8183743: Umbrella: add overloads that take a Charset parameter

2017-12-03 Thread Alan Bateman
On 01/12/2017 20:35, Joe Wang wrote: : I think URLDecoder.decode methods should have @throws IllegalArgumentException. I realize it's implementation specific as to whether IAE is thrown with bad input but given that the RI does throw IAE then consumers of the API should be prepared for it

Re: Android and Log4j

2017-12-03 Thread Alan Bateman
On 03/12/2017 18:25, Ralph Goers wrote: Log4j added support for Java 9 by: Converting the Log4j-API jar to a multi-release jar that includes support for StackWalker and the new Process Id support. Adding a module-info.jar to the Log4j API jar. We are now getting complaints from Android users (a

Re: Android and Log4j

2017-12-03 Thread Remi Forax
Ask Google to fix dx, dx should ignore the module-info.class and everything inside META-INF/versions (at least it's a first simple patch). cheers, Rémi - Mail original - > De: "Ralph Goers" > À: "core-libs-dev" > Envoyé: Dimanche 3 Décembre 2017 19:25:08 > Objet: Android and Log4j > L

Android and Log4j

2017-12-03 Thread Ralph Goers
Log4j added support for Java 9 by: Converting the Log4j-API jar to a multi-release jar that includes support for StackWalker and the new Process Id support. Adding a module-info.jar to the Log4j API jar. We are now getting complaints from Android users (as well as a few others) that their tools

Re: MR JarFile was: Scanning multi version jars?

2017-12-03 Thread Alan Bateman
On 15/09/2017 11:37, Alan Bateman wrote: On 15/09/2017 05:43, Greg Wilkins wrote: : The issue I have are that sometimes the class is trying to hide the MR aspects, yet other times it is not.   Specifically when iterating it returns JarEntry instances that ignore versions and always return t