Re: JDK-8145371 ClassCastException thrown in LambdaFormEditor.getInCache

2018-01-10 Thread Martin Buchholz
On Wed, Jan 10, 2018 at 3:58 PM, Paul Sandoz wrote: > > The code is skating close to the edge and is definitely making you > uncomfortable :-) so I proposed making the field non-final but annotated > with @Stable, the same optimisations should still apply. > Sorry, @Stable doesn't increase my co

Re: JDK-8145371 ClassCastException thrown in LambdaFormEditor.getInCache

2018-01-10 Thread Paul Sandoz
> On 9 Jan 2018, at 23:28, Martin Buchholz wrote: > > > > On Tue, Jan 9, 2018 at 4:50 PM, Paul Sandoz > wrote: > > >> On 9 Jan 2018, at 15:11, Martin Buchholz > > wrote: >> >> >> >> On Tue, Jan 9, 2018 at 2:42 PM, Paul Sandoz >

[11] RFR 8194148: bcp47u/SymbolsTests.java and FormatTests.java fail on th_TH locale

2018-01-10 Thread Naoto Sato
Hello, Please review a simple test fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8194148 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8194148/webrev.00/ The gist of the issue is that on some test machine, Buddhist calendar is the default for

RFR(S): 8194869: [TESTBUG][aix, s390] Adapt tests to platforms.

2018-01-10 Thread Lindenmaier, Goetz
Hi, this change adapts a row of jtreg tests to AIX. Shell tests often switch over all OSes, here the case for AIX was missing. PKCSTest needs to know where the libs are on s390. Please review. http://cr.openjdk.java.net/~goetz/wr18/8194869-jtregAix/webrev/ Best regards, Goetz.