Hi,
The CSR for this change is approved now.
https://bugs.openjdk.java.net/browse/JDK-8191477
If there aren't any more objections, I will push this.
Webrev rebased and with updated 2018 copyright messages:
http://cr.openjdk.java.net/~goetz/wr17/8189102-helpMessage/webrev.08/
Best regards,
Goet
Added, same for the line that has "href and base", although that seemed
to be the norm for the translation team already (I mean they did not
translate those terms). But just for the completeness, I added those
comments as well.
Thanks,
Joe
On 1/12/2018 5:03 PM, Leo Jiang wrote:
Maybe you sho
> On Jan 15, 2018, at 6:00 AM, Vladimir Ivanov
> wrote:
>
>
>> This isn’t much different from the already allowed fine tuning of memory
>> model effects (e.g., observing stale values from a plain write). In those
>> scenarios, as is the case with @Stable, developers have to be aware of and
> On Jan 15, 2018, at 6:51 AM, Vladimir Ivanov
> wrote:
>
> Jason,
>
> I wouldn't consider @Stable as a scalpel :-)
>
> It's heavily locked down for a reason: it wasn't designed for eventual
> standardization, but as (1) an experiment in _multiple_ directions; and (2)
> solution for immedia
Jason,
I wouldn't consider @Stable as a scalpel :-)
It's heavily locked down for a reason: it wasn't designed for eventual
standardization, but as (1) an experiment in _multiple_ directions; and
(2) solution for immediate problems in java.lang.invoke.
@Stable mixes (incomplete implementation
No, it doesn't work that way. @Stable enables JIT to constant fold
loads from fields/arrays (holding non-default values) whenever
possible. After that JIT has a constant value at its hands. All
other optimizations follows from that: range check before array
store can be elided
This isn’t much different from the already allowed fine tuning of memory model
effects (e.g., observing stale values from a plain write). In those scenarios,
as is the case with @Stable, developers have to be aware of and honor the
respective contract. It could be argued that bugs arising fro
Hi Matthias,
I didin't mean to do any changes for other platforms, so
I reverted the part you pointed out:
http://cr.openjdk.java.net/~goetz/wr18/8194869-jtregAix/webrev.02/
But scanning through all the scripts:
Sometimes PS on Cygwin is ';' and sometimes it is ':'. Strange ...
Best regards,
Hi Goetz, change looks good except
test/jdk/sun/security/tools/keytool/i18n.sh
where the Cygwin PS setting has been changed from ; to : (probably this was
not intended) :
PS=":"
FS="/"
;;
- CYGWIN* )
-NULL=/dev/null
-PS=";"
(not a Reviewer however).
Best regards, Ma
