Re: RFR: 8186009 tools launcher test AddExportsAndOpensInManifest.java fails intermittently: AccessDeniedException

On 26/01/2018 00:19, Andrey Nazarov wrote: Screenshot with new layout http://cr.openjdk.java.net/~anazarov/JDK-8186009/Screen%20Shot%202018-01-25%20at%2015.40.15.png CR: http://cr.openjdk.java.net/~anazarov/JDK-8186009/webrev.04/ L

[JDK 11] RFR 8196211: Move two sun/nio/cs tests into OpenJDK

Please review the patch to move two sun/nio/cs tests into OpenJDK. bug: https://bugs.openjdk.java.net/browse/JDK-8196211 webrev: http://cr.openjdk.java.net/~amlu/8196211/webrev.00/ Thanks, Amy

Re: [PATCH] Inefficient ArrayList.subList().toArray()

Yes. public Object[] toArray() { checkForComodification(); return Arrays.copyOfRange(root.elementData, offset, offset + size); } @SuppressWarnings("unchecked") public T[] toArray(T[] a) { checkForComodification(); if

Re: [11] RFR JDK-8196127: Dead code in VersionProps.java.template

I like code deletion! Mandy On 1/25/18 6:24 PM, David Holmes wrote: Wow that was fast! :) Looks good. Thanks, David On 26/01/2018 5:33 AM, mandy chung wrote: Trivial fix to remove unused isHeadless variable. $ hg diff src/java.base/share/classes/java/lang/VersionProps.java.template diff --

RFR (JDK11) 8137326: Methods for comparing CharSequence, StringBuilder, and StringBuffer

Hi, Adding methods for comparing CharSequence, StringBuilder, and StringBuffer. The Comparable implementations for StringBuilder/Buffer are similar to that of String, allowing comparison operations between two StringBuilders/Buffers, e.g. aStringBuilder.compareTo(anotherStringBuilder). For Ch

Re: [11] RFR JDK-8196127: Dead code in VersionProps.java.template

Wow that was fast! :) Looks good. Thanks, David On 26/01/2018 5:33 AM, mandy chung wrote: Trivial fix to remove unused isHeadless variable. $ hg diff src/java.base/share/classes/java/lang/VersionProps.java.template diff --git a/src/java.base/share/classes/java/lang/VersionProps.java.template

Re: [PATCH] Inefficient ArrayList.subList().toArray()

On Jan 25, 2018, at 2:02 PM, Сергей Цыпанов wrote: > > +return (T[]) Arrays.copyOfRange(root.elementData, offset, > size, a.getClass()); Giving this a quick glance: I think you may want s/size/offset+size/. There should be calls to checkForComodification.

Re: Oracle Java 8u161 regression in XML Schema Factory

Hi guys, A coworker of mine had hit this issue last night on 8u161 and it worked fine on 8u151: ERROR: /home/myuser/.cache/bazel/_bazel_myuser/some_hash_code/external/jackson_datatype_joda_shaded/BUILD:5:1: Building external/jackson_datatype_joda_shaded/libjackson-datatype-joda-class.jar (35 sou

Re: [PATCH] Inefficient ArrayList.subList().toArray()

Thanks, Сергей I filed a bug for you https://bugs.openjdk.java.net/browse/JDK-8196207 On Thu, Jan 25, 2018 at 2:02 PM, Сергей Цыпанов wrote: > Hi, > > I've run into poor performance of toArray() method called on result of > subList() taken from java.util.ArrayList. > > Consider simple benchmark:

Re: RFR: 8186009 tools launcher test AddExportsAndOpensInManifest.java fails intermittently: AccessDeniedException

Screenshot with new layout http://cr.openjdk.java.net/~anazarov/JDK-8186009/Screen%20Shot%202018-01-25%20at%2015.40.15.png CR: http://cr.openjdk.java.net/~anazarov/JDK-8186009/webrev.04/ —Thanks, Andrei > On 25 Jan 2018, at 16:05, A

RFR: 8186009 tools launcher test AddExportsAndOpensInManifest.java fails intermittently: AccessDeniedException

Hi, Could you review fix in launcher tests. Fix changes “file.jar” name to unique name for every test case. It eliminates dependency between test cases on the file. http://cr.openjdk.java.net/~anazarov/JDK-8186009/webrev.03 https://

Re: [PATCH] Inefficient ArrayList.subList().toArray()

Hi Sergey, Not a Reviewer but I like this patch a lot. Thanks for contributing it to OpenJDK! Best regards, Kris On Thu, Jan 25, 2018 at 2:02 PM, Сергей Цыпанов wrote: > Hi, > > I've run into poor performance of toArray() method called on result of > subList() taken from java.util.ArrayList. >

[PATCH] Inefficient ArrayList.subList().toArray()

Hi, I've run into poor performance of toArray() method called on result of subList() taken from java.util.ArrayList. Consider simple benchmark: @BenchmarkMode(Mode.AverageTime) @OutputTimeUnit(TimeUnit.NANOSECONDS) @Fork(jvmArgsAppend = {"-XX:+UseParallelGC", "-Xms1g", "-Xmx1g"}) public class S

Re: [11] RFR JDK-8196127: Dead code in VersionProps.java.template

+1 > On Jan 25, 2018, at 2:33 PM, mandy chung wrote: > > Trivial fix to remove unused isHeadless variable. > > $ hg diff src/java.base/share/classes/java/lang/VersionProps.java.template > diff --git a/src/java.base/share/classes/java/lang/VersionProps.java.template > b/src/java.base/share/class

Re: [11] RFR JDK-8196127: Dead code in VersionProps.java.template

+1 Paul. > On Jan 25, 2018, at 11:33 AM, mandy chung wrote: > > Trivial fix to remove unused isHeadless variable. > > $ hg diff src/java.base/share/classes/java/lang/VersionProps.java.template > diff --git a/src/java.base/share/classes/java/lang/VersionProps.java.template > b/src/java.base/sh

[11] RFR JDK-8196127: Dead code in VersionProps.java.template

Trivial fix to remove unused isHeadless variable. $ hg diff src/java.base/share/classes/java/lang/VersionProps.java.template diff --git a/src/java.base/share/classes/java/lang/VersionProps.java.template b/src/java.base/share/classes/java/lang/VersionProps.java.template --- a/src/java.base/shar

Re: [11] RFR JDK-8168682: jdk/test/java/lang/ClassLoader/forNameLeak/ClassForNameLeak.java fails with -Xcomp

Hi, Mandy Interesting problem. Your changes look fine. (The static finals could be all caps, but I wouldn't bother with further changes just for that.) Thanks, -Brent On 1/24/18 10:15 AM, mandy chung wrote: This patch revises the test to make the phantom reference reachable in order to ens

Re: RFR 8139206: Add InputStream readNBytes(int len)

I have moved the CSR [1] back to Draft and updated it according to the content of webrev.03. If there are no more comments by tomorrow I will move it once again to Finalized. After that, once the CSR has been re-approved, then if there are no further comments on the changes I will go ahead and p

Re: Oracle Java 8u161 regression in XML Schema Factory

On 25/01/2018 11:58, Bernd wrote: Hello, some of our unit tests (using PowerMock and xmlunit) fail with 8u161 (and u162) but work with 8u152. I cant reproduce the fault in a stand-alone program so it seems to be related to classloader/reflection magic of those tools, sorry. Is this a regressi

Oracle Java 8u161 regression in XML Schema Factory

Hello, some of our unit tests (using PowerMock and xmlunit) fail with 8u161 (and u162) but work with 8u152. I cant reproduce the fault in a stand-alone program so it seems to be related to classloader/reflection magic of those tools, sorry. Is this a regression of 8159240