Re: RFR JDK-8196748,tools/jar tests need to tolerate unrelated warnings

Hi Sherman, On 10/03/2018 8:34 AM, Xueming Shen wrote: Hi, Please help codereview the change for JDK-8196748. Issue: https://bugs.openjdk.java.net/browse/JDK-8196748 webrev: http://cr.openjdk.java.net/~sherman/8196748/webrev Those tests are based on parsing the std in/err of the jar command.

Re: RFR 8181594: Efficient and constant-time modular arithmetic

On 2/26/2018 10:39 AM, Adam Petcher wrote: http://cr.openjdk.java.net/~apetcher/8181594/webrev.01/ See inline below. On 2/23/2018 12:46 PM, Xuelei Fan wrote: ArrayUtil.java: === I'm not very sure how widely this utilities will be used in the future. Looks like only BigIntegerMod

Re: [PATCH] Reduce Chance Of Mistakenly Early Backing Memory Cleanup

Hi, On 03/02/18 18:15, Paul Sandoz wrote: Thanks! Paul. On Mar 2, 2018, at 9:11 AM, Vladimir Ivanov wrote: On 3/2/18 8:01 PM, Paul Sandoz wrote: Here’s an update Ben and I tweaked: http://cr.openjdk.java.net/~psandoz/jdk/buffer-reachability-fence/webrev/index.html I think this looks