RFR (XS): 8199768 jdk/test/lib/compiler/CompilerUtils.java needs to provide more control over compilation

2018-03-18 Thread David Holmes
Unsure exactly who should review this ... bug: https://bugs.openjdk.java.net/browse/JDK-8199768 webrev: http://cr.openjdk.java.net/~dholmes/8199768/webrev/ CompilerUtils.compile compiles all source files in a given directory tree into a specific directory. This is done by passing Integer.MAX_V

Re: RFR 8196298 Add null Reader and Writer with latest changes

2018-03-18 Thread Patrick Reinhart
Hi Roger, Seems there are no more comments...   - all shocked :-) -Patrick Am 16.03.2018 um 16:21 schrieb Roger Riggs: > Hi Patrick, > > Looks good, > > If there are no more comments, I can sponsor the commit. > > Thanks, Roger > > > On 3/16/18 2:10 AM, Patrick Reinhart wrote: >> Just coming bac

[PATCH] unnecessary null check inside of java.lang.Boolean.valueOf(String)

2018-03-18 Thread Сергей Цыпанов
Hi, currently (JDK 9.0.4) j.l.Boolean.valueOf(String) contains this code: public static boolean parseBoolean(String s) {   return ((s != null) && s.equalsIgnoreCase("true")); } Null check here seems to be redundant, as String.equalsIgnoreCase does it itself: public boolean equalsIgnoreCase(Str