Hi Roger,
On 19/03/2018 11:55 PM, Roger Riggs wrote:
Hi Alan,
The original changeset [1] is most easily viewed in the jdk-8u repo.
The comment and placement of the removes of the properties and the code
to re-set them
around the call to the JVM_InitProperties (which sets properties from the
Thanks for looking at this Alan!
On 20/03/2018 3:23 AM, Alan Bateman wrote:
On 19/03/2018 05:11, David Holmes wrote:
Unsure exactly who should review this ...
bug: https://bugs.openjdk.java.net/browse/JDK-8199768
webrev: http://cr.openjdk.java.net/~dholmes/8199768/webrev/
CompilerUtils.compil
Thanks Paul!
David
On 20/03/2018 3:18 AM, Paul Sandoz wrote:
Looks ok, +1
Paul.
On Mar 18, 2018, at 10:11 PM, David Holmes wrote:
Unsure exactly who should review this ...
bug: https://bugs.openjdk.java.net/browse/JDK-8199768
webrev: http://cr.openjdk.java.net/~dholmes/8199768/webrev/
Co
On 3/19/18 12:32 PM, Martin Buchholz wrote:
*/
public boolean equals(Object obj) {
if (obj instanceof Boolean) {
- return value == ((Boolean)obj).booleanValue();
+ return value == (Boolean) obj;
}
This is not correct, since we might have multiple Boolean object
Hi Rachna,
Thanks for the updates; looks good,
Roger
On 3/13/2018 5:28 AM, Rachna Goel wrote:
Hi Roger, Ivan,
There is no change in algorithm as such but there has been mainly
stability improvements, defects fixed, performance enhancements. e.g
Updated header check, version and loading fo
+1
Naoto
On 3/19/18 1:12 PM, Roger Riggs wrote:
Hi Rachna,
Thanks for the updates; looks good,
Roger
On 3/13/2018 5:28 AM, Rachna Goel wrote:
Hi Roger, Ivan,
There is no change in algorithm as such but there has been mainly
stability improvements, defects fixed, performance enhancements
It's surprising that both variants don't perform the same when JIT compiled.
On Mon, Mar 19, 2018 at 3:32 PM, Martin Buchholz
wrote:
> >
> > */
> > public boolean equals(Object obj) {
> > if (obj instanceof Boolean) {
> > - return value == ((Boolean)obj).booleanValue();
> > +
>
> */
> public boolean equals(Object obj) {
> if (obj instanceof Boolean) {
> - return value == ((Boolean)obj).booleanValue();
> + return value == (Boolean) obj;
> }
>
>
This is not correct, since we might have multiple Boolean objects that are
equals, but not ==.
Do w
On Sun, Mar 18, 2018 at 2:57 AM Сергей Цыпанов
wrote:
Сергей, Спасибо.
https://bugs.openjdk.java.net/browse/JDK-8199800
On 19/03/2018 05:11, David Holmes wrote:
Unsure exactly who should review this ...
bug: https://bugs.openjdk.java.net/browse/JDK-8199768
webrev: http://cr.openjdk.java.net/~dholmes/8199768/webrev/
CompilerUtils.compile compiles all source files in a given directory
tree into a specific directo
Looks ok, +1
Paul.
> On Mar 18, 2018, at 10:11 PM, David Holmes wrote:
>
> Unsure exactly who should review this ...
>
> bug: https://bugs.openjdk.java.net/browse/JDK-8199768
> webrev: http://cr.openjdk.java.net/~dholmes/8199768/webrev/
>
> CompilerUtils.compile compiles all source files in a
Bump :)
Best Regards
Adam Farley
Last email
Hi Alan
Thanks for getting back to me on this. :)
I've changed the hg_diff as described below, see the attached.
> On 27/02/2018 15:04, Adam Farley8 wrote:
>
> Resending. Bump. :)
>
> On 14/02/2018 14:13, Adam Farley8 wrote:
>>> Hi Al
Hi Patrick,
Committed; Thanks for the initiative and the perseverance.
Roger
On 3/18/2018 6:41 AM, Patrick Reinhart wrote:
Hi Roger,
Seems there are no more comments... - all shocked :-)
-Patrick
Hi Alan,
The original changeset [1] is most easily viewed in the jdk-8u repo.
The comment and placement of the removes of the properties and the code
to re-set them
around the call to the JVM_InitProperties (which sets properties from the
-D arguments among others), seem to indicate that the p
Hi,
On Fri, 2018-03-16 at 17:19 +, Ian Rogers wrote:
> Thanks Paul, very interesting.
>
> On Fri, Mar 16, 2018 at 9:21 AM Paul Sandoz
> wrote:
> > Hi Ian, Thomas,
> >
> > [...]
> > (This is also something we need to consider if we modify buffers to
> > support capacities larger than Integer
15 matches
Mail list logo
