Re: [11] RFR: 8191410 : Unicode 10.0.0

Thanks Rachna! On 3/13/18 2:28 AM, Rachna Goel wrote: Hi Roger, Ivan, There is no change in algorithm as such but there has been mainly stability improvements, defects fixed, performance enhancements. e.g Updated header check, version and loading for latest binary files, Simple case mappin

Re: RFR: Here are some Thread cleanup patches

On 28/03/2018 4:28 AM, Martin Buchholz wrote: > The usual story when I change Thread.java is that I'm missing something and > I end up reverting, so I was extra careful this time. > > 8200122: Remove unused field Thread.threadQ > http://cr.openjdk.java.net/~martin/webrevs/jdk/Thread-threadQ/ > h

Re: RFR: Here are some Thread cleanup patches

On 3/28/18 2:37 PM, Peter Levart wrote: Hi, As far as I think (but please prove me wrong), Stable class is not loaded until someone explicitly asks for it in Java code (referring to Stable type in bytecode like with Stable.class literal or parsing annotations of a field that contains such a

Re: RFR: JDK-8200178 Remove mapfiles for JDK native libraries

On 2018-03-28 01:52, Weijun Wang wrote: On Mar 24, 2018, at 6:03 AM, Magnus Ihse Bursie wrote: https://bugs.openjdk.java.net/browse/JDK-8200193 -- for jdk.security.auth There is only one function to export and it already has JNIEXPORT, so you can just remove the new $(LIBJAAS_CFLAGS) [1].

Re: RFR: Here are some Thread cleanup patches

On 03/28/2018 11:32 AM, mandy chung wrote: On 28/03/2018 4:28 AM, Martin Buchholz wrote: > The usual story when I change Thread.java is that I'm missing something and > I end up reverting, so I was extra careful this time. > > 8200122: Remove unused field Thread.threadQ > http://cr.openjdk.ja

Re: RFR: Here are some Thread cleanup patches

On 3/28/18 6:34 PM, Peter Levart wrote: On 03/28/2018 11:32 AM, mandy chung wrote: On 28/03/2018 4:28 AM, Martin Buchholz wrote: > The usual story when I change Thread.java is that I'm missing something and > I end up reverting, so I was extra careful this time. > > 8200122: Remove unused

Re: [JDK-6341887] RFR: Patch V3: java.util.zip: Add ByteBuffer methods to Inflater/Deflater

On Tue, Mar 27, 2018 at 11:59 AM, David Lloyd wrote: > On Tue, Mar 27, 2018 at 10:10 AM, Alan Bateman > wrote: >> On 27/03/2018 00:09, David Lloyd wrote: >>> I was going for some kind of consistency with the array variants (that >>> is, name the parameter what it is), though they simply use "b"

Re: RFR: 8200238: Reduce number of exceptions created when calling MemberName$Factory::resolveOrNull

Claes, Thank you for this fix. Glad it makes a startup difference. Agree with Lois. thanks, Karen p.s. haven’t had a chance to trace the logic of your explanation below in a debugger - I don’t quite follow it. But the fix makes sense. > On Mar 27, 2018, at 11:57 AM, Lois Foltan wrote: > > On

Re: RFR 8197595: Serialization javadoc should link to security best practices

Hi, Updated with editorial suggestions. webrev: http://cr.openjdk.java.net/~rriggs/webrev-serialwarn-8197595/index.html javadoc: http://cr.openjdk.java.net/~rriggs/serialwarn/api/java.base/java/io/package-summary.html

Re: RFR: Here are some Thread cleanup patches

On Wed, Mar 28, 2018 at 4:30 AM, mandy chung wrote: > > I was wondering how Martin made the decision to mark it with @Stable. In > addition to the above, the ID is mostly used in tracing. I'd like to see > performance number for adding @Stable. > OK, I had "no good reason" for using @Stable her

Re: RFR 8197595: Serialization javadoc should link to security best practices

Hi Roger, Looks good to go to me! Best Lance > On Mar 28, 2018, at 1:27 PM, Roger Riggs wrote: > > Hi, > > Updated with editorial suggestions. > > webrev: > http://cr.openjdk.java.net/~rriggs/webrev-serialwarn-8197595/index.html >

Re: RFR: JDK-8200178 Remove mapfiles for JDK native libraries

Build changes still look good to me. /Erik On 2018-03-28 03:31, Magnus Ihse Bursie wrote: On 2018-03-28 01:52, Weijun Wang wrote: On Mar 24, 2018, at 6:03 AM, Magnus Ihse Bursie wrote: https://bugs.openjdk.java.net/browse/JDK-8200193 -- for jdk.security.auth There is only one function t

Re: RFR: JDK-8200178 Remove mapfiles for JDK native libraries

I can't find any documentation for what JNIEXPORT and friends actually do. People including myself have been cargo-culting JNIEXPORT and JNICALL for decades. Why aren't they in the JNI spec? --- It's fishy that the attribute externally_visible (which seems very interesting!) is ARM specific. #

Re: RFR: JDK-8200178 Remove mapfiles for JDK native libraries

On 2018-03-28 23:53, Martin Buchholz wrote: I can't find any documentation for what JNIEXPORT and friends actually do. People including myself have been cargo-culting JNIEXPORT and JNICALL for decades. Why aren't they in the JNI spec? That surprises me. I'm quite certain that javah (or rather,

Re: RFR: Here are some Thread cleanup patches

On 3/29/18 1:54 AM, Martin Buchholz wrote: On Wed, Mar 28, 2018 at 4:30 AM, mandy chung > wrote: I was wondering how Martin made the decision to mark it with @Stable. In addition to the above, the ID is mostly used in tracing.  I'd like to see per

RFR 8196668: revisit test SunPackageAccess and GrantedSunPackageAccess

Please review the change to merge 2 package access tests and move to OpenJDK, thanks bug: https://bugs.openjdk.java.net/browse/JDK-8196668 webrev: http://cr.openjdk.java.net/~xyin/8196668/webrev.00/

Re: [JDK-6341887] RFR: Patch V3: java.util.zip: Add ByteBuffer methods to Inflater/Deflater

On 3/28/18, 6:14 AM, David Lloyd wrote: The current wording (which pre-dates your changes of course) reads more like API advice. I think it's a bit confusing too as it doesn't define what a "flush marker" is. I think we will need to re-word that sentence to make it clearer. OK. I am at a loss

Re: RFR 8196668: revisit test SunPackageAccess and GrantedSunPackageAccess

On 3/29/18 9:59 AM, Chris Yin wrote: Please review the change to merge 2 package access tests and move to OpenJDK, thanks bug: https://bugs.openjdk.java.net/browse/JDK-8196668 webrev: http://cr.openjdk.java.net/~xyin/8196668/webrev.00/

Re: RFR 8196668: revisit test SunPackageAccess and GrantedSunPackageAccess

Thank you, Mandy. I just fixed it follow your comments and get it pushed. Regards, Chris > On 29 Mar 2018, at 12:48 PM, mandy chung > wrote: > > > > On 3/29/18 9:59 AM, Chris Yin wrote: >> Please review the change to merge 2 package access tests and move to >>

Re: RFR: JDK-8200178 Remove mapfiles for JDK native libraries

On Wed, Mar 28, 2018 at 3:14 PM, Magnus Ihse Bursie < magnus.ihse.bur...@oracle.com> wrote: > On 2018-03-28 23:53, Martin Buchholz wrote: > > I can't find any documentation for what JNIEXPORT and friends actually do. > People including myself have been cargo-culting JNIEXPORT and JNICALL for > dec