RFR: More cleanup patches

2018-03-31 Thread Сергей Цыпанов
Hi Martin, as soon as the changes for 8199800: Optimize Boolean.parseBoolean(String) are merged we could replace code snippets like if (aValue.toUpperCase().equals("TRUE")) { value = Boolean.TRUE; } else { value = Boolean.FALSE; } with value = Boolean.parseBoolean(aValue); See javax.swin

Re: Coding conventions for core-libs-dev

2018-03-31 Thread Mario Torre
As a special exception, if you commit tomorrow, you can use CRLF ;) Cheers, Mario On Sat 31. Mar 2018 at 17:30, wrote: > On 2018-03-31 16:51, Mario Torre wrote: > > Yes, but please try to keep the 80 columns (as per the document Remi > > suggested, unless it kills readability). It seems archaic,

Re: Coding conventions for core-libs-dev

2018-03-31 Thread raffaello . giulietti
On 2018-03-31 16:51, Mario Torre wrote: > Yes, but please try to keep the 80 columns (as per the document Remi > suggested, unless it kills readability). It seems archaic, but not so > much when you review patches and read code on a mobile device. Lots of > people also like to keep their monitors i

Re: Coding conventions for core-libs-dev

2018-03-31 Thread Mario Torre
Yes, but please try to keep the 80 columns (as per the document Remi suggested, unless it kills readability). It seems archaic, but not so much when you review patches and read code on a mobile device. Lots of people also like to keep their monitors in portrait mode, which means less real estate fo

Re: Coding conventions for core-libs-dev

2018-03-31 Thread Remi Forax
http://cr.openjdk.java.net/~alundblad/styleguide/index-v6.html is the closest you can find as an official coding convention for the OpenJDK. Rémi - Mail original - > De: "raffaello giulietti" > À: "core-libs-dev" > Envoyé: Samedi 31 Mars 2018 16:24:53 > Objet: Coding conventions for cor

Coding conventions for core-libs-dev

2018-03-31 Thread raffaello . giulietti
Hi, are there any Java coding conventions to follow? I found very outdated guidelines at http://www.oracle.com/technetwork/java/javase/documentation/codeconvtoc-136057.html with ab archaic line limitation of 80 or even 70 chars/line. Are there official, semi-official or suggested documents? G