Re: RFR: Some patches for sherman

On 04/02/18 20:01, Martin Buchholz wrote: On Fri, Mar 30, 2018 at 6:31 PM, Martin Buchholz > wrote: Thanks, John. I need to adjust my expectations. The word "constant" means something different to hotspot engineers. I'm still hoping to someday si

Re: RFR: 8164781: Pattern.asPredicate specification is incomplete

On Sun, Apr 1, 2018 at 3:56 AM, Uwe Schindler wrote: > > In general, I'd prefer to have a predicate that uses matches() instead of > find(). In my code I have never used find() because in most cases you want > to match the whole string anyways. Of course you can use ^ and $ but I > don't like tha

Re: RFR: Some patches for sherman

On Fri, Mar 30, 2018 at 6:31 PM, Martin Buchholz wrote: > Thanks, John. > I need to adjust my expectations. The word "constant" means something > different to hotspot engineers. > > I'm still hoping to someday simply say, > "here's a final field - just go ahead and trust that it's truly final" >

Re: RFR: 8164781: Pattern.asPredicate specification is incomplete

Hi, Looks good, expect for: 5823 * @return The predicate which can be used for finding on a string “finding on a… ” is a little awkward to parse . I recommend to either change it back, since the first sentence of the method doc says what it means by matches, or being a little more verbos

RFR of JDK-8188897: java/rmi/registry/reexport/Reexport.java failed with Port already in use

would you please review the following patch? bug: https://bugs.openjdk.java.net/browse/JDK-8188897 webrev: http://cr.openjdk.java.net/~mli/8188897/webrev.00/ Thank you -Hamlin