Hi Martin!
Ah bummer! Missing @modules java.base/java.util:open in the test.
Sorry about that.
Let me fix it with the fix for a similar issue JDK-8200788 that I've
just filed.
With kind regards,
Ivan
On 4/4/18 9:24 PM, Martin Buchholz wrote:
Hi Ivan,
I'm seeing
[2018-04-04 20:56:11,999]
Hi Ivan,
I'm seeing
[2018-04-04 20:56:11,999] Agent[1]: stderr: WARNING: An illegal reflective
access operation has occurred
[2018-04-04 20:56:11,999] Agent[1]: stderr: WARNING: Illegal reflective
access by jdk.testlibrary.OptimalCapacity
(file:/tmp/jtr-BHhgGo/classes/lib/testlibrary/) to field
ja
On Fri, Mar 30, 2018 at 3:53 AM, Alan Bateman
wrote:
>
> 8200125: Fix some classloader/module typos
>> http://cr.openjdk.java.net/~martin/webrevs/jdk/loader-typos/
>> https://bugs.openjdk.java.net/browse/JDK-8200125
>>
> Most of these are okay but you've dropped the text "defined to this
> ClassL
Thanks, Joe,
The use of @exception is pervasive in this file, so I think consistency
wins over localized stylistic changes. But yes, maybe we should do more
global updates at some point.
-- Jon
On 04/04/2018 05:24 PM, Joseph D. Darcy wrote:
Looks fine; even better if @exception is replaced
Looks fine; even better if @exception is replaced with @throws :-)
-Joe
On 4/4/2018 5:21 PM, Jonathan Gibbons wrote:
Please review this tiny fix to a typo in the name of an exception in
@throws:
No webrev; here's the change: NullPointerExcpetion ->
NullPointerException
diff -r 3930c4d4f805
+1
Brian
On Apr 4, 2018, at 5:21 PM, Jonathan Gibbons
wrote:
> Please review this tiny fix to a typo in the name of an exception in @throws:
>
> […]
>
> JBS: https://bugs.openjdk.java.net/browse/JDK-8200888
Please review this tiny fix to a typo in the name of an exception in
@throws:
No webrev; here's the change: NullPointerExcpetion -> NullPointerException
diff -r 3930c4d4f805
src/java.base/share/classes/java/text/ChoiceFormat.java
--- a/src/java.base/share/classes/java/text/ChoiceFormat.java We
> On 22 Mar 2018, at 07:18, Kumar Srinivasan
> wrote:
>
> David,
>
> Why would the VM emit these warnings if the deprecated vm flag
> is not being used ?
>
> Andrey,
> As for the reviews I am ok with InfoStreams, wrt. ToolOpts it is not at all
> apparent,
> maybe more comments explaining wh
Thanks David and Claes!
I changed the expression to (int)(universe.length / 0.75f) + 1 before
pushing the fix and updated the Jira bug with more details.
With kind regards,
Ivan
On 4/3/18 11:56 PM, Claes Redestad wrote:
Hi Ivan,
looks good.
Nit: maybe (int)(universe.length / 0.75f) + 1 t
Hi All,
Please review.
Bug: https://bugs.openjdk.java.net/browse/JDK-8184692
Webrev : http://cr.openjdk.java.net/~vtheeyarath/8184692/webrev.00/
The related jtreg test was run and the test passed .
Regards
Vivek
> On Apr 3, 2018, at 11:54 PM, Vivek Theeyarath
> wrote:
>
> Hi,
> I have incorporated the changes as per the feedback and here is the
> updated webrev .
> http://cr.openjdk.java.net/~rraghavan/8164781/webrev.02/ .
> Bug: https://bugs.openjdk.java.net/browse/JDK-8164781
>
+1
I know
Just note the LDIF expect the LDAP server running at:
ldap://localhost:10389/dc=example,dc=com
The "ref" needs to reference the same server to create referrals loop.
If you are unable to reproduce, does it produce LimitExceededException for you?
On Wed, Apr 4, 2018 at 6:05 PM, Jan Kalina wrote:
On Fedora 27, using latest Apache Directory Studio
(ApacheDirectoryStudio-2.0.0.v20170904-M13-linux.gtk.x86_64.tar.gz)
created new Apache DS 2.0.0, imported referrals.ldif
and running JI9048012.java:
export JAVA_HOME=/opt/jdk-9_linux-x64_bin/
$JAVA_HOME/bin/java JI9048012
>>>ou=test
>>>
>>>ldap://
Hi All,
I've attached the code to resolve JDK-8190187
Could a committer please take the fix (amended code attached, and
available on request) and:
1) Complete the CSR process for the new JNI Return code.
2) Commit the changes that contain the Return code.
And, optionally, 3) Perform 1 and 2
On 4/4/2018 8:59 PM, Jan Kalina wrote:
Note: Test is not included, as it would require running LDAP server.
(existing ldap tests in JDK use only mocks of the server)
The patch was manually verified using reproducer attached to issue.
Hi Jan,
I ran the reproducer long back on my Linux box(Ubu
Note: Test is not included, as it would require running LDAP server.
(existing ldap tests in JDK use only mocks of the server)
The patch was manually verified using reproducer attached to issue.
On Wed, Apr 4, 2018 at 4:12 PM, Jan Kalina wrote:
> Hi,
> I has prepared trivial patch for bug JDK-81
Hi Andrew,
The function itself seems straightforward enough.
Can you clarify the boundary that you are replacing? The initialization
has a lot of
intermingled responsibilities and is quite sensitive.
What else needs to be said about when it can be called and who should be
calling it?
I do
Hi Hamlin,
Reexport.java:
I think this change to use a separate process for the 2nd registry
changes the test so that it does not
address the original test case. The original problem was the incorrect
retention of an object in
the object table when the create of a registry in the same proces
On 04/04/2018 15:06, David Lloyd wrote:
Actually I've talked to Jan and we're going to try again with the more
correct subject line & RFR. Thanks.
It would be good to see if a test can be developed too.
-Alan
Hi,
I has prepared trivial patch for bug JDK-8176553,
which I would like to get reviewed and sponsored.
I am covered by Red Hat OCA.
The bug affects upstream, JDK9 and JDK8 too.
The reproducer is available in issue tracker:
https://bugs.openjdk.java.net/browse/JDK-8176553
PATCH:
---
Actually I've talked to Jan and we're going to try again with the more
correct subject line & RFR. Thanks.
On Wed, Apr 4, 2018 at 8:51 AM, David Lloyd wrote:
> Is there anyone who would be willing to sponsor this change?
>
> On Tue, Jan 23, 2018 at 4:58 PM, Jan Kalina wrote:
>> Hi,
>> I has pre
Is there anyone who would be willing to sponsor this change?
On Tue, Jan 23, 2018 at 4:58 PM, Jan Kalina wrote:
> Hi,
> I has prepared trivial patch for bug JDK-8176553, which I has reported.
>
> I will welcome if it could be merged into JDK.
> (The bug is present in JDK9 and JDK8 too.)
> I am co
Hi,
I would like to propose and find a sponsor for this change please, which
is is export from libjava the JNU_InitializeEncoding() method, so that a
JVM can initialize the platform encoding. Currently
Java_java_lang_System_initProperties initializes the encoding, however for
a generic JVM tha
Thank you Jan.
Thanks,
Amy
On 04/04/2018 4:37 PM, Jan Lahoda wrote:
Hi,
Ok to problem list.
Jan
On 4.4.2018 05:26, Amy Lu wrote:
jdk/jshell/ExceptionsTest.java
This test has been failing on Windows (JDK-8200701) since the push for
JDK-8198801. The test needs to be problem listed on Windows
[Including core-libs-dev]
Quick review needed.
bug: https://bugs.openjdk.java.net/browse/JDK-8200703
webrev: http://cr.openjdk.java.net/~amlu/8200703/webrev.00/
Thanks,
Amy
On 04/04/2018 11:26 AM, Amy Lu wrote:
jdk/jshell/ExceptionsTest.java
This test has been failing on Windows (JDK-8200701
25 matches
Mail list logo
