RFR 8197418: Move java/util/RandomAccess/ tests into OpenJDK

Please review the change to move java/util/RandomAccess/Basic.java test into OpenJDK, it increases code coverage of open jdk_util test group per JCov run, the main improvement is on java.util.Collections with %method up 1% and %block up 2%, thanks bug: https://bugs.openjdk.java.net/browse/JDK-8

Re: [JDK-6341887] RFR: Patch V3: java.util.zip: Add ByteBuffer methods to Inflater/Deflater

Hi David, The CSR has been approved https://bugs.openjdk.java.net/browse/JDK-8200527 API docs have been updated slightly based on the review suggestion. (1) added some words in the class spec for both Inflater and Deflater. |* * This class deflates sequences of bytes into ZLIB compressed data

Re: stripIndent() behavior

I think this is "throwing" the baby out with the bathwater.  It is punishing those who can use tabs responsibly for the sins of those who cannot. You have to commit three sins before you have a problem:  - using tabs at all  - using tabs inconsistently across the lines of a single expression;  

Re: stripIndent() behavior

On 4/10/2018 5:18 PM, Kevin Bourrillion wrote: On Tue, Apr 10, 2018 at 1:50 PM, Brian Goetz > wrote: 3. If the input contains *any* tab characters at all (except any that are part of the trailing whitespace), then this method cannot know

Re: stripIndent() behavior

On Tue, Apr 10, 2018 at 1:50 PM, Brian Goetz wrote: > > > 3. If the input contains *any* tab characters at all (except any that are >> part of the trailing whitespace), then this method cannot know that it >> isn't jumbling the end result, and maybe it should just throw. >> > I think there's a mid

Re: stripIndent() behavior

(now stripIndent) I've accumulated a few questions/comments on this. 1. When choosing the amount to trim, it ought to ignore blank lines and only-whitespace lines, right? Seems right. 2. Is it really appropriate to automatically remove trailing whitespace? I'm not sure about this either

Re: RFR: 8178867: tools/jlink/multireleasejar/JLinkMultiReleaseJarTest.java failed to clean up files

On 10/04/2018 20:03, Andrey Nazarov wrote: On 10 Apr 2018, at 11:47, Alan Bateman wrote: On 10/04/2018 19:44, Andrey Nazarov wrote: Anyone? On 6 Apr 2018, at 17:10, Andrey Nazarov wrote: Hi, Please review fix in Jlink test. The fix is to close the Stream which works with a file syste

Re: RFR: 8178867: tools/jlink/multireleasejar/JLinkMultiReleaseJarTest.java failed to clean up files

> On Apr 10, 2018, at 11:47 AM, Alan Bateman wrote: > > On 10/04/2018 19:44, Andrey Nazarov wrote: >> Anyone? >> >>> On 6 Apr 2018, at 17:10, Andrey Nazarov wrote: >>> >>> Hi, >>> >>> Please review fix in Jlink test. The fix is to close the Stream which works >>> with a file system. >>> >

Re: RFR: 8178867: tools/jlink/multireleasejar/JLinkMultiReleaseJarTest.java failed to clean up files

> On 10 Apr 2018, at 11:47, Alan Bateman wrote: > > On 10/04/2018 19:44, Andrey Nazarov wrote: >> Anyone? >> >>> On 6 Apr 2018, at 17:10, Andrey Nazarov wrote: >>> >>> Hi, >>> >>> Please review fix in Jlink test. The fix is to close the Stream which works >>> with a file system. >>> >>> R

Re: RFR: 8178867: tools/jlink/multireleasejar/JLinkMultiReleaseJarTest.java failed to clean up files

+1 On 4/10/18 11:44 AM, Andrey Nazarov wrote: Anyone? On 6 Apr 2018, at 17:10, Andrey Nazarov wrote: Hi, Please review fix in Jlink test. The fix is to close the Stream which works with a file system. Review: http://cr.openjdk.java.net/~anazarov/JDK-8178867/webrev.01

Re: RFR: 8178867: tools/jlink/multireleasejar/JLinkMultiReleaseJarTest.java failed to clean up files

On 10/04/2018 19:44, Andrey Nazarov wrote: Anyone? On 6 Apr 2018, at 17:10, Andrey Nazarov wrote: Hi, Please review fix in Jlink test. The fix is to close the Stream which works with a file system. Review: http://cr.openjdk.java.net/~anazarov/JDK-8178867/webrev.01

Re: RFR: 8178867: tools/jlink/multireleasejar/JLinkMultiReleaseJarTest.java failed to clean up files

Anyone? > On 6 Apr 2018, at 17:10, Andrey Nazarov wrote: > > Hi, > > Please review fix in Jlink test. The fix is to close the Stream which works > with a file system. > > Review: http://cr.openjdk.java.net/~anazarov/JDK-8178867/webrev.01 >

Re: RFR [10] 8194554: filterArguments runs multiple filters in the wrong order

On 04/10/2018 06:40 PM, Paul Sandoz wrote: > Here we go: > >   https://bugs.openjdk.java.net/browse/JDK-8201371 > > Kindly requesting a reviewer. Not sure if that counts for CSR, but added myself as Reviewer there. -Aleksey

Re: RFR [10] 8194554: filterArguments runs multiple filters in the wrong order

> On Apr 10, 2018, at 3:21 AM, Aleksey Shipilev wrote: > > On 04/10/2018 08:42 AM, Alan Bateman wrote: >> On 09/04/2018 18:58, Paul Sandoz wrote: >>> I am supportive of this change (the risk to impacting order-dependent >>> stateful MH filter code is >>> smaller than the risk of hitting a stri

Re: [11] RFR: 8189784: Parsing with Java 9 AKST timezone returns the SystemV variant of the timezone

This looks very good. Thanks! (reviewed build part) /Erik On 2018-04-09 18:00, naoto.s...@oracle.com wrote: Thanks, Erik. Modified GensrcCLDR.gmk as suggested: http://cr.openjdk.java.net/~naoto/8189784/webrev.03/ Naoto On 4/9/18 4:15 PM, Erik Joelsson wrote: Hello Naoto, Looks good, just

Re: RFR of JDK-8188897: java/rmi/registry/reexport/Reexport.java failed with Port already in use

Hi Hamlin, Looks good, Thanks for the updates. On 4/9/2018 10:49 PM, Hamlin Li wrote: On 10/04/2018 3:09 AM, Roger Riggs wrote: Hi Hamlin, Hi Roger, Thank you for review. Great, the new busy port algorithm looks better. The port assigned will always be one that was available and is now

Re: RFR [10] 8194554: filterArguments runs multiple filters in the wrong order

On 04/10/2018 08:42 AM, Alan Bateman wrote: > On 09/04/2018 18:58, Paul Sandoz wrote: >> I am supportive of this change (the risk to impacting order-dependent >> stateful MH filter code is >> smaller than the risk of hitting a string concatenation bug). (We erred on >> the side of this being >> a

Re: RFR 8201348, ProblemList update for bugid associated with SSLSocketParametersTest.sh

+1 > On Apr 9, 2018, at 11:15 PM, Felix Yang wrote: > > Hi, > > please review a minor change on the associated bug id in ProblemList.txt. > > Bug: > > https://bugs.openjdk.java.net/browse/JDK-8201348 > > Patch: > > diff -r f088ec60bed5 test/jdk/ProblemList.txt > --- a/test/jdk/Proble

Re: RFR: Export InitializeEncoding for JVM access

Many thanks Roger, much appreciated. Cheers Andrew Andrew Leonard Java Runtimes Development IBM Hursley IBM United Kingdom Ltd Phone internal: 245913, external: 01962 815913 internet email: andrew_m_leon...@uk.ibm.com From: Roger Riggs To: Andrew Leonard Cc: core-libs-dev@openjdk.