I guess we also need to get an approval from core-libs (cc'd) as libzip
and libjimage are modified.
Regards,
Alexey
On 11/04/2018 10:56, Alexey Ivanov wrote:
The change looks good to me.
On 11/04/2018 10:20, Baesken, Matthias wrote:
Was main() exported via map files?
Seems main was exporte
That's great news, thanks! I'll pull down your updates just so my
local copy does not get out of date in the meantime.
On Tue, Apr 10, 2018 at 10:49 PM, Xueming Shen wrote:
> Hi David,
>
> The CSR has been approved
> https://bugs.openjdk.java.net/browse/JDK-8200527
>
> API docs have been updated
Hi,
Mind if I bike shed on this one since everyone else it?
A tab is white space of undefined length. Traditionally, tabs are the
responsibility of the device (move forward software) to implement. This is why
you *set* tabs. As such… it seems very reasonable that people don’t expect nor
shoul
Hi Chris,
+1, and thanks for sharing code coverage results.
Paul.
> On Apr 10, 2018, at 11:33 PM, Chris Yin wrote:
>
> Please review the change to move java/util/RandomAccess/Basic.java test into
> OpenJDK, it increases code coverage of open jdk_util test group per JCov run,
> the main impr
OK, well I think we do agree that at least stripIndent should be changed to
remove the longest exact whitespace prefix common to all lines? So if you
give it one line starting with 8 spaces and another starting with a tab it
will return the string unchanged. The current behaviour just counts
whites
HI,
Hopefully this is the last update :-)
To align with asPredicate and Roger’s prior guidance on that method i think you
can just say this:
Creates a predicate that tests if this pattern matches a given input string.
which is similar to the language of Pattern.matches.
No need for another
Hello,
Could I get a review to update the launcher help message.
https://bugs.openjdk.java.net/browse/JDK-8198793
diff --git
a/src/java.base/share/classes/sun/launcher/resources/launcher.properties
b/src/java.base/share/classes/sun/launcher/resources/launcher.properties
--- a/src/java.base/s
Looks good.
-Sundar
On 12/04/18, 2:13 AM, Kumar Srinivasan wrote:
Hello,
Could I get a review to update the launcher help message.
https://bugs.openjdk.java.net/browse/JDK-8198793
diff --git
a/src/java.base/share/classes/sun/launcher/resources/launcher.properties
b/src/java.base/share/clas
Thank you, Paul
Regards,
Chris
> On 12 Apr 2018, at 2:10 AM, Paul Sandoz wrote:
>
> Hi Chris,
>
> +1, and thanks for sharing code coverage results.
>
> Paul.
>
>
>> On Apr 10, 2018, at 11:33 PM, Chris Yin wrote:
>>
>> Please review the change to move java/util/RandomAccess/Basic.java test
would you please review the following patch?
bug: https://bugs.openjdk.java.net/browse/JDK-8078221
webrev: http://cr.openjdk.java.net/~mli/8078221/webrev.00/
Thank you
-Hamlin
10 matches
Mail list logo