Re: uploading of new code

2018-04-19 Thread Raffaello Giulietti
On 2018-04-18 19:42, mark.reinh...@oracle.com wrote: 2018/4/18 10:27:36 -0700, e...@zusammenkunft.net: Hello, I would put it on a standalone Git repo on one of the public hosting sites lile.Github, especially for a first discussion (especially good if added JMH comparisions). I would not expect

RFR of JDK-8201469,test under java/rmi should be restricted to not run concurrently

2018-04-19 Thread Hamlin Li
would you please review the following patch? bug: https://bugs.openjdk.java.net/browse/JDK-8201469 http://cr.openjdk.java.net/~mli/8201469/webrev.00/ ( For othervm.dirs property, I just reformat it. ) In my test result, with jtreg option "-concurrency:4", after apply the patch, tier3 tests o

Re: [JDK-6341887] RFR: Patch V3: java.util.zip: Add ByteBuffer methods to Inflater/Deflater

2018-04-19 Thread David Lloyd
OK thanks for the update. It seems odd to me - C99 has been around for a pretty long time - but, as long as the change goes in, I'm happy. Thanks! On Thu, Apr 19, 2018 at 1:13 AM, Xueming Shen wrote: > David, > > webrev has been updated to address the compiler error on solaris-sparcv9. > The C

Re: [JDK-6341887] RFR: Patch V3: java.util.zip: Add ByteBuffer methods to Inflater/Deflater

2018-04-19 Thread Alan Bateman
On 19/04/2018 13:16, David Lloyd wrote: OK thanks for the update. It seems odd to me - C99 has been around for a pretty long time - but, as long as the change goes in, I'm happy. Thanks! I think this is about the compiler options that are used by the build, specifically when compiling JNI cod

RE: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-19 Thread Lindenmaier, Goetz
Hi, New webrev: http://cr.openjdk.java.net/~goetz/wr18/8201593-lenInAIOOB/02/ I admit my wording is not optimal. It's because I extracted this change from a bigger one. Our message reads like this: Object [] oa1 = new Object[10] oa1[12] "ArrayIndexOutOfBoundsException while trying to load from i

Re: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-19 Thread Andrew Haley
On 04/18/2018 03:30 PM, Roger Riggs wrote: > Which roughly reads as: > > Index %d out-of-bounds for length %d "out-of-bounds" shouldn't be hyphenated because it's not a compound adjective. Besides that, it's unnecessary because you already know its an ArrayIndexOutOfBoundsException. I

Re: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-19 Thread Roger Riggs
Hi David, A private constructor that is apparently unused (because it is used implicitly by code buried in HotSpot) is going to raise questions. Strictly speaking the new constructor is not necessary since the native code can compose the full message and use the existing constructor. I'd rec

JDK-6202130: java.util.jar.Attributes.writeMain() can't handle multi-byte chars

2018-04-19 Thread Philipp Kunz
Hi, I tried to fix bug 6202130 about manifest utf support and come up now with a test as suggested in the bug's comments that shows that utf charset actually works before removing the comments from the code. When I wanted to remove the XXX comments about utf it occurred to me that version at

Re: InetAddress.getByName/getAllByName for empty host string

2018-04-19 Thread Jaikiran Pai
Hi Chris, On 16/04/18 9:33 PM, Chris Hegarty wrote: Jaikiran, On 13/04/18 16:29, Jaikiran Pai wrote: Hi Chris, Thank you creating that JIRA. If the fix involves just updating the javadoc, is this something that youwould like me to contribute as a patch? I have a signed and approved OCA, bu

Re: InetAddress.getByName/getAllByName for empty host string

2018-04-19 Thread Alan Bateman
On 20/04/2018 05:37, Jaikiran Pai wrote: : The change will require a CSR, but I can do that on your behalf. Thank you, can you please file one (if it can be done before a patch is submitted)? I'm in the process of creating the patch and will send it out to this list soon. Best to send it to

Re: InetAddress.getByName/getAllByName for empty host string

2018-04-19 Thread Jaikiran Pai
On 20/04/18 11:24 AM, Alan Bateman wrote: On 20/04/2018 05:37, Jaikiran Pai wrote:  I'm in the process of creating the patch and will send it out to this list soon. Best to send it to the net-dev list as this is where the java.net API is mostly maintained. Will do. Thank you. -Jaikiran

RE: RFR(M): 8201593: Print array length in ArrayIndexOutOfBoundsException.

2018-04-19 Thread Lindenmaier, Goetz
Hi Roger, I removed the constructor im my latest webrev. Best regards, Goetz. > -Original Message- > From: hotspot-runtime-dev [mailto:hotspot-runtime-dev- > boun...@openjdk.java.net] On Behalf Of Roger Riggs > Sent: Donnerstag, 19. April 2018 19:21 > To: David Holmes ; core-libs- > d