Re: (M) RFR: 8200167: Validate more special case invocations

Hi David, On 27.04.2018 00:04, David Holmes wrote: >> src/hotspot/share/c1/c1_Canonicalizer.cpp >> ... >>   void Canonicalizer::do_CheckCast  (CheckCast*   x) { >> -  if (x->klass()->is_loaded()) { >> +  if (x->klass()->is_loaded() && !x->is_invokespecial_receiver_check()) >> >> It seems

[11] RFR:JDK-8179071:Month value is inconsistent between CLDR and Java in some special locales

Hi, Kindly review the fix for JDK-8179071. Bug : https://bugs.openjdk.java.net/browse/JDK-8179071 Patch: http://cr.openjdk.java.net/~rgoel/JDK-8179071/webrev.03/index.html Fix is to parse and store language aliases( Deprecated and Legacy ) from CLDR's SupplemetalMetaData file. At run time, If

RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

Hi Thomas, Look at this blog: https://www.ibm.com/developerworks/aix/library/au-aix-symbol-visibility-part2/index.html if I understand it correctly, the xlc 12 default behavior should be like what we'd expect from -qvisibility=hidden. Best regards Christoph > -Original Message- > Fr

Re: Review Request JDK-8201793: (ref) Reference object should not support cloning

On 4/27/18 3:35 AM, Paul Sandoz wrote: Hi Mandy, This looks reasonable. I suspect external subtypes of the j.l.ref types are extremely rare (grep code reports no derived types) and of those it would likely be even rarer for those subtypes to implement Cloneable, and for that functionality t

Re: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

Hi, This was added by "8200178: Remove mapfiles for JDK native libraries". But if the flag is not accepted, what is the default behavior? Do we now export everything? I'd like to understand this first before removing the flag to get rid of the warnings. Best Regards, Thomas On Thu, Apr 26, 2018

RFR(JDK11/NIO) 8202285: (fs) Add a method to Files for comparing file contents

Hi, Considering extending isSameFile to add isSameContent to Files. Please review. JBS: https://bugs.openjdk.java.net/browse/JDK-8202285 webrev: http://cr.openjdk.java.net/~joehw/jdk11/8202285/webrev/ specdiff: http://cr.openjdk.java.net/~joehw/jdk11/8202285/specdiff/java/nio/file/Files.htm

RFR (JDK11/NIO) 8201276: (fs) Add methods to Files for reading/writing a string from/to a file

Hi, We're looking into adding methods to Files to read a file into a String/write a String to a file. Below is the current proposal. Please review. JBS: https://bugs.openjdk.java.net/browse/JDK-8201276 webrev: http://cr.openjdk.java.net/~joehw/jdk11/8201276/webrev/ specdiff: http://cr.open

Re: RFR: JDK-8202105: jshell tool: on exiting, terminal echo is disabled

+1 (nit: remove the "where:" and the corresponding indent before push please). On 4/26/18, 1:34 PM, Jan Lahoda wrote: Ok, here is an updated webrev: http://cr.openjdk.java.net/~jlahoda/8202105/webrev.02/ Jan

Re: (M) RFR: 8200167: Validate more special case invocations

Thanks Karen! Once my re-testing has completed I'll look at pushing this. David On 27/04/2018 7:21 AM, Karen Kinnear wrote: Looks good! Thank you so much David and Vladimir for all the work to cover the corner cases. thanks, Karen On Apr 26, 2018, at 12:12 AM, David Holmes wrote: Revised

Re: (M) RFR: 8200167: Validate more special case invocations

Hi Vladimir, On 27/04/2018 7:07 AM, Vladimir Ivanov wrote: David, thanks for taking care of the bug! Thanks for all the help! src/hotspot/share/c1/c1_Canonicalizer.cpp ...  void Canonicalizer::do_CheckCast  (CheckCast*   x) { -  if (x->klass()->is_loaded()) { +  if (x->klass()->is_l

Re: (M) RFR: 8200167: Validate more special case invocations

Looks good! Thank you so much David and Vladimir for all the work to cover the corner cases. thanks, Karen > On Apr 26, 2018, at 12:12 AM, David Holmes wrote: > > Revised webrev: http://cr.openjdk.java.net/~dholmes/8200167/webrev.v2/ > > Karen formulated an additional test scenario invoking O

Re: (M) RFR: 8200167: Validate more special case invocations

David, thanks for taking care of the bug! src/hotspot/share/c1/c1_Canonicalizer.cpp ... void Canonicalizer::do_CheckCast (CheckCast* x) { - if (x->klass()->is_loaded()) { + if (x->klass()->is_loaded() && !x->is_invokespecial_receiver_check()) It seems like it's not something specif

Re: RFR: JDK-8202105: jshell tool: on exiting, terminal echo is disabled

On 26.4.2018 20:09, Xueming Shen wrote: On 4/26/18, 3:23 AM, Jan Lahoda wrote: On 25.4.2018 22:59, Xueming Shen wrote: On 04/25/2018 01:39 PM, Jan Lahoda wrote: So, if I understand correctly, it would be: boolean flipEcho; and the readPassword would do something like: if (echo0() != false) {

Please review CSR: JDK-8200435 String::stripIndent, String::stripMarkers

Please review and mark as reviewed https://bugs.openjdk.java.net/browse/JDK-8200435

Re: Review Request JDK-8201793: (ref) Reference object should not support cloning

Hi Mandy, This looks reasonable. I suspect external subtypes of the j.l.ref types are extremely rare (grep code reports no derived types) and of those it would likely be even rarer for those subtypes to implement Cloneable, and for that functionality to operate reliably. Paul. > On Apr 26, 2

Re: [11] RFR: 8181157: CLDR Timezone name fallback implementation

+1 On 4/23/18, 6:25 PM, Naoto Sato wrote: Hi Sherman, thanks for the review. On 4/23/18 1:06 PM, Xueming Shen wrote: Naoto, Here some comments (1) CLDRTimeZoneNameProviderImpl.java: Ln#58: to use Stream.toArray(String[]::new) ? no sure which one is faster Ln#155-160:

RFR 8197388: Added not existing bug id in jdk/ProblemList.txt

Hi, Please review patch that fixes typo in bug id. diff -r 3661f31c6df4 test/jdk/ProblemList.txt --- a/test/jdk/ProblemList.txt Thu Apr 26 11:19:05 2018 -0500 +++ b/test/jdk/ProblemList.txt Thu Apr 26 11:47:18 2018 -0700 @@ -243,7 +243,7 @@ sun/java2d/SunGraphics2D/EmptyClipRenderingTest.java

Re: RFR: JDK-8202105: jshell tool: on exiting, terminal echo is disabled

On 4/26/18, 3:23 AM, Jan Lahoda wrote: On 25.4.2018 22:59, Xueming Shen wrote: On 04/25/2018 01:39 PM, Jan Lahoda wrote: So, if I understand correctly, it would be: boolean flipEcho; and the readPassword would do something like: if (echo0() != false) { if (echo0()) { ... flipEcho = true

Re: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

Looks ok. /Erik On 2018-04-26 07:13, Baesken, Matthias wrote: Hello , could you please review this small adjustment to the symbol visibility compilation settings on AIX ? Currently we use XLC 12.1 to compile JDK on AIX . However XLC 12.1 does not support the "-qvisibility=hidden"

Re: RFR: 8202330: Add Unreferenced{FOS,FIS,RAF}ClosesFd to problem list

On 26/04/2018 16:41, Mikael Vidstedt wrote: The java/io/*/Unreferenced{FOS,FIS,RAF}ClosesFd tests are failing quite frequently and should be added to the problem list until the issue (tracked by https://bugs.openjdk.java.net/browse/JDK-8202292

Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5

Hi Volker, Thank you. I will address your review comments and send webrev for review. - Bhaktavatsal Reddy -Volker Simonis wrote: - To: Bhaktavatsal R Maram From: Volker Simonis Date: 04/26/2018 09:12PM Cc: Java Core Libs Subject: Re: [AIX] Fix codepage mappings in Java for IBM-

Re: RFR: 8202330: Add Unreferenced{FOS, FIS, RAF}ClosesFd to problem list

Hi Mikael, +1 Thanks, Brian On Apr 26, 2018, at 8:41 AM, Mikael Vidstedt wrote: > The java/io/*/Unreferenced{FOS,FIS,RAF}ClosesFd tests are failing quite > frequently and should be added to the problem list until the issue (tracked > byhttps://bugs.openjdk.java.net/browse/JDK-8202292

Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5

Hi Bhaktavatsal Reddy, I've opened the following issue for this problem: 8202329: [AIX] Fix codepage mappings for IBM-943 and Big5 https://bugs.openjdk.java.net/browse/JDK-8202329 Looking at you fix, can you please replace the "#elif AIX" by "#ifdef AIX" and the original "#else" by "#ifdef __sol

RFR: 8202330: Add Unreferenced{FOS,FIS,RAF}ClosesFd to problem list

The java/io/*/Unreferenced{FOS,FIS,RAF}ClosesFd tests are failing quite frequently and should be added to the problem list until the issue (tracked by https://bugs.openjdk.java.net/browse/JDK-8202292 ) has been resolved: Bug: https://bugs.openj

Re: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

Hi Matthias, after Bhaktavatsal Reddy's report about the problems with "-qvisibility" with xlC 13 and taking into account that we can't test this anyway because we don't currently have xlC 13 on our machines I think it would be best to completely remove this option for now on AIX. Once we get xlC

Re: RFR: 8202324: Avoid loading FileInput-/OutputStream$AltFinalizer

On 2018-04-26 15:49, Alan Bateman wrote: Webrev: http://cr.openjdk.java.net/~redestad/8202324/open.00/ This looks okay as the AltFinalizer classes are only needed when code is extending FIS or FOS. Thanks, Alan! /Claes

RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

Hi Matthias, At this point, I think we can remove the flag as you found that it is not supported in XLC < 13. And with XLC 13, it require more work to use this flag. Thanks, Bhaktavatsal Reddy -"Baesken, Matthias" wrote: - To: "Langer, Christoph" , "'build-...@openjdk.java.net'" ,

RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

Hello Christoph, I think all XLC versions < 12.1 are unsupported (and probably not working anyway) for the OpenJDK build . I am only aware of XLC versions 12.1 and 13.1which work / in case of 13.1 "might" work for OpenJDK compilation . And for 12.1 I want to remove the f

RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

Hi Matthias, to me the change in principal looks good. I'm wondering if it is possible to do a comparison like xlc < 13 (e.g. extract major number before the first dot, then compare numerically) - but maybe it is too complicated and the current single version compare suits our needs ? Best reg

RE: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

> Its right in time. I am facing "Undefined Symbol" errors with XLC 13.1 due to > "-qvisibility=hidden" which hides all symbols by default. I workaround that by > removing this flag Hello, so it seems that I better remove the "-qvisibility=" completely for xlc (and not only for xlc12

Re: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

Hi Matthias, Its right in time. I am facing "Undefined Symbol" errors with XLC 13.1 due to "-qvisibility=hidden" which hides all symbols by default. I workaround that by removing this flag -bash-4.4$ xlC -qversion IBM XL C/C++ for AIX, V13.1.3 (5725-C72, 5765-J07) Version: 13.01.0003. Look

Re: RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

Hi Matthias, I would prefer a numerical comparison to version < 13. Otherwise the code looks like you want to just exclude 12.1 for some reason when in reality you want to omit the flag for any compiler older than xlc 13. Best Regards, Thomas On Thu, Apr 26, 2018 at 4:13 PM, Baesken, Matthias

Review Request JDK-8201793: (ref) Reference object should not support cloning

The semantics of cloning a Reference object is not clearly defined. In addition, it is questionable whether it can be meaningfully supported in particular with concurrent reference processing. The reachability state of a Reference object may change during GC reference processing. The referent

RFR : 8202322: AIX: symbol visibility flags not support on xlc 12.1

Hello , could you please review this small adjustment to the symbol visibility compilation settings on AIX ? Currently we use XLC 12.1 to compile JDK on AIX . However XLC 12.1 does not support the "-qvisibility=hidden" setting currently set on AIX. It was introduced with XLC 13.1 . C

Re: [AIX] Fix codepage mappings in Java for IBM-943 and Big5

Oops! Looks like there is problem with attachment (might be because I attached .class file as well). I'm pasting the fix and test program here in mail. Test Program: import java.nio.charset.*; class PrintDefaultCharset { public static void main(String[] args) { System.out.println("L

[AIX] Fix codepage mappings in Java for IBM-943 and Big5

Hi All, This issue is continuation to bug 8201540 (Extend the set of supported charsets in java.base on AIX) in which we have moved default charsets of most of the locales supported by Operating System to java.base module thus enabling OpenJDK on those locales for AIX platform. As part of tha

Re: RFR: 8202324: Avoid loading FileInput-/OutputStream$AltFinalizer

On 26/04/2018 14:30, Claes Redestad wrote: Hi, we can avoid eagerly loading the FileInput-/OutputStream$AltFinalizer classes on normal use, which is a small startup win. Webrev: http://cr.openjdk.java.net/~redestad/8202324/open.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8202324 This l

RFR: 8202324: Avoid loading FileInput-/OutputStream$AltFinalizer

Hi, we can avoid eagerly loading the FileInput-/OutputStream$AltFinalizer classes on normal use, which is a small startup win. Webrev: http://cr.openjdk.java.net/~redestad/8202324/open.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8202324 Thanks! /Claes

Re: 8202284: FileChannel and FileOutpuStream variants of AtomicAppend should pass silently on macOS >= 10.13

> On 25 Apr 2018, at 23:11, Brian Burkhalter > wrote: > > Issue:https://bugs.openjdk.java.net/browse/JDK-8202284 > Patch:http://cr.openjdk.java.net/~bpb/8202284/webrev.00/ I think this looks good Brian. > On 26 Apr 2018, at 01:09, Brian Burkhalter > wrote: > > https://bugs.

Re: RFR: JDK-8202105: jshell tool: on exiting, terminal echo is disabled

On 25.4.2018 22:59, Xueming Shen wrote: On 04/25/2018 01:39 PM, Jan Lahoda wrote: So, if I understand correctly, it would be: boolean flipEcho; and the readPassword would do something like: if (echo0() != false) { if (echo0()) { ... flipEcho = true; echo(false); } if (flipEcho)

Re: [PATCH] Prefer TMPDIR over hard coded /tmp

Right, it's come a few times. In principle it seems reasonable but it will likely have a tail of issues. One concern is that it will cause issues with the attach mechanism as that depends on the tool side knowing the target VM's tmp dir. There's also the transition issue where old JDKs will b