Re: [PATCH] JDK-8159797 Throw a right IllegalArgumentException from the bytecode generated by Method/ConstructorAccessor

2018-05-13 Thread Jaikiran Pai
Mandy, thank you for reviewing this change. Comments inline. On 11/05/18 11:10 PM, mandy chung wrote: With your patch, IAE thrown with empty message is less desirable even though it does not provide less information than the current message (NPE::toString).   I wonder if we could define an e

Re: RFR for 6443578 and 6202130: UTF-8 in Manifests / interesting impl and use of deprecated code

2018-05-13 Thread Philipp Kunz
Hi Sherman and everyone, Thanks again that you already had a look at my last proposal and for your most valuable input. While my originally intended changes for 6443578 and 6202130 are now [1] and [2] (still pending), I just wondered whether the code you pointed out would be worth cleaning up

Question/discussion how to resolve 8196371, 4271239, 4935610, and 6910466 about missing manifest version in Attributes#writeMain

2018-05-13 Thread Philipp Kunz
Hi, Bugs 8196371, 4271239, 4935610, and 6910466 all are about manifests with no version. Which approach would be preferable? 0) leave the impl as is - close with resolution won't fix 1) assume a version automatically if not explicitly set (suggested in 6910466 and 4271239) 2) throw an excep

Re: RFR for 6443578 and 6202130: UTF-8 in Manifests

2018-05-13 Thread Philipp Kunz
Hi Brain and Roger, Thank you very much for your hint about submitting patches. In the meantime I got feeback [1] from Xueming Shen and I sent two (much) smaller portions [2] and [3] which makes [5] now obsolete. I saw through my own messages again and found them having the patches attached.