[11] RFR JDK-8203474: Update description of "Cyrillic Supplementary" block name in Character.UnicodeBlock class.

2018-05-27 Thread Rachna Goel
Hi, Kindly review this small doc fix to Character.UnicodeBlock class. Bug: https://bugs.openjdk.java.net/browse/JDK-8203474 Patch: --- a/src/java.base/share/classes/java/lang/Character.javaSun May 27 12:00:16 2018 +0530 +++ b/src/java.base/share/classes/java/lang/Character.java Mon May 28

Re: RFR: 8193154: methods in java.time's TCKZoneRules OpenJDK test miss @Test annotation

2018-05-27 Thread Lance Andersen
Hi Vivek, I suspect the submitter of the issue, was not aware of the option of putting the annotation on the class. If you needed additional attributes for the annotation, then it makes sense to add them but given there are no attributes needed, the annotation on the class should be enough Be

RE: RFR: 8193154: methods in java.time's TCKZoneRules OpenJDK test miss @Test annotation

2018-05-27 Thread Vivek Theeyarath
Hi Lance, Thanks for the feedback. I did notice the @Test at the class level. The motivation behind the fix was a comment in the bug saying not having the annotation at the method level affects correct processing of TCKZoneRules and inclusion of test methods into master test list