Re: RFR: JDK-8203827: Upgrade JLine to 2.14.6

2018-05-29 Thread Alan Bateman
On 25/05/2018 21:20, Jan Lahoda wrote: Hi, I'd like to upgrade the JLine used by JShell and jjs from 2.12.1 to 2.14.6. The complete webrev is here: http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/complete/ To simplify reviewing, there is: -an antipatch that removes the JDK-specific cha

RFR: JDK-8050818 Predicate::not - provide an easier way to negate a predicate

2018-05-29 Thread Jim Laskey
Introduce a new static method Predicate::not which will allow developers to negate predicate lambdas trivially. webrev: http://cr.openjdk.java.net/~jlaskey/8050818/webrev/index.html bug: https://bugs.openjdk.java.net/browse/JDK-8050818 csr: https://bugs.openjdk.java.net/browse/JDK-8203428

Re: RFR: JDK-8050818 Predicate::not - provide an easier way to negate a predicate

2018-05-29 Thread Zheka Kozlov
What about "not null" predicate? This is also very common. Right now it is possible via `Objects::nonNull` but many people do not know about this method. So, having a `Predicate.notNull` method would be nice. 2018-05-29 19:52 GMT+07:00 Jim Laskey : > Introduce a new static method Predicate::not w

Re: RFR: JDK-8203827: Upgrade JLine to 2.14.6

2018-05-29 Thread Jan Lahoda
Hi, On 29.5.2018 14:51, Alan Bateman wrote: On 25/05/2018 21:20, Jan Lahoda wrote: Hi, I'd like to upgrade the JLine used by JShell and jjs from 2.12.1 to 2.14.6. The complete webrev is here: http://cr.openjdk.java.net/~jlahoda/8203827/webrev.00/complete/ To simplify reviewing, there is: -an

Re: RFR: JDK-8203827: Upgrade JLine to 2.14.6

2018-05-29 Thread Hannes Wallnöfer
Hi Jan, Nashorn changes look good. I noticed one slight change of behaviour in jjs. When I enter „java.m“ and hit the tab key, it autocompletes to „java.math “, adding a space character at the end. This is a bit inconvenient, and the old version of jline didn’t do that. Hannes > Am 25.05.201

Re: [11] RFR JDK-8203474: Update description of "Cyrillic Supplementary" block name in Character.UnicodeBlock class.

2018-05-29 Thread Naoto Sato
Looks good. Naoto On 5/27/18 11:26 PM, Rachna Goel wrote: Hi, Kindly review this small doc fix to Character.UnicodeBlock class. Bug: https://bugs.openjdk.java.net/browse/JDK-8203474 Patch: --- a/src/java.base/share/classes/java/lang/Character.java    Sun May 27 12:00:16 2018 +0530 +++ b/sr

Re: RFR: JDK-8203827: Upgrade JLine to 2.14.6

2018-05-29 Thread Jan Lahoda
Hi Hannes, On 29.5.2018 17:32, Hannes Wallnöfer wrote: Hi Jan, Nashorn changes look good. I noticed one slight change of behaviour in jjs. When I enter „java.m“ and hit the tab key, it autocompletes to „java.math “, adding a space character at the end. This is a bit inconvenient, and the old

Re: RFR: 8203886: Invoke LambdaMetafactory::altMetafactory exactly from the BootstrapMethodInvoker

2018-05-29 Thread mandy chung
On 5/28/18 6:00 AM, Claes Redestad wrote: Hi, similarly to JDK-8198418[1], we can avoid creation of various LambdaForms and SpeciesData types in various benchmarks by adapting calls to the altMetafactory as exactly as possible in the BootstrapMethodInvoker. Webrev: http://cr.openjdk.java

RFR: JDK-8203839: API clarification: versioned jar entry verification in multi-release jar file

2018-05-29 Thread Xueming Shen
Hi, Please help review the proposed api spec update for JDK-8203839 (and its CSR) issue: JDK-8203839: API clarification: versioned jar entry verification in multi-release jar file csr: https://bugs.openjdk.java.net/browse/JDK-8203840 webrev: http://cr.openjdk.java.net/~sherman/8203839/webrev

Re: RFR: 8203886: Invoke LambdaMetafactory::altMetafactory exactly from the BootstrapMethodInvoker

2018-05-29 Thread Claes Redestad
On 2018-05-29 20:05, mandy chung wrote: On 5/28/18 6:00 AM, Claes Redestad wrote: Hi, similarly to JDK-8198418[1], we can avoid creation of various LambdaForms and SpeciesData types in various benchmarks by adapting calls to the altMetafactory as exactly as possible in the BootstrapMeth

Re: RFR: JDK-8203839: API clarification: versioned jar entry verification in multi-release jar file

2018-05-29 Thread Weijun Wang
Looks fine to me. Thanks Max > On May 30, 2018, at 3:22 AM, Xueming Shen wrote: > > Hi, > > Please help review the proposed api spec update for JDK-8203839 (and its CSR) > > issue: JDK-8203839: API clarification: versioned jar entry verification in > multi-release jar file > csr: https://bug