Re: Review Request: 8204648: test/jdk/tools/launchers/SourceMode.java fails with long shebang line

I run into some issue with shebang tests. Since Jon is on vacation, I revise the patch to skip the shebang test temporarily until he returns. Mandy diff --git a/test/jdk/tools/launcher/SourceMode.java b/test/jdk/tools/launcher/SourceMode.java --- a/test/jdk/tools/launcher/SourceMode.java +++

Review Request: 8204648: test/jdk/tools/launchers/SourceMode.java fails with long shebang line

JDK-8204588 [1] fixed the test failure caused by long paths to the Java launcher in some test execution environments, causing the shebang line to overflow the underlying system limit of 128 characters. The test needs a small tweak to the max javaCmd length to reduce from 100 to 90 since the ar

Re: RFR: JDK-8204588: Test failures after "Launch Single-File Source-Code Programs"

On 6/8/18 3:06 PM, Jonathan Gibbons wrote: Please review two test fixes related to the source launcher feature. In one test, the fix is to use File.separator to construct "golden output" for comparison. In the other test, the failure was caused by excessively long paths to the Java launche

RFR: JDK-8204588: Test failures after "Launch Single-File Source-Code Programs"

Please review two test fixes related to the source launcher feature. In one test, the fix is to use File.separator to construct "golden output" for comparison. In the other test, the failure was caused by excessively long paths to the Java launcher in some test execution environments, causing

Re: RFR 8204565 : (spec) Document java.{vm.}?specification.version system properties' relation to $FEATURE

On 6/8/18 12:27 PM, mandy chung wrote: Webrev: http://cr.openjdk.java.net/~bchristi/8204565/webrev/ test/jdk/java/lang/System/Versions.java   it can also verify java.vm.specification.version. The hotspot test looks to me that it should expect the test be run with OpenJDK build and the vend

Re: [JDK 11] RFR 8201528: Add new test to check for package versioning information in OpenJDK

On 6/8/18 12:07 AM, Chris Yin wrote: Hi, Mandy Many thanks for your detailed review and comments, updates new webrev as below, and comment inline, thanks webrev: http://cr.openjdk.java.net/~xyin/8201528/webrev.01/ Thanks for adding the test description, that is very helpful. This is looki

Re: RFR 8204565 : (spec) Document java.{vm.}?specification.version system properties' relation to $FEATURE

On 6/8/18 12:11 PM, Brent Christian wrote: On 6/7/18 1:24 PM, mandy chung wrote: Issue: https://bugs.openjdk.java.net/browse/JDK-8204565 Webrev: http://cr.openjdk.java.net/~bchristi/8204565/webrev/ Is there an existing test validating this? Looks like there is (kind of), for libs and fo

Re: RFR 8204565 : (spec) Document java.{vm.}?specification.version system properties' relation to $FEATURE

On 6/7/18 1:24 PM, mandy chung wrote: Issue: https://bugs.openjdk.java.net/browse/JDK-8204565 Webrev: http://cr.openjdk.java.net/~bchristi/8204565/webrev/ Is there an existing test validating this? Looks like there is (kind of), for libs and for hotspot. I've rev'ed the webrev in place wi

Re: RFC: Experiment in accessing/managing persistent memory from Java

Hi Paul Looks like we're all on the same page regarding the basic approach of using a small API and making the critical bits intrinsic. We perhaps have some way to go on exactly what that API looks like in terms of the classes and methods, but iterating on it by discussion of a JEP seems li

Re: RFR (XL): JDK-8204572 SetupJdkLibrary should setup SRC and -I flags automatically

Looks good. /Erik On 2018-06-08 01:50, Magnus Ihse Bursie wrote: On 2018-06-07 23:20, Erik Joelsson wrote: Hello Magnus, Very nice refactoring! Thanks! JdkNativeCompilation.gmk line 126-127 looks a bit long. There is an extra space on 126. Also, why not addprefix for adding -I instead o

Re: Ping!! Re: RFR: 8203357 Container Metrics

Hi Harsha,   Thank you for the explanation, makes sense to me. Please be aware, if a specific test turns out to be unstable in CI testing, it should be problem listed until solution is found to make it more stable. If the test is highly intermittent (fails intermittently but rarely) then it s

Re: Ping!! Re: RFR: 8203357 Container Metrics

I didn’t actually have any ERROR_MARGIN problems during testing. I had issues with the testCpuConsumption test in http://cr.openjdk.java.net/~bobv/8203357/webrev.01/test/lib/jdk/test/lib/containers/cgroup/MetricsTester.java.html

Re: [11] RFR: 8202088: Japanese new era implementation

Hi Naoto, test/jdk/java/util/Calendar/SupplementalJapaneseEraTest.java: 125 missing spaces around "+". Please rename the test to have functional name. (test/jdk/java/util/Calendar/Bug8202088.java) We're trying to get away for uninformative bug numbers for tests. No further review from me ne

RFR: 8196993: Resolve disabled warnings for libunpack

Hi, Please review http://cr.openjdk.java.net/~sdama/8196993/webrev.00/ for https://bugs.openjdk.java.net/browse/JDK-8196993 Regards, Srinivas

Re: RFR JDK-8204229: Formatter and String.format ignore the width with the percent modifier (%5%)

+1 > On Jun 7, 2018, at 11:33 PM, Xueming Shen wrote: > > Hi, > > Please help review the change for JDK-8204229. It appears to be a overlook > in the implementation. We do have a method print(String, Locale) that adjust > the "padding spaces" > > issue: https://bugs.openjdk.java.net/browse/JD

Re: [RFR] 8204539: improve error messages in matchJavaTZ [windows]

Looks good. Thanks for adding this improvement. Regards, Sean. On 08/06/18 12:28, Baesken, Matthias wrote: Hi Goetz/Christoph, thanks for the reviews . However of course Sean is absolutely correct about the null character message output. Updated the null character related message output :

RE: [RFR] 8204539: improve error messages in matchJavaTZ [windows]

Hi Goetz/Christoph, thanks for the reviews . However of course Sean is absolutely correct about the null character message output. Updated the null character related message output : http://cr.openjdk.java.net/~mbaesken/webrevs/8204539.2/ Best regards, Matthias > -Original Message

Re: RFR (XL): JDK-8204572 SetupJdkLibrary should setup SRC and -I flags automatically

On 2018-06-07 23:20, Erik Joelsson wrote: Hello Magnus, Very nice refactoring! Thanks! JdkNativeCompilation.gmk line 126-127 looks a bit long. There is an extra space on 126. Also, why not addprefix for adding -I instead of clunky foreach? Not that I care greatly, but I usually prefer that

Re: [RFR] 8204539: improve error messages in matchJavaTZ [windows]

Not sure if this has been tested. Don't you need to escape the printing of the \0 character ? errorMessage = "illegal character \0 found"; regards, Sean. On 08/06/2018 08:14, Langer, Christoph wrote: Hi Matthias, this looks good. Reviewed from my end. Best regards Christoph *From:*Baesk

RE: RFR : 8204541 Correctly support AIX xlC 13.1 symbol visibility flags

Hi Ichiroh, Ok, so as per the output, via the include of osSupport.hpp, something must happen which undeclares "visibility" or makes it ambiguous. Looking at osSupport.hpp, I can't see anything special. It would just include pthread.h and declare some c++ classes. You could try to get and anal

RE: [RFR] 8204539: improve error messages in matchJavaTZ [windows]

Hi Matthias, thanks for adding this information, looks good! Best regards, Goety. > -Original Message- > From: Baesken, Matthias > Sent: Freitag, 8. Juni 2018 08:51 > To: Langer, Christoph ; core-libs- > d...@openjdk.java.net; 'sean.cof...@oracle.com' > > Cc: Lindenmaier, Goetz > Su

RE: [RFR] 8204539: improve error messages in matchJavaTZ [windows]

Hi Matthias, this looks good. Reviewed from my end. Best regards Christoph From: Baesken, Matthias Sent: Freitag, 8. Juni 2018 08:51 To: Langer, Christoph ; core-libs-dev@openjdk.java.net; 'sean.cof...@oracle.com' Cc: Lindenmaier, Goetz Subject: RE: [RFR] 8204539: improve error messages in m

Re: [JDK 11] RFR 8201528: Add new test to check for package versioning information in OpenJDK

Hi, Mandy Many thanks for your detailed review and comments, updates new webrev as below, and comment inline, thanks webrev: http://cr.openjdk.java.net/~xyin/8201528/webrev.01/ > On 8 Jun 2018, at 6:38 AM, mandy chung wrote: > > Hi Chris